public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Vankar, Chintan" <c-vankar@ti.com>
Cc: Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>, Peter Rosin <peda@axentia.se>,
	s-vadapalli@ti.com, danishanwar@ti.com,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Vignesh Raghavendra <vigneshr@ti.com>, Nishanth Menon <nm@ti.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH v2 0/2] Extend mmio-mux driver to configure mux with new DT property
Date: Sat, 31 May 2025 14:28:51 +0200	[thread overview]
Message-ID: <2025053121-sterile-doorman-57a0@gregkh> (raw)
In-Reply-To: <7024867d-91ac-40eb-b41f-eed811032f95@ti.com>

On Sat, May 31, 2025 at 03:07:14PM +0530, Vankar, Chintan wrote:
> Hello Greg,
> 
> On 5/31/2025 11:22 AM, Greg Kroah-Hartman wrote:
> > On Fri, May 30, 2025 at 10:35:24PM +0530, Vankar, Chintan wrote:
> > > Hello Greg,
> > > 
> > > I have tried to implement Timesync Router node to the suitable
> > > Subsystems (Interrupt controller and Mux-controller). Thomas
> > > has provided a feedback with a reason why Timesync Router is not
> > > suitable for irqchip. But I didn't get a proper feedback for mux-
> > > controller subsystem.
> > 
> > What do you mean "proper feedback"?
> > 
> 
> By proper feedback, I meant, from the comments I was not able to figure
> out whether Timesync Router will be acceptable in the "mux-controller"
> subsystem or not.

Did you submit a real patch to do so?  Note, I know I do not read "RFC"
patches for the most part as that implies the submitter does not feel it
is ready to be merged, when I have other patches that submitters _do_
feel are ready to be merged that are still left to review.

> > > Can you please help me deciding in which subsystem I should implement
> > > it, if not mux-controller can it go in drivers/misc ?
> > 
> > Why not mux?  What's preventing that from happening?  Why would misc be
> > better?
> > 
> 
> Sure, if mux-controller subsystem is acceptable, I will implement the
> Timesync Router with that and post a series.

Try it and see!  We don't normally do "what if I did this" type of
review, we want to see patches that actually work.

thanks,

greg k-h

      reply	other threads:[~2025-05-31 12:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-04 10:23 [RFC PATCH v2 0/2] Extend mmio-mux driver to configure mux with new DT property Chintan Vankar
2025-03-04 10:23 ` [RFC PATCH v2 1/2] devicetree: bindings: mux: reg-mux: Update bindings for reg-mux for new property Chintan Vankar
2025-03-04 10:47   ` Vankar, Chintan
2025-03-04 15:39   ` Rob Herring
2025-03-04 19:03     ` Vankar, Chintan
2025-03-04 20:40       ` Rob Herring
2025-03-05 21:43         ` Vankar, Chintan
2025-03-05 22:14           ` Rob Herring
2025-03-05 22:30             ` Vankar, Chintan
2025-04-22  8:42               ` Chintan Vankar
2025-03-04 10:23 ` [RFC PATCH v2 2/2] mux: mmio: Extend mmio-mux driver to configure mux with new DT property Chintan Vankar
2025-05-20  5:29 ` [RFC PATCH v2 0/2] " Chintan Vankar
2025-05-30 17:05   ` Vankar, Chintan
2025-05-31  5:52     ` Greg Kroah-Hartman
2025-05-31  9:37       ` Vankar, Chintan
2025-05-31 12:28         ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025053121-sterile-doorman-57a0@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=c-vankar@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=danishanwar@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=peda@axentia.se \
    --cc=robh@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=tglx@linutronix.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox