From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>,
Kan Liang <kan.liang@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Subject: [PATCH 6/6] perf annotate: Add 'y' hot key to toggle data type display
Date: Sat, 31 May 2025 23:53:02 -0700 [thread overview]
Message-ID: <20250601065302.12531-7-namhyung@kernel.org> (raw)
In-Reply-To: <20250601065302.12531-1-namhyung@kernel.org>
Support data type display with a key press so that users can toggle the
output dynamically on TUI.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/ui/browsers/annotate.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index 686fa54e545e275c..cd1d452035a265d3 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -827,7 +827,8 @@ static int annotate_browser__run(struct annotate_browser *browser,
"b Toggle percent base [period/hits]\n"
"B Branch counter abbr list (Optional)\n"
"? Search string backwards\n"
- "f Toggle showing offsets to full address\n");
+ "f Toggle showing offsets to full address\n"
+ "y Toggle data type display\n");
continue;
case 'r':
script_browse(NULL, NULL);
@@ -947,6 +948,11 @@ static int annotate_browser__run(struct annotate_browser *browser,
case 'f':
annotation__toggle_full_addr(notes, ms);
continue;
+ case 'y':
+ annotate_opts.code_with_type ^= 1;
+ if (browser->dbg == NULL)
+ browser->dbg = debuginfo__new(dso__long_name(map__dso(ms->map)));
+ continue;
case K_LEFT:
case '<':
case '>':
@@ -1035,8 +1041,7 @@ int __hist_entry__tui_annotate(struct hist_entry *he, struct map_symbol *ms,
ret = annotate_browser__run(&browser, evsel, hbt);
- if (annotate_opts.code_with_type)
- debuginfo__delete(browser.dbg);
+ debuginfo__delete(browser.dbg);
if(not_annotated)
annotated_source__purge(notes->src);
--
2.49.0
next prev parent reply other threads:[~2025-06-01 6:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-01 6:52 [PATCHSET 0/6] perf annotate: Support --code-with-type on TUI (v1) Namhyung Kim
2025-06-01 6:52 ` [PATCH 1/6] perf annotate: Rename to __hist_entry__tui_annotate() Namhyung Kim
2025-06-01 6:52 ` [PATCH 2/6] perf annotate: Remove __annotation_line__write() Namhyung Kim
2025-06-05 19:55 ` Arnaldo Carvalho de Melo
2025-06-05 19:59 ` Arnaldo Carvalho de Melo
2025-06-06 2:59 ` Namhyung Kim
2025-06-01 6:52 ` [PATCH 3/6] perf annotate: Pass annotation_print_data to annotaiton_line__write() Namhyung Kim
2025-06-05 20:44 ` Arnaldo Carvalho de Melo
2025-06-06 3:00 ` Namhyung Kim
2025-06-01 6:53 ` [PATCH 4/6] perf annotate: Simplify width calculation in annotation_line__write() Namhyung Kim
2025-06-01 6:53 ` [PATCH 5/6] perf annotate: Add --code-with-type support for TUI Namhyung Kim
2025-06-01 6:53 ` Namhyung Kim [this message]
2025-06-05 20:46 ` [PATCH 6/6] perf annotate: Add 'y' hot key to toggle data type display Arnaldo Carvalho de Melo
2025-06-05 21:12 ` Arnaldo Carvalho de Melo
2025-06-06 3:11 ` Namhyung Kim
2025-06-06 3:04 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250601065302.12531-7-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox