* [PATCH 5.10 151/270] arm64/mm: Check PUD_TYPE_TABLE in pud_bad()
2025-06-02 13:44 [PATCH 5.10 000/270] 5.10.238-rc1 review Greg Kroah-Hartman
@ 2025-06-02 13:47 ` Greg Kroah-Hartman
2025-06-02 16:49 ` [PATCH 5.10 000/270] 5.10.238-rc1 review Florian Fainelli
` (4 subsequent siblings)
5 siblings, 0 replies; 16+ messages in thread
From: Greg Kroah-Hartman @ 2025-06-02 13:47 UTC (permalink / raw)
To: stable
Cc: Greg Kroah-Hartman, patches, Will Deacon, Ard Biesheuvel,
Ryan Roberts, Mark Rutland, linux-arm-kernel, linux-kernel,
Anshuman Khandual, Catalin Marinas, Sasha Levin
5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ryan Roberts <ryan.roberts@arm.com>
[ Upstream commit bfb1d2b9021c21891427acc86eb848ccedeb274e ]
pud_bad() is currently defined in terms of pud_table(). Although for some
configs, pud_table() is hard-coded to true i.e. when using 64K base pages
or when page table levels are less than 3.
pud_bad() is intended to check that the pud is configured correctly. Hence
let's open-code the same check that the full version of pud_table() uses
into pud_bad(). Then it always performs the check regardless of the config.
Cc: Will Deacon <will@kernel.org>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Link: https://lore.kernel.org/r/20250221044227.1145393-7-anshuman.khandual@arm.com
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/arm64/include/asm/pgtable.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h
index 7756a365d4c49..d92b5aed354e9 100644
--- a/arch/arm64/include/asm/pgtable.h
+++ b/arch/arm64/include/asm/pgtable.h
@@ -601,7 +601,8 @@ static inline unsigned long pmd_page_vaddr(pmd_t pmd)
pr_err("%s:%d: bad pmd %016llx.\n", __FILE__, __LINE__, pmd_val(e))
#define pud_none(pud) (!pud_val(pud))
-#define pud_bad(pud) (!pud_table(pud))
+#define pud_bad(pud) ((pud_val(pud) & PUD_TYPE_MASK) != \
+ PUD_TYPE_TABLE)
#define pud_present(pud) pte_present(pud_pte(pud))
#define pud_leaf(pud) (pud_present(pud) && !pud_table(pud))
#define pud_valid(pud) pte_valid(pud_pte(pud))
--
2.39.5
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 5.10 000/270] 5.10.238-rc1 review
2025-06-02 13:44 [PATCH 5.10 000/270] 5.10.238-rc1 review Greg Kroah-Hartman
2025-06-02 13:47 ` [PATCH 5.10 151/270] arm64/mm: Check PUD_TYPE_TABLE in pud_bad() Greg Kroah-Hartman
@ 2025-06-02 16:49 ` Florian Fainelli
2025-06-02 16:50 ` Florian Fainelli
2025-06-02 20:37 ` Pavel Machek
` (3 subsequent siblings)
5 siblings, 1 reply; 16+ messages in thread
From: Florian Fainelli @ 2025-06-02 16:49 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, sudipm.mukherjee, srw, rwarsow,
conor, hargar, broonie
On 6/2/25 06:44, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.238 release.
> There are 270 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 04 Jun 2025 13:42:20 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.238-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
BMIPS_GENERIC:
Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
Similar build warning as reported for 5.4, due to the same commit:
commit b47e6abc7dc5772ecb45383d9956f9fcb7fdf33c
Author: Jeongjun Park <aha310510@gmail.com>
Date: Tue Apr 22 20:30:25 2025 +0900
tracing: Fix oob write in trace_seq_to_buffer()
commit f5178c41bb43444a6008150fe6094497135d07cb upstream.
In file included from ./include/linux/kernel.h:15,
from ./include/asm-generic/bug.h:20,
from ./arch/arm/include/asm/bug.h:60,
from ./include/linux/bug.h:5,
from ./include/linux/mmdebug.h:5,
from ./include/linux/mm.h:9,
from ./include/linux/ring_buffer.h:5,
from kernel/trace/trace.c:15:
kernel/trace/trace.c: In function 'tracing_splice_read_pipe':
./include/linux/minmax.h:20:35: warning: comparison of distinct pointer
types lacks a cast
20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
| ^~
./include/linux/minmax.h:26:18: note: in expansion of macro '__typecheck'
26 | (__typecheck(x, y) && __no_side_effects(x, y))
| ^~~~~~~~~~~
./include/linux/minmax.h:36:31: note: in expansion of macro '__safe_cmp'
36 | __builtin_choose_expr(__safe_cmp(x, y), \
| ^~~~~~~~~~
./include/linux/minmax.h:45:25: note: in expansion of macro '__careful_cmp'
45 | #define min(x, y) __careful_cmp(x, y, <)
| ^~~~~~~~~~~~~
kernel/trace/trace.c:6688:43: note: in expansion of macro 'min'
6688 |
min((size_t)trace_seq_used(&iter->seq),
| ^~~
--
Florian
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 5.10 000/270] 5.10.238-rc1 review
2025-06-02 16:49 ` [PATCH 5.10 000/270] 5.10.238-rc1 review Florian Fainelli
@ 2025-06-02 16:50 ` Florian Fainelli
2025-06-03 7:58 ` Greg Kroah-Hartman
0 siblings, 1 reply; 16+ messages in thread
From: Florian Fainelli @ 2025-06-02 16:50 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, sudipm.mukherjee, srw, rwarsow,
conor, hargar, broonie
On 6/2/25 09:49, Florian Fainelli wrote:
> On 6/2/25 06:44, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 5.10.238 release.
>> There are 270 patches in this series, all will be posted as a response
>> to this one. If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Wed, 04 Jun 2025 13:42:20 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/
>> patch-5.10.238-rc1.gz
>> or in the git tree and branch at:
>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-
>> rc.git linux-5.10.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
>
> On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
> BMIPS_GENERIC:
>
> Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
>
> Similar build warning as reported for 5.4, due to the same commit:
>
> commit b47e6abc7dc5772ecb45383d9956f9fcb7fdf33c
> Author: Jeongjun Park <aha310510@gmail.com>
> Date: Tue Apr 22 20:30:25 2025 +0900
>
> tracing: Fix oob write in trace_seq_to_buffer()
>
> commit f5178c41bb43444a6008150fe6094497135d07cb upstream.
>
> In file included from ./include/linux/kernel.h:15,
> from ./include/asm-generic/bug.h:20,
> from ./arch/arm/include/asm/bug.h:60,
> from ./include/linux/bug.h:5,
> from ./include/linux/mmdebug.h:5,
> from ./include/linux/mm.h:9,
> from ./include/linux/ring_buffer.h:5,
> from kernel/trace/trace.c:15:
> kernel/trace/trace.c: In function 'tracing_splice_read_pipe':
> ./include/linux/minmax.h:20:35: warning: comparison of distinct pointer
> types lacks a cast
> 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
> | ^~
> ./include/linux/minmax.h:26:18: note: in expansion of macro '__typecheck'
> 26 | (__typecheck(x, y) && __no_side_effects(x, y))
> | ^~~~~~~~~~~
> ./include/linux/minmax.h:36:31: note: in expansion of macro '__safe_cmp'
> 36 | __builtin_choose_expr(__safe_cmp(x, y), \
> | ^~~~~~~~~~
> ./include/linux/minmax.h:45:25: note: in expansion of macro '__careful_cmp'
> 45 | #define min(x, y) __careful_cmp(x, y, <)
> | ^~~~~~~~~~~~~
> kernel/trace/trace.c:6688:43: note: in expansion of macro 'min'
> 6688 | min((size_t)trace_seq_used(&iter->seq),
> | ^~~
>
And also this one:
commit e0a3a33cecd3ce2fde1de4ff0e223dc1db484a8d
Author: Eric Dumazet <edumazet@google.com>
Date: Wed Mar 5 13:05:50 2025 +0000
tcp: bring back NUMA dispersion in inet_ehash_locks_alloc()
[ Upstream commit f8ece40786c9342249aa0a1b55e148ee23b2a746 ]
on ARM64:
In file included from ./include/linux/kernel.h:15,
from ./include/linux/list.h:9,
from ./include/linux/module.h:12,
from net/ipv4/inet_hashtables.c:12:
net/ipv4/inet_hashtables.c: In function 'inet_ehash_locks_alloc':
./include/linux/minmax.h:20:35: warning: comparison of distinct pointer
types lacks a cast
20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
| ^~
./include/linux/minmax.h:26:18: note: in expansion of macro '__typecheck'
26 | (__typecheck(x, y) && __no_side_effects(x, y))
| ^~~~~~~~~~~
./include/linux/minmax.h:36:31: note: in expansion of macro '__safe_cmp'
36 | __builtin_choose_expr(__safe_cmp(x, y), \
| ^~~~~~~~~~
./include/linux/minmax.h:52:25: note: in expansion of macro '__careful_cmp'
52 | #define max(x, y) __careful_cmp(x, y, >)
| ^~~~~~~~~~~~~
net/ipv4/inet_hashtables.c:946:19: note: in expansion of macro 'max'
946 | nblocks = max(nblocks, num_online_nodes() * PAGE_SIZE /
locksz);
| ^~~
--
Florian
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 5.10 000/270] 5.10.238-rc1 review
2025-06-02 16:50 ` Florian Fainelli
@ 2025-06-03 7:58 ` Greg Kroah-Hartman
2025-06-03 16:00 ` Florian Fainelli
0 siblings, 1 reply; 16+ messages in thread
From: Greg Kroah-Hartman @ 2025-06-03 7:58 UTC (permalink / raw)
To: Florian Fainelli
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, sudipm.mukherjee, srw,
rwarsow, conor, hargar, broonie
On Mon, Jun 02, 2025 at 09:50:24AM -0700, Florian Fainelli wrote:
> On 6/2/25 09:49, Florian Fainelli wrote:
> > On 6/2/25 06:44, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 5.10.238 release.
> > > There are 270 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Wed, 04 Jun 2025 13:42:20 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/
> > > patch-5.10.238-rc1.gz
> > > or in the git tree and branch at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-
> > > rc.git linux-5.10.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
> > BMIPS_GENERIC:
> >
> > Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
> >
> > Similar build warning as reported for 5.4, due to the same commit:
> >
> > commit b47e6abc7dc5772ecb45383d9956f9fcb7fdf33c
> > Author: Jeongjun Park <aha310510@gmail.com>
> > Date: Tue Apr 22 20:30:25 2025 +0900
> >
> > tracing: Fix oob write in trace_seq_to_buffer()
> >
> > commit f5178c41bb43444a6008150fe6094497135d07cb upstream.
> >
> > In file included from ./include/linux/kernel.h:15,
> > from ./include/asm-generic/bug.h:20,
> > from ./arch/arm/include/asm/bug.h:60,
> > from ./include/linux/bug.h:5,
> > from ./include/linux/mmdebug.h:5,
> > from ./include/linux/mm.h:9,
> > from ./include/linux/ring_buffer.h:5,
> > from kernel/trace/trace.c:15:
> > kernel/trace/trace.c: In function 'tracing_splice_read_pipe':
> > ./include/linux/minmax.h:20:35: warning: comparison of distinct pointer
> > types lacks a cast
> > 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
> > | ^~
> > ./include/linux/minmax.h:26:18: note: in expansion of macro '__typecheck'
> > 26 | (__typecheck(x, y) && __no_side_effects(x, y))
> > | ^~~~~~~~~~~
> > ./include/linux/minmax.h:36:31: note: in expansion of macro '__safe_cmp'
> > 36 | __builtin_choose_expr(__safe_cmp(x, y), \
> > | ^~~~~~~~~~
> > ./include/linux/minmax.h:45:25: note: in expansion of macro '__careful_cmp'
> > 45 | #define min(x, y) __careful_cmp(x, y, <)
> > | ^~~~~~~~~~~~~
> > kernel/trace/trace.c:6688:43: note: in expansion of macro 'min'
> > 6688 | min((size_t)trace_seq_used(&iter->seq),
> > | ^~~
> >
>
> And also this one:
>
> commit e0a3a33cecd3ce2fde1de4ff0e223dc1db484a8d
> Author: Eric Dumazet <edumazet@google.com>
> Date: Wed Mar 5 13:05:50 2025 +0000
>
> tcp: bring back NUMA dispersion in inet_ehash_locks_alloc()
>
> [ Upstream commit f8ece40786c9342249aa0a1b55e148ee23b2a746 ]
>
>
> on ARM64:
>
> In file included from ./include/linux/kernel.h:15,
> from ./include/linux/list.h:9,
> from ./include/linux/module.h:12,
> from net/ipv4/inet_hashtables.c:12:
> net/ipv4/inet_hashtables.c: In function 'inet_ehash_locks_alloc':
> ./include/linux/minmax.h:20:35: warning: comparison of distinct pointer
> types lacks a cast
> 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
> | ^~
> ./include/linux/minmax.h:26:18: note: in expansion of macro '__typecheck'
> 26 | (__typecheck(x, y) && __no_side_effects(x, y))
> | ^~~~~~~~~~~
> ./include/linux/minmax.h:36:31: note: in expansion of macro '__safe_cmp'
> 36 | __builtin_choose_expr(__safe_cmp(x, y), \
> | ^~~~~~~~~~
> ./include/linux/minmax.h:52:25: note: in expansion of macro '__careful_cmp'
> 52 | #define max(x, y) __careful_cmp(x, y, >)
> | ^~~~~~~~~~~~~
> net/ipv4/inet_hashtables.c:946:19: note: in expansion of macro 'max'
> 946 | nblocks = max(nblocks, num_online_nodes() * PAGE_SIZE /
> locksz);
> | ^~~
>
For both of these, I'll just let them be as they are ok, it's just the
mess of our min/max macro unwinding causes these issues.
Unless they really bother someone, and in that case, a patch to add the
correct type to the backport to make the noise go away would be greatly
appreciated.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 5.10 000/270] 5.10.238-rc1 review
2025-06-03 7:58 ` Greg Kroah-Hartman
@ 2025-06-03 16:00 ` Florian Fainelli
2025-06-04 8:06 ` Greg Kroah-Hartman
0 siblings, 1 reply; 16+ messages in thread
From: Florian Fainelli @ 2025-06-03 16:00 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, sudipm.mukherjee, srw,
rwarsow, conor, hargar, broonie
On 6/3/25 00:58, Greg Kroah-Hartman wrote:
> On Mon, Jun 02, 2025 at 09:50:24AM -0700, Florian Fainelli wrote:
>> On 6/2/25 09:49, Florian Fainelli wrote:
>>> On 6/2/25 06:44, Greg Kroah-Hartman wrote:
>>>> This is the start of the stable review cycle for the 5.10.238 release.
>>>> There are 270 patches in this series, all will be posted as a response
>>>> to this one. If anyone has any issues with these being applied, please
>>>> let me know.
>>>>
>>>> Responses should be made by Wed, 04 Jun 2025 13:42:20 +0000.
>>>> Anything received after that time might be too late.
>>>>
>>>> The whole patch series can be found in one patch at:
>>>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/
>>>> patch-5.10.238-rc1.gz
>>>> or in the git tree and branch at:
>>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-
>>>> rc.git linux-5.10.y
>>>> and the diffstat can be found below.
>>>>
>>>> thanks,
>>>>
>>>> greg k-h
>>>
>>> On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
>>> BMIPS_GENERIC:
>>>
>>> Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
>>>
>>> Similar build warning as reported for 5.4, due to the same commit:
>>>
>>> commit b47e6abc7dc5772ecb45383d9956f9fcb7fdf33c
>>> Author: Jeongjun Park <aha310510@gmail.com>
>>> Date: Tue Apr 22 20:30:25 2025 +0900
>>>
>>> tracing: Fix oob write in trace_seq_to_buffer()
>>>
>>> commit f5178c41bb43444a6008150fe6094497135d07cb upstream.
>>>
>>> In file included from ./include/linux/kernel.h:15,
>>> from ./include/asm-generic/bug.h:20,
>>> from ./arch/arm/include/asm/bug.h:60,
>>> from ./include/linux/bug.h:5,
>>> from ./include/linux/mmdebug.h:5,
>>> from ./include/linux/mm.h:9,
>>> from ./include/linux/ring_buffer.h:5,
>>> from kernel/trace/trace.c:15:
>>> kernel/trace/trace.c: In function 'tracing_splice_read_pipe':
>>> ./include/linux/minmax.h:20:35: warning: comparison of distinct pointer
>>> types lacks a cast
>>> 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
>>> | ^~
>>> ./include/linux/minmax.h:26:18: note: in expansion of macro '__typecheck'
>>> 26 | (__typecheck(x, y) && __no_side_effects(x, y))
>>> | ^~~~~~~~~~~
>>> ./include/linux/minmax.h:36:31: note: in expansion of macro '__safe_cmp'
>>> 36 | __builtin_choose_expr(__safe_cmp(x, y), \
>>> | ^~~~~~~~~~
>>> ./include/linux/minmax.h:45:25: note: in expansion of macro '__careful_cmp'
>>> 45 | #define min(x, y) __careful_cmp(x, y, <)
>>> | ^~~~~~~~~~~~~
>>> kernel/trace/trace.c:6688:43: note: in expansion of macro 'min'
>>> 6688 | min((size_t)trace_seq_used(&iter->seq),
>>> | ^~~
>>>
>>
>> And also this one:
>>
>> commit e0a3a33cecd3ce2fde1de4ff0e223dc1db484a8d
>> Author: Eric Dumazet <edumazet@google.com>
>> Date: Wed Mar 5 13:05:50 2025 +0000
>>
>> tcp: bring back NUMA dispersion in inet_ehash_locks_alloc()
>>
>> [ Upstream commit f8ece40786c9342249aa0a1b55e148ee23b2a746 ]
>>
>>
>> on ARM64:
>>
>> In file included from ./include/linux/kernel.h:15,
>> from ./include/linux/list.h:9,
>> from ./include/linux/module.h:12,
>> from net/ipv4/inet_hashtables.c:12:
>> net/ipv4/inet_hashtables.c: In function 'inet_ehash_locks_alloc':
>> ./include/linux/minmax.h:20:35: warning: comparison of distinct pointer
>> types lacks a cast
>> 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
>> | ^~
>> ./include/linux/minmax.h:26:18: note: in expansion of macro '__typecheck'
>> 26 | (__typecheck(x, y) && __no_side_effects(x, y))
>> | ^~~~~~~~~~~
>> ./include/linux/minmax.h:36:31: note: in expansion of macro '__safe_cmp'
>> 36 | __builtin_choose_expr(__safe_cmp(x, y), \
>> | ^~~~~~~~~~
>> ./include/linux/minmax.h:52:25: note: in expansion of macro '__careful_cmp'
>> 52 | #define max(x, y) __careful_cmp(x, y, >)
>> | ^~~~~~~~~~~~~
>> net/ipv4/inet_hashtables.c:946:19: note: in expansion of macro 'max'
>> 946 | nblocks = max(nblocks, num_online_nodes() * PAGE_SIZE /
>> locksz);
>> | ^~~
>>
>
> For both of these, I'll just let them be as they are ok, it's just the
> mess of our min/max macro unwinding causes these issues.
>
> Unless they really bother someone, and in that case, a patch to add the
> correct type to the backport to make the noise go away would be greatly
> appreciated.
Yeah that's a reasonable resolution, I will try to track down the
missing patches for minmax.h so we are warning free for the stable kernels.
Thanks
--
Florian
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 5.10 000/270] 5.10.238-rc1 review
2025-06-03 16:00 ` Florian Fainelli
@ 2025-06-04 8:06 ` Greg Kroah-Hartman
2025-06-04 18:29 ` Florian Fainelli
0 siblings, 1 reply; 16+ messages in thread
From: Greg Kroah-Hartman @ 2025-06-04 8:06 UTC (permalink / raw)
To: Florian Fainelli
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, sudipm.mukherjee, srw,
rwarsow, conor, hargar, broonie
On Tue, Jun 03, 2025 at 09:00:58AM -0700, Florian Fainelli wrote:
> On 6/3/25 00:58, Greg Kroah-Hartman wrote:
> > On Mon, Jun 02, 2025 at 09:50:24AM -0700, Florian Fainelli wrote:
> > > On 6/2/25 09:49, Florian Fainelli wrote:
> > > > On 6/2/25 06:44, Greg Kroah-Hartman wrote:
> > > > > This is the start of the stable review cycle for the 5.10.238 release.
> > > > > There are 270 patches in this series, all will be posted as a response
> > > > > to this one. If anyone has any issues with these being applied, please
> > > > > let me know.
> > > > >
> > > > > Responses should be made by Wed, 04 Jun 2025 13:42:20 +0000.
> > > > > Anything received after that time might be too late.
> > > > >
> > > > > The whole patch series can be found in one patch at:
> > > > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/
> > > > > patch-5.10.238-rc1.gz
> > > > > or in the git tree and branch at:
> > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-
> > > > > rc.git linux-5.10.y
> > > > > and the diffstat can be found below.
> > > > >
> > > > > thanks,
> > > > >
> > > > > greg k-h
> > > >
> > > > On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
> > > > BMIPS_GENERIC:
> > > >
> > > > Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
> > > >
> > > > Similar build warning as reported for 5.4, due to the same commit:
> > > >
> > > > commit b47e6abc7dc5772ecb45383d9956f9fcb7fdf33c
> > > > Author: Jeongjun Park <aha310510@gmail.com>
> > > > Date: Tue Apr 22 20:30:25 2025 +0900
> > > >
> > > > tracing: Fix oob write in trace_seq_to_buffer()
> > > >
> > > > commit f5178c41bb43444a6008150fe6094497135d07cb upstream.
> > > >
> > > > In file included from ./include/linux/kernel.h:15,
> > > > from ./include/asm-generic/bug.h:20,
> > > > from ./arch/arm/include/asm/bug.h:60,
> > > > from ./include/linux/bug.h:5,
> > > > from ./include/linux/mmdebug.h:5,
> > > > from ./include/linux/mm.h:9,
> > > > from ./include/linux/ring_buffer.h:5,
> > > > from kernel/trace/trace.c:15:
> > > > kernel/trace/trace.c: In function 'tracing_splice_read_pipe':
> > > > ./include/linux/minmax.h:20:35: warning: comparison of distinct pointer
> > > > types lacks a cast
> > > > 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
> > > > | ^~
> > > > ./include/linux/minmax.h:26:18: note: in expansion of macro '__typecheck'
> > > > 26 | (__typecheck(x, y) && __no_side_effects(x, y))
> > > > | ^~~~~~~~~~~
> > > > ./include/linux/minmax.h:36:31: note: in expansion of macro '__safe_cmp'
> > > > 36 | __builtin_choose_expr(__safe_cmp(x, y), \
> > > > | ^~~~~~~~~~
> > > > ./include/linux/minmax.h:45:25: note: in expansion of macro '__careful_cmp'
> > > > 45 | #define min(x, y) __careful_cmp(x, y, <)
> > > > | ^~~~~~~~~~~~~
> > > > kernel/trace/trace.c:6688:43: note: in expansion of macro 'min'
> > > > 6688 | min((size_t)trace_seq_used(&iter->seq),
> > > > | ^~~
> > > >
> > >
> > > And also this one:
> > >
> > > commit e0a3a33cecd3ce2fde1de4ff0e223dc1db484a8d
> > > Author: Eric Dumazet <edumazet@google.com>
> > > Date: Wed Mar 5 13:05:50 2025 +0000
> > >
> > > tcp: bring back NUMA dispersion in inet_ehash_locks_alloc()
> > >
> > > [ Upstream commit f8ece40786c9342249aa0a1b55e148ee23b2a746 ]
> > >
> > >
> > > on ARM64:
> > >
> > > In file included from ./include/linux/kernel.h:15,
> > > from ./include/linux/list.h:9,
> > > from ./include/linux/module.h:12,
> > > from net/ipv4/inet_hashtables.c:12:
> > > net/ipv4/inet_hashtables.c: In function 'inet_ehash_locks_alloc':
> > > ./include/linux/minmax.h:20:35: warning: comparison of distinct pointer
> > > types lacks a cast
> > > 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
> > > | ^~
> > > ./include/linux/minmax.h:26:18: note: in expansion of macro '__typecheck'
> > > 26 | (__typecheck(x, y) && __no_side_effects(x, y))
> > > | ^~~~~~~~~~~
> > > ./include/linux/minmax.h:36:31: note: in expansion of macro '__safe_cmp'
> > > 36 | __builtin_choose_expr(__safe_cmp(x, y), \
> > > | ^~~~~~~~~~
> > > ./include/linux/minmax.h:52:25: note: in expansion of macro '__careful_cmp'
> > > 52 | #define max(x, y) __careful_cmp(x, y, >)
> > > | ^~~~~~~~~~~~~
> > > net/ipv4/inet_hashtables.c:946:19: note: in expansion of macro 'max'
> > > 946 | nblocks = max(nblocks, num_online_nodes() * PAGE_SIZE /
> > > locksz);
> > > | ^~~
> > >
> >
> > For both of these, I'll just let them be as they are ok, it's just the
> > mess of our min/max macro unwinding causes these issues.
> >
> > Unless they really bother someone, and in that case, a patch to add the
> > correct type to the backport to make the noise go away would be greatly
> > appreciated.
>
> Yeah that's a reasonable resolution, I will try to track down the missing
> patches for minmax.h so we are warning free for the stable kernels.
I tried in the past, it's non-trivial. What would be easier is to just
properly cast the variables in the places where this warning is showing
up to get rid of that warning. We've done that in some backports in the
past as well.
good luck!
greg k-h
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 5.10 000/270] 5.10.238-rc1 review
2025-06-04 8:06 ` Greg Kroah-Hartman
@ 2025-06-04 18:29 ` Florian Fainelli
0 siblings, 0 replies; 16+ messages in thread
From: Florian Fainelli @ 2025-06-04 18:29 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, sudipm.mukherjee, srw,
rwarsow, conor, hargar, broonie
On 6/4/25 01:06, Greg Kroah-Hartman wrote:
> On Tue, Jun 03, 2025 at 09:00:58AM -0700, Florian Fainelli wrote:
>> On 6/3/25 00:58, Greg Kroah-Hartman wrote:
>>> On Mon, Jun 02, 2025 at 09:50:24AM -0700, Florian Fainelli wrote:
>>>> On 6/2/25 09:49, Florian Fainelli wrote:
>>>>> On 6/2/25 06:44, Greg Kroah-Hartman wrote:
>>>>>> This is the start of the stable review cycle for the 5.10.238 release.
>>>>>> There are 270 patches in this series, all will be posted as a response
>>>>>> to this one. If anyone has any issues with these being applied, please
>>>>>> let me know.
>>>>>>
>>>>>> Responses should be made by Wed, 04 Jun 2025 13:42:20 +0000.
>>>>>> Anything received after that time might be too late.
>>>>>>
>>>>>> The whole patch series can be found in one patch at:
>>>>>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/
>>>>>> patch-5.10.238-rc1.gz
>>>>>> or in the git tree and branch at:
>>>>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-
>>>>>> rc.git linux-5.10.y
>>>>>> and the diffstat can be found below.
>>>>>>
>>>>>> thanks,
>>>>>>
>>>>>> greg k-h
>>>>>
>>>>> On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
>>>>> BMIPS_GENERIC:
>>>>>
>>>>> Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
>>>>>
>>>>> Similar build warning as reported for 5.4, due to the same commit:
>>>>>
>>>>> commit b47e6abc7dc5772ecb45383d9956f9fcb7fdf33c
>>>>> Author: Jeongjun Park <aha310510@gmail.com>
>>>>> Date: Tue Apr 22 20:30:25 2025 +0900
>>>>>
>>>>> tracing: Fix oob write in trace_seq_to_buffer()
>>>>>
>>>>> commit f5178c41bb43444a6008150fe6094497135d07cb upstream.
>>>>>
>>>>> In file included from ./include/linux/kernel.h:15,
>>>>> from ./include/asm-generic/bug.h:20,
>>>>> from ./arch/arm/include/asm/bug.h:60,
>>>>> from ./include/linux/bug.h:5,
>>>>> from ./include/linux/mmdebug.h:5,
>>>>> from ./include/linux/mm.h:9,
>>>>> from ./include/linux/ring_buffer.h:5,
>>>>> from kernel/trace/trace.c:15:
>>>>> kernel/trace/trace.c: In function 'tracing_splice_read_pipe':
>>>>> ./include/linux/minmax.h:20:35: warning: comparison of distinct pointer
>>>>> types lacks a cast
>>>>> 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
>>>>> | ^~
>>>>> ./include/linux/minmax.h:26:18: note: in expansion of macro '__typecheck'
>>>>> 26 | (__typecheck(x, y) && __no_side_effects(x, y))
>>>>> | ^~~~~~~~~~~
>>>>> ./include/linux/minmax.h:36:31: note: in expansion of macro '__safe_cmp'
>>>>> 36 | __builtin_choose_expr(__safe_cmp(x, y), \
>>>>> | ^~~~~~~~~~
>>>>> ./include/linux/minmax.h:45:25: note: in expansion of macro '__careful_cmp'
>>>>> 45 | #define min(x, y) __careful_cmp(x, y, <)
>>>>> | ^~~~~~~~~~~~~
>>>>> kernel/trace/trace.c:6688:43: note: in expansion of macro 'min'
>>>>> 6688 | min((size_t)trace_seq_used(&iter->seq),
>>>>> | ^~~
>>>>>
>>>>
>>>> And also this one:
>>>>
>>>> commit e0a3a33cecd3ce2fde1de4ff0e223dc1db484a8d
>>>> Author: Eric Dumazet <edumazet@google.com>
>>>> Date: Wed Mar 5 13:05:50 2025 +0000
>>>>
>>>> tcp: bring back NUMA dispersion in inet_ehash_locks_alloc()
>>>>
>>>> [ Upstream commit f8ece40786c9342249aa0a1b55e148ee23b2a746 ]
>>>>
>>>>
>>>> on ARM64:
>>>>
>>>> In file included from ./include/linux/kernel.h:15,
>>>> from ./include/linux/list.h:9,
>>>> from ./include/linux/module.h:12,
>>>> from net/ipv4/inet_hashtables.c:12:
>>>> net/ipv4/inet_hashtables.c: In function 'inet_ehash_locks_alloc':
>>>> ./include/linux/minmax.h:20:35: warning: comparison of distinct pointer
>>>> types lacks a cast
>>>> 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
>>>> | ^~
>>>> ./include/linux/minmax.h:26:18: note: in expansion of macro '__typecheck'
>>>> 26 | (__typecheck(x, y) && __no_side_effects(x, y))
>>>> | ^~~~~~~~~~~
>>>> ./include/linux/minmax.h:36:31: note: in expansion of macro '__safe_cmp'
>>>> 36 | __builtin_choose_expr(__safe_cmp(x, y), \
>>>> | ^~~~~~~~~~
>>>> ./include/linux/minmax.h:52:25: note: in expansion of macro '__careful_cmp'
>>>> 52 | #define max(x, y) __careful_cmp(x, y, >)
>>>> | ^~~~~~~~~~~~~
>>>> net/ipv4/inet_hashtables.c:946:19: note: in expansion of macro 'max'
>>>> 946 | nblocks = max(nblocks, num_online_nodes() * PAGE_SIZE /
>>>> locksz);
>>>> | ^~~
>>>>
>>>
>>> For both of these, I'll just let them be as they are ok, it's just the
>>> mess of our min/max macro unwinding causes these issues.
>>>
>>> Unless they really bother someone, and in that case, a patch to add the
>>> correct type to the backport to make the noise go away would be greatly
>>> appreciated.
>>
>> Yeah that's a reasonable resolution, I will try to track down the missing
>> patches for minmax.h so we are warning free for the stable kernels.
>
> I tried in the past, it's non-trivial. What would be easier is to just
> properly cast the variables in the places where this warning is showing
> up to get rid of that warning. We've done that in some backports in the
> past as well.
>
> good luck!
I see now that in 5.4.295-rc1 you have backported:
commit 36d6c6cd65043d553126b934bf1fcb79dcb58499
Author: Pan Taixi <pantaixi@huaweicloud.com>
Date: Mon May 26 09:37:31 2025 +0800
tracing: Fix compilation warning on arm32
commit 2fbdb6d8e03b70668c0876e635506540ae92ab05 upstream.
which takes care of resolving the warning, thanks!
--
Florian
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 5.10 000/270] 5.10.238-rc1 review
2025-06-02 13:44 [PATCH 5.10 000/270] 5.10.238-rc1 review Greg Kroah-Hartman
2025-06-02 13:47 ` [PATCH 5.10 151/270] arm64/mm: Check PUD_TYPE_TABLE in pud_bad() Greg Kroah-Hartman
2025-06-02 16:49 ` [PATCH 5.10 000/270] 5.10.238-rc1 review Florian Fainelli
@ 2025-06-02 20:37 ` Pavel Machek
2025-06-03 5:48 ` Naresh Kamboju
` (2 subsequent siblings)
5 siblings, 0 replies; 16+ messages in thread
From: Pavel Machek @ 2025-06-02 20:37 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, jonathanh, f.fainelli, sudipm.mukherjee,
srw, rwarsow, conor, hargar, broonie
[-- Attachment #1: Type: text/plain, Size: 1746 bytes --]
Hi!
> This is the start of the stable review cycle for the 5.10.238 release.
> There are 270 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
We see build problem on risc-v:
drivers/clocksource/timer-riscv.c: In function 'riscv_timer_dying_cpu':
1932
drivers/clocksource/timer-riscv.c:82:2: error: implicit declaration of function 'riscv_clock_event_stop' [-Werror=implicit-function-declaration]
1933
82 | riscv_clock_event_stop();
1934
| ^~~~~~~~~~~~~~~~~~~~~~
1935
CC fs/namei.o
1936
CC net/sunrpc/rpcb_clnt.o
1937
cc1: some warnings being treated as errors
1938
make[2]: *** [scripts/Makefile.build:286: drivers/clocksource/timer-riscv.o] Error 1
1939
make[1]: *** [scripts/Makefile.build:503: drivers/clocksource] Error 2
1940
make[1]: *** Waiting for unfinished jobs....
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/1849177067
Huh. And on arm....?
drivers/clocksource/timer-riscv.c: In function 'riscv_timer_dying_cpu':
2053
drivers/clocksource/timer-riscv.c:82:2: error: implicit declaration of function 'riscv_clock_event_stop' [-Werror=implicit-function-declaration]
2054
82 | riscv_clock_event_stop();
2055
| ^~~~~~~~~~~~~~~~~~~~~~
2056
CC drivers/mmc/core/slot-gpio.o
2057
CC drivers/crypto/virtio/virtio_crypto_core.o
2058
CC drivers/firmware/efi/libstub/lib-cmdline.o
2059
cc1: some warnings being treated as errors
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 5.10 000/270] 5.10.238-rc1 review
2025-06-02 13:44 [PATCH 5.10 000/270] 5.10.238-rc1 review Greg Kroah-Hartman
` (2 preceding siblings ...)
2025-06-02 20:37 ` Pavel Machek
@ 2025-06-03 5:48 ` Naresh Kamboju
2025-06-03 7:57 ` Greg Kroah-Hartman
2025-06-03 9:45 ` Mark Brown
2025-06-04 9:40 ` Jon Hunter
5 siblings, 1 reply; 16+ messages in thread
From: Naresh Kamboju @ 2025-06-03 5:48 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie
On Mon, 2 Jun 2025 at 20:08, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 5.10.238 release.
> There are 270 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 04 Jun 2025 13:42:20 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.238-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
There are two issues,
1)
Regressions on riscv defconfig builds failing with gcc-12, gcc-8 and
clang-20 toolchains on 5.10.238-rc1.
Regression Analysis:
- New regression? Yes
- Reproducible? Yes
Build regression: riscv defconfig timer-riscv.c:82:2: error: implicit
declaration of function 'riscv_clock_event_stop'
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Build log:
---------
drivers/clocksource/timer-riscv.c:82:2: error: implicit declaration of
function 'riscv_clock_event_stop'
[-Werror,-Wimplicit-function-declaration]
82 | riscv_clock_event_stop();
| ^
1 error generated.
This patch caused the build error,
clocksource/drivers/timer-riscv: Stop stimecmp when cpu hotplug
[ Upstream commit 70c93b026ed07078e933583591aa9ca6701cd9da ]
## Steps to reproduce
- tuxmake --runtime podman --target-arch riscv --toolchain clang-20
--kconfig defconfig LLVM=1 LLVM_IAS=1
## Build riscv
* Build log: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.237-271-g8bfb88108193/testrun/28635871/suite/build/test/clang-20-defconfig/log
* Build details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.237-271-g8bfb88108193/testrun/28635871/suite/build/test/clang-20-defconfig/details/
* Build history:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.237-271-g8bfb88108193/testrun/28635871/suite/build/test/clang-20-defconfig/history/
* architecture: riscv
* toolchain: gcc-8, gcc-12, clang-20
* config : defconfig
* Build config:
https://storage.tuxsuite.com/public/linaro/lkft/builds/2xxPulf5bqlsj7nSlN9PnLY9NXG/config
* Build: https://storage.tuxsuite.com/public/linaro/lkft/builds/2xxPulf5bqlsj7nSlN9PnLY9NXG/
2) The following build warnings were noticed on arm with clang-20.
Build regression: arm at91_dt_defconfig warning comparison of distinct
pointer types ('typeof (nblocks) *' (aka 'unsigned int *') and 'typeof
(num_node_state(N_ONLINE) * ((1UL) << 12) / locksz) *' (aka 'unsigned
long *')) [-Wcompare-distinct-pointer-types]
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Build warnings on arm:
---------
net/ipv4/inet_hashtables.c:946:12: warning: comparison of distinct
pointer types ('typeof (nblocks) *' (aka 'unsigned int *') and 'typeof
(num_node_state(N_ONLINE) * ((1UL) << 12) / locksz) *' (aka 'unsigned
long *')) [-Wcompare-distinct-pointer-types]
946 | nblocks = max(nblocks, num_online_nodes() * PAGE_SIZE / locksz);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
This commit is causing build warnings,
tcp: bring back NUMA dispersion in inet_ehash_locks_alloc()
[ Upstream commit f8ece40786c9342249aa0a1b55e148ee23b2a746 ]
# Steps to reproduce
- tuxmake --runtime podman --target-arch arm --toolchain clang-20
--kconfig at91_dt_defconfig LLVM=1 LLVM_IAS=0
## Build arm
* architecture: arm
* toolchain: clang-20
* config: at91_dt_defconfig
* Build config:
https://storage.tuxsuite.com/public/linaro/lkft/builds/2xxPtpUSdrY70QnawZR0ftSwhPt/config
* Build: https://storage.tuxsuite.com/public/linaro/lkft/builds/2xxPtpUSdrY70QnawZR0ftSwhPt/
## Build
* kernel: 5.10.238-rc1
* git: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
* git commit: 8bfb881081935b7a621f358516e28f4470af3296
* git describe: v5.10.237-271-g8bfb88108193
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.237-271-g8bfb88108193
## Test Regressions (compared to v5.10.236-287-gce0fd5a9f1a4)
* riscv, build
- clang-20-defconfig
- gcc-12-defconfig
- gcc-8-defconfig
## Metric Regressions (compared to v5.10.236-287-gce0fd5a9f1a4)
## Test Fixes (compared to v5.10.236-287-gce0fd5a9f1a4)
## Metric Fixes (compared to v5.10.236-287-gce0fd5a9f1a4)
## Test result summary
total: 36900, pass: 27422, fail: 1956, skip: 7366, xfail: 156
## Build Summary
* arc: 5 total, 5 passed, 0 failed
* arm: 100 total, 100 passed, 0 failed
* arm64: 28 total, 28 passed, 0 failed
* i386: 20 total, 20 passed, 0 failed
* mips: 22 total, 22 passed, 0 failed
* parisc: 3 total, 0 passed, 3 failed
* powerpc: 21 total, 21 passed, 0 failed
* riscv: 9 total, 6 passed, 3 failed
* s390: 9 total, 9 passed, 0 failed
* sh: 10 total, 10 passed, 0 failed
* sparc: 6 total, 6 passed, 0 failed
* x86_64: 24 total, 24 passed, 0 failed
## Test suites summary
* boot
* kselftest-arm64
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-exec
* kselftest-fpu
* kselftest-futex
* kselftest-intel_pstate
* kselftest-kcmp
* kselftest-membarrier
* kselftest-mincore
* kselftest-mqueue
* kselftest-openat2
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-sigaltstack
* kselftest-size
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user_events
* kselftest-vDSO
* kselftest-x86
* kunit
* lava
* libgpiod
* libhugetlbfs
* log-parser-boot
* log-parser-build-clang
* log-parser-build-gcc
* log-parser-test
* ltp-capability
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-crypto
* ltp-cve
* ltp-fcntl-locktests
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-hugetlb
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-smoke
* ltp-syscalls
* ltp-tracing
* perf
* rcutorture
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 5.10 000/270] 5.10.238-rc1 review
2025-06-03 5:48 ` Naresh Kamboju
@ 2025-06-03 7:57 ` Greg Kroah-Hartman
0 siblings, 0 replies; 16+ messages in thread
From: Greg Kroah-Hartman @ 2025-06-03 7:57 UTC (permalink / raw)
To: Naresh Kamboju
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie
On Tue, Jun 03, 2025 at 11:18:34AM +0530, Naresh Kamboju wrote:
> On Mon, 2 Jun 2025 at 20:08, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 5.10.238 release.
> > There are 270 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 04 Jun 2025 13:42:20 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.238-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> There are two issues,
>
> 1)
> Regressions on riscv defconfig builds failing with gcc-12, gcc-8 and
> clang-20 toolchains on 5.10.238-rc1.
>
> Regression Analysis:
> - New regression? Yes
> - Reproducible? Yes
>
> Build regression: riscv defconfig timer-riscv.c:82:2: error: implicit
> declaration of function 'riscv_clock_event_stop'
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> Build log:
> ---------
> drivers/clocksource/timer-riscv.c:82:2: error: implicit declaration of
> function 'riscv_clock_event_stop'
> [-Werror,-Wimplicit-function-declaration]
> 82 | riscv_clock_event_stop();
> | ^
> 1 error generated.
>
> This patch caused the build error,
>
> clocksource/drivers/timer-riscv: Stop stimecmp when cpu hotplug
> [ Upstream commit 70c93b026ed07078e933583591aa9ca6701cd9da ]
Now dropped, thanks!
greg k-h
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 5.10 000/270] 5.10.238-rc1 review
2025-06-02 13:44 [PATCH 5.10 000/270] 5.10.238-rc1 review Greg Kroah-Hartman
` (3 preceding siblings ...)
2025-06-03 5:48 ` Naresh Kamboju
@ 2025-06-03 9:45 ` Mark Brown
2025-06-03 10:06 ` Greg Kroah-Hartman
2025-06-04 9:40 ` Jon Hunter
5 siblings, 1 reply; 16+ messages in thread
From: Mark Brown @ 2025-06-03 9:45 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
On Mon, Jun 02, 2025 at 03:44:45PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.238 release.
> There are 270 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
This fails to boot with a NFS root on Raspberry Pi 3b+, due to
558a48d4fabd70213117ec20f476adff48f72365 ("net: phy: microchip: force
IRQ polling mode for lan88xx") as was also a problem for other stables.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 5.10 000/270] 5.10.238-rc1 review
2025-06-03 9:45 ` Mark Brown
@ 2025-06-03 10:06 ` Greg Kroah-Hartman
2025-06-03 10:46 ` Mark Brown
0 siblings, 1 reply; 16+ messages in thread
From: Greg Kroah-Hartman @ 2025-06-03 10:06 UTC (permalink / raw)
To: Mark Brown
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar
On Tue, Jun 03, 2025 at 10:45:34AM +0100, Mark Brown wrote:
> On Mon, Jun 02, 2025 at 03:44:45PM +0200, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.10.238 release.
> > There are 270 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
>
> This fails to boot with a NFS root on Raspberry Pi 3b+, due to
> 558a48d4fabd70213117ec20f476adff48f72365 ("net: phy: microchip: force
> IRQ polling mode for lan88xx") as was also a problem for other stables.
Odd, I see it in the 5.15.y released tree, so did we get a fix for it
with a different commit or should it just be dropped entirely from the
5.10.y queue?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 5.10 000/270] 5.10.238-rc1 review
2025-06-03 10:06 ` Greg Kroah-Hartman
@ 2025-06-03 10:46 ` Mark Brown
2025-06-04 8:09 ` Greg Kroah-Hartman
0 siblings, 1 reply; 16+ messages in thread
From: Mark Brown @ 2025-06-03 10:46 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On Tue, Jun 03, 2025 at 12:06:34PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 03, 2025 at 10:45:34AM +0100, Mark Brown wrote:
> > This fails to boot with a NFS root on Raspberry Pi 3b+, due to
> > 558a48d4fabd70213117ec20f476adff48f72365 ("net: phy: microchip: force
> > IRQ polling mode for lan88xx") as was also a problem for other stables.
> Odd, I see it in the 5.15.y released tree, so did we get a fix for it
> with a different commit or should it just be dropped entirely from the
> 5.10.y queue?
There's a revert in the v5.15 tree as 2edc296e2107a003e383f87cdc7e29bddcb6b17e,
IIRC it went it while I was on holiday so I didn't test the release it
went into.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 5.10 000/270] 5.10.238-rc1 review
2025-06-03 10:46 ` Mark Brown
@ 2025-06-04 8:09 ` Greg Kroah-Hartman
0 siblings, 0 replies; 16+ messages in thread
From: Greg Kroah-Hartman @ 2025-06-04 8:09 UTC (permalink / raw)
To: Mark Brown
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar
On Tue, Jun 03, 2025 at 11:46:06AM +0100, Mark Brown wrote:
> On Tue, Jun 03, 2025 at 12:06:34PM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Jun 03, 2025 at 10:45:34AM +0100, Mark Brown wrote:
>
> > > This fails to boot with a NFS root on Raspberry Pi 3b+, due to
> > > 558a48d4fabd70213117ec20f476adff48f72365 ("net: phy: microchip: force
> > > IRQ polling mode for lan88xx") as was also a problem for other stables.
>
> > Odd, I see it in the 5.15.y released tree, so did we get a fix for it
> > with a different commit or should it just be dropped entirely from the
> > 5.10.y queue?
>
> There's a revert in the v5.15 tree as 2edc296e2107a003e383f87cdc7e29bddcb6b17e,
> IIRC it went it while I was on holiday so I didn't test the release it
> went into.
Ah, that makes sense. All now dropped, thanks for warning me.
greg k-h
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 5.10 000/270] 5.10.238-rc1 review
2025-06-02 13:44 [PATCH 5.10 000/270] 5.10.238-rc1 review Greg Kroah-Hartman
` (4 preceding siblings ...)
2025-06-03 9:45 ` Mark Brown
@ 2025-06-04 9:40 ` Jon Hunter
5 siblings, 0 replies; 16+ messages in thread
From: Jon Hunter @ 2025-06-04 9:40 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Greg Kroah-Hartman, patches, linux-kernel, torvalds, akpm, linux,
shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, hargar, broonie,
linux-tegra, stable
On Mon, 02 Jun 2025 15:44:45 +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.238 release.
> There are 270 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 04 Jun 2025 13:42:20 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.238-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
All tests passing for Tegra ...
Test results for stable-v5.10:
10 builds: 10 pass, 0 fail
26 boots: 26 pass, 0 fail
67 tests: 67 pass, 0 fail
Linux version: 5.10.238-rc1-g8bfb88108193
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
tegra20-ventana, tegra210-p2371-2180,
tegra210-p3450-0000, tegra30-cardhu-a04
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Jon
^ permalink raw reply [flat|nested] 16+ messages in thread