Re: [RFC 6/8] x86_64/bug: Implement __WARN_printf()

Peter Zijlstra
2025-06-02T18:09:26Z

On Mon, Jun 02, 2025 at 09:38:09AM -0700, Linus Torvalds wrote:
> On Mon, 2 Jun 2025 at 08:50, Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > Yes, it absolutely builds with clang. The inline asm isn't something we
> > don't already do elsewhere :-) *cough* extable *cough*
>
> Eww. I hadn't looked at that (or repressed it if I did). *Shudder*.
>
> But looking around, I don't think any of the normal code I ever look
> at actually *generate* that disgusting thing.
>
> I had to search for it, and looked at the absolute horror it generates
> in the futex code, and honestly, if I ever have to look at that
> garbage, I would throw up.
>
> And WARN_ONCE() is in stuff I *do* look at.
>
> So no. I'm NAK'ing it just because it makes the asm look entirely unreadable.
>
> And no, I'm not ok with only using 'objdump' and friends to look at
> assembly generation. I want to be able to do
>
> make xyz.s
>
> and look at code generation without throwing up.
>
> The fact that we have this disgusting thing elsewhere in places that
> I've not looked at does *not* excuse adding it to other places.

Right. So the problem is using asm macros in inline-asm. We've tried
adding those macros to a global asm, but IIRC that had trouble.

So yeah, now we do the macro definition and purge right around the
inline asm and then you get this horror show :-(

Anyway, I'll try and come up with something else.