From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18C2823BCE2 for ; Tue, 3 Jun 2025 21:16:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748985405; cv=none; b=nCbKzpjwcfY6HOs6w8vSrRFs/6lZqg6h7ADLWJEwvH1WlJJHYMaCZWg2adbq48dTf157ss197n7h6t8ZpqV0rhN49ScPyNMV7IaldkttCszI88Crgq59bzmBAAM8JEPrmLEtJiLxh7lbLBO1Zy727fsvaqV8CrREZODwVjR3xOg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748985405; c=relaxed/simple; bh=YiuIbH1YicSvYtWptE6HogEJ1VuNCKkLtGqFeSs9x1E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GUtOlJ3tgZAR6feor5EPSyBaKKVWxxdE+Pn/pVXVBLe8jt/YD3/mABnu+jYVDziG/7yhN+wq1utuBs516rz51QbWjyxuwCf6cwjthK94iSzqmTFwX1IiMilmR5Q5Ixbe6bWfBfbsNX41gzTIUIDGDsO/zXD5ZVLcM2FTiU/PMYE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=B5jxMj5Q; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="B5jxMj5Q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748985403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=odfwWYBsPrR2NiRATGhjsNB6SzvCCkIpMqMTiNvN67g=; b=B5jxMj5QTqr8qfXbDCJSwd0kZxmlDA2qGCpepKRD3pMIZ35AwkqcX1dun7xlZEy1/tDRsd Am/qi18Rni5Oek4S/nTrOqjjRdEfAB8Zmkl6F7clMfJA45BReDG38dnq8gFRazej8uV1KC hSlDacCyFbLQYpW6m4XOM8a4rU1Ns0E= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-4r0q3JOrN52zBVRj6egaAA-1; Tue, 03 Jun 2025 17:16:42 -0400 X-MC-Unique: 4r0q3JOrN52zBVRj6egaAA-1 X-Mimecast-MFC-AGG-ID: 4r0q3JOrN52zBVRj6egaAA_1748985401 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-450d021b9b1so25248855e9.0 for ; Tue, 03 Jun 2025 14:16:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748985401; x=1749590201; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=odfwWYBsPrR2NiRATGhjsNB6SzvCCkIpMqMTiNvN67g=; b=m+n+tqrMGB5cDs5qpcJaR5FYmPQ/WyehVjFsCqp7zFrAudBIuZhTBN/W58d6YOWPCz qLYqpCMoWzMz42gHNFS5jGdhYrvG4Kb3DV2lju6C6nrw767VP9frKPPHSgiUWczpRrEQ 32szh9x3I/CygJ+j3WpD3xY8T08nypHruuFGho1o2eBu+Ky2I59RkO79UUCh3vF6azQH L+Mb0zm0ybUkXJYqvySI76b8h1WOmOlRFzDLTWVYBcHizyL5m/4brYumb90wbEWlwh41 jiIAGGw8gJtVLje5UVv1YVCva6w9mJH/Cl+g5Qq1liStCuJY2lCKk1HIEYM08/Cgbs2w 15/w== X-Gm-Message-State: AOJu0YyKfo99z+0fQeKL7GIzIb6F1+NaMsnebOFrDbQXs20hSi9eSxFc /kqdHZ5nOc1CEdJubp+sJqQGxqvaLm9ps7vQu+VLnj0sW0T21MjyrtqTgjuWENfXNRDJ8Feumgb OHyaHp1m2oDiwmSpPFmrbLkFHeOwSsQnupfKhnKZFzAjuvr+stn8jbOrQlEnpPiV5DMI5KzDwXz T7Tu8ewygqvoaMuXhLgWe3GPWDIWarSDoqasrAYJrQcZmVbBXny1s= X-Gm-Gg: ASbGncvkoGyR/jvAKm4ivjcD227O773M7QD+ArJNnCFIcvvw+IBKj53rDfYEwq8MaAS C68ExiNawp2pJFRhOYJtsUevoRNcyMGATL3D1eQp9pLvrrsK2ADfjpG4GTiBsgoVKwAPQl2AmPs sNXeOwJ8Xys5KS0DeY+adZoPXVLrYc/maiLIs1iNkWoiXWn6n/2DGPMOxHUg70L4PBrOH6XmxFE qpxuP58nLpeV3cceRvtSllRrsb7hnKTU0mTk3uFCN1wfLk+X4FZezIm006k+h3IQpItlGt91fRa sr0coQc5/sgnnEJI9BwaaisTrXhPjN3uQSMS77BUAnkuSZ2gqH0UprZ6ZCgiNkPWTJadWO5rrQa 8TG3SpFo= X-Received: by 2002:a05:600c:8b53:b0:450:d386:1afb with SMTP id 5b1f17b1804b1-451f0a77343mr1734695e9.9.1748985400774; Tue, 03 Jun 2025 14:16:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGU0uCWB4mipEA75Rgm+06vlkE4Cg+21PNhH9TeTgvc29mcVV+kilTSDzcCPjrD9lEWlpu3Rw== X-Received: by 2002:a05:600c:8b53:b0:450:d386:1afb with SMTP id 5b1f17b1804b1-451f0a77343mr1734345e9.9.1748985400273; Tue, 03 Jun 2025 14:16:40 -0700 (PDT) Received: from localhost (p200300d82f0df000eec92b8d4913f32a.dip0.t-ipconnect.de. [2003:d8:2f0d:f000:eec9:2b8d:4913:f32a]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a4efe5b96fsm19175970f8f.8.2025.06.03.14.16.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 14:16:39 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, David Hildenbrand , Andrew Morton , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Dan Williams Subject: [PATCH v1 2/2] mm/huge_memory: don't mark refcounted pages special in vmf_insert_folio_pud() Date: Tue, 3 Jun 2025 23:16:34 +0200 Message-ID: <20250603211634.2925015-3-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250603211634.2925015-1-david@redhat.com> References: <20250603211634.2925015-1-david@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Marking PUDs that map a "normal" refcounted folios as special is against our rules documented for vm_normal_page(). Fortunately, there are not that many pud_special() check that can be mislead and are right now rather harmless: e.g., none so far bases decisions whether to grab a folio reference on that decision. Well, and GUP-fast will fallback to GUP-slow. All in all, so far no big implications as it seems. Getting this right will get more important as we introduce folio_normal_page_pud() and start using it in more place where we currently special-case based on other VMA flags. Fix it by just inlining the relevant code, making the whole pud_none() handling cleaner. Add folio_mk_pud() to mimic what we do with folio_mk_pmd(). While at it, make sure that the pud that is non-none is actually present before comparing PFNs. Fixes: dbe54153296d ("mm/huge_memory: add vmf_insert_folio_pud()") Signed-off-by: David Hildenbrand --- include/linux/mm.h | 15 +++++++++++++++ mm/huge_memory.c | 33 +++++++++++++++++++++++---------- 2 files changed, 38 insertions(+), 10 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 0ef2ba0c667af..047c8261d4002 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1816,6 +1816,21 @@ static inline pmd_t folio_mk_pmd(struct folio *folio, pgprot_t pgprot) { return pmd_mkhuge(pfn_pmd(folio_pfn(folio), pgprot)); } + +/** + * folio_mk_pud - Create a PUD for this folio + * @folio: The folio to create a PUD for + * @pgprot: The page protection bits to use + * + * Create a page table entry for the first page of this folio. + * This is suitable for passing to set_pud_at(). + * + * Return: A page table entry suitable for mapping this folio. + */ +static inline pud_t folio_mk_pud(struct folio *folio, pgprot_t pgprot) +{ + return pud_mkhuge(pfn_pud(folio_pfn(folio), pgprot)); +} #endif #endif /* CONFIG_MMU */ diff --git a/mm/huge_memory.c b/mm/huge_memory.c index f9e23dfea76f8..7b66a23089381 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1629,6 +1629,7 @@ vm_fault_t vmf_insert_folio_pud(struct vm_fault *vmf, struct folio *folio, pud_t *pud = vmf->pud; struct mm_struct *mm = vma->vm_mm; spinlock_t *ptl; + pud_t entry; if (addr < vma->vm_start || addr >= vma->vm_end) return VM_FAULT_SIGBUS; @@ -1637,20 +1638,32 @@ vm_fault_t vmf_insert_folio_pud(struct vm_fault *vmf, struct folio *folio, return VM_FAULT_SIGBUS; ptl = pud_lock(mm, pud); - - /* - * If there is already an entry present we assume the folio is - * already mapped, hence no need to take another reference. We - * still call insert_pfn_pud() though in case the mapping needs - * upgrading to writeable. - */ - if (pud_none(*vmf->pud)) { + if (pud_none(*pud)) { folio_get(folio); folio_add_file_rmap_pud(folio, &folio->page, vma); add_mm_counter(mm, mm_counter_file(folio), HPAGE_PUD_NR); + + entry = folio_mk_pud(folio, vma->vm_page_prot); + if (write) { + entry = pud_mkyoung(pud_mkdirty(entry)); + entry = maybe_pud_mkwrite(entry, vma); + } + set_pud_at(mm, addr, pud, entry); + update_mmu_cache_pud(vma, addr, pud); + } else if (pud_present(*pud) && write) { + /* + * We only allow for upgrading write permissions if the + * same folio is already mapped. + */ + if (pud_pfn(*pud) == folio_pfn(folio)) { + entry = pud_mkyoung(*pud); + entry = maybe_pud_mkwrite(pud_mkdirty(entry), vma); + if (pudp_set_access_flags(vma, addr, pud, entry, 1)) + update_mmu_cache_pud(vma, addr, pud); + } else { + WARN_ON_ONCE(1); + } } - insert_pfn_pud(vma, addr, vmf->pud, pfn_to_pfn_t(folio_pfn(folio)), - write); spin_unlock(ptl); return VM_FAULT_NOPAGE; -- 2.49.0