From: Johan Hovold <johan+linaro@kernel.org>
To: Jeff Johnson <jjohnson@kernel.org>
Cc: Miaoqing Pan <quic_miaoqing@quicinc.com>,
Baochen Qiang <quic_bqiang@quicinc.com>,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH v2 2/5] wifi: ath11k: use plain access for descriptor length
Date: Wed, 4 Jun 2025 16:34:54 +0200 [thread overview]
Message-ID: <20250604143457.26032-3-johan+linaro@kernel.org> (raw)
In-Reply-To: <20250604143457.26032-1-johan+linaro@kernel.org>
The read memory barrier added by commit 6d037a372f81 ("wifi: ath11k: fix
ring-buffer corruption") is enough to guarantee ordering also for plain
descriptor accesses if the length helper is ever inlined so drop the
unnecessary READ_ONCE().
Tested-on: WCN6855 hw2.1 WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.41
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/net/wireless/ath/ath11k/hal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/hal.c b/drivers/net/wireless/ath/ath11k/hal.c
index 921114686ba3..b1f5a927dddd 100644
--- a/drivers/net/wireless/ath/ath11k/hal.c
+++ b/drivers/net/wireless/ath/ath11k/hal.c
@@ -599,7 +599,7 @@ u32 ath11k_hal_ce_dst_status_get_length(void *buf)
struct hal_ce_srng_dst_status_desc *desc = buf;
u32 len;
- len = FIELD_GET(HAL_CE_DST_STATUS_DESC_FLAGS_LEN, READ_ONCE(desc->flags));
+ len = FIELD_GET(HAL_CE_DST_STATUS_DESC_FLAGS_LEN, desc->flags);
desc->flags &= ~HAL_CE_DST_STATUS_DESC_FLAGS_LEN;
return len;
--
2.49.0
next prev parent reply other threads:[~2025-06-04 14:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 14:34 [PATCH v2 0/5] wifi: ath11k: fix dest ring-buffer corruption Johan Hovold
2025-06-04 14:34 ` [PATCH v2 1/5] " Johan Hovold
2025-06-05 9:12 ` Baochen Qiang
2025-06-25 9:59 ` Baochen Qiang
2025-06-04 14:34 ` Johan Hovold [this message]
2025-06-25 9:59 ` [PATCH v2 2/5] wifi: ath11k: use plain access for descriptor length Baochen Qiang
2025-06-04 14:34 ` [PATCH v2 3/5] wifi: ath11k: use plain accesses for monitor descriptor Johan Hovold
2025-06-25 9:59 ` Baochen Qiang
2025-06-04 14:34 ` [PATCH v2 4/5] wifi: ath11k: fix source ring-buffer corruption Johan Hovold
2025-06-25 10:00 ` Baochen Qiang
2025-06-04 14:34 ` [PATCH v2 5/5] wifi: ath11k: fix dest ring-buffer corruption when ring is full Johan Hovold
2025-06-25 10:00 ` Baochen Qiang
2025-06-26 23:15 ` [PATCH v2 0/5] wifi: ath11k: fix dest ring-buffer corruption Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250604143457.26032-3-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_bqiang@quicinc.com \
--cc=quic_miaoqing@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).