linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Jeff Johnson <jjohnson@kernel.org>
Cc: Miaoqing Pan <quic_miaoqing@quicinc.com>,
	Remi Pommarel <repk@triplefau.lt>,
	Baochen Qiang <quic_bqiang@quicinc.com>,
	linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH v2 0/4] wifi: ath12k: fix dest ring-buffer corruption
Date: Wed,  4 Jun 2025 16:45:05 +0200	[thread overview]
Message-ID: <20250604144509.28374-1-johan+linaro@kernel.org> (raw)

As a follow up to commit:

	b67d2cf14ea ("wifi: ath12k: fix ring-buffer corruption")

add the remaining missing memory barriers to make sure that destination
ring descriptors are read after the head pointers to avoid using stale
data on weakly ordered architectures like aarch64.

Also switch back to plain accesses for the descriptor fields which is
sufficient after the memory barrier.

New in v2 are two patches that add the missing barriers also for source
rings and when updating the tail pointer for destination rings.

To avoid leaking ring details from the "hal" (lmac or non-lmac), the
barriers are added to the ath12k_hal_srng_access_end() helper. For
symmetry I therefore moved also the dest ring barriers into
ath12k_hal_srng_access_begin() and made the barrier conditional.

[ Due to this change I did not add Miaoqing's reviewed-by tag. ]

Johan


Changes in v2:
 - add tested-on tags to plain access patch
 - move destination barriers into begin helper
 - fix source ring corruption (new patch)
 - fix dest ring corruption when ring is full (new patch)


Johan Hovold (4):
  wifi: ath12k: fix dest ring-buffer corruption
  wifi: ath12k: use plain access for descriptor length
  wifi: ath12k: fix source ring-buffer corruption
  wifi: ath12k: fix dest ring-buffer corruption when ring is full

 drivers/net/wireless/ath/ath12k/ce.c  |  3 --
 drivers/net/wireless/ath/ath12k/hal.c | 40 ++++++++++++++++++++++-----
 2 files changed, 33 insertions(+), 10 deletions(-)

-- 
2.49.0


             reply	other threads:[~2025-06-04 14:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-04 14:45 Johan Hovold [this message]
2025-06-04 14:45 ` [PATCH v2 1/4] wifi: ath12k: fix dest ring-buffer corruption Johan Hovold
2025-06-05  8:41   ` Baochen Qiang
2025-06-05 10:00     ` Johan Hovold
2025-06-05 10:49       ` Baochen Qiang
2025-06-16  9:29         ` Praneesh P
2025-06-16 10:59           ` Baochen Qiang
2025-06-17  8:46           ` Johan Hovold
2025-06-04 14:45 ` [PATCH v2 2/4] wifi: ath12k: use plain access for descriptor length Johan Hovold
2025-06-04 14:45 ` [PATCH v2 3/4] wifi: ath12k: fix source ring-buffer corruption Johan Hovold
2025-06-04 14:45 ` [PATCH v2 4/4] wifi: ath12k: fix dest ring-buffer corruption when ring is full Johan Hovold
2025-06-06  7:27   ` Miaoqing Pan
2025-06-06  9:19     ` Johan Hovold
2025-06-06  9:37       ` Johan Hovold
2025-06-05  8:37 ` [PATCH v2 0/4] wifi: ath12k: fix dest ring-buffer corruption Baochen Qiang
2025-06-05  8:44   ` Johan Hovold
2025-06-05  8:51     ` Baochen Qiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250604144509.28374-1-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=jjohnson@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_bqiang@quicinc.com \
    --cc=quic_miaoqing@quicinc.com \
    --cc=repk@triplefau.lt \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).