* [PATCH ath-next] wifi: ath12k: Fix hal_reo_cmd_status kernel-doc
@ 2025-06-05 17:27 Jeff Johnson
2025-06-07 14:44 ` Jeff Johnson
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Johnson @ 2025-06-05 17:27 UTC (permalink / raw)
To: Jeff Johnson; +Cc: linux-wireless, ath12k, linux-kernel, Jeff Johnson
Currently a warning is reported when running:
% scripts/kernel-doc -Wall -Werror -none drivers/net/wireless/ath/ath12k/hal.h
Warning: drivers/net/wireless/ath/ath12k/hal.h:596 Enum value 'HAL_REO_CMD_RESOURCE_BLOCKED' not described in enum 'hal_reo_cmd_status'
Add the missing description of HAL_REO_CMD_RESOURCE_BLOCKED.
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
---
Note that although HAL_REO_CMD_DRAIN also does not have a description,
kernel-doc isn't complaining. Furthermore, my analysis indicates that
HAL_REO_CMD_DRAIN may actually not be required, so after that analysis
completes I'll either remove HAL_REO_CMD_DRAIN or document it.
---
drivers/net/wireless/ath/ath12k/hal.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath12k/hal.h b/drivers/net/wireless/ath/ath12k/hal.h
index 0ee9c6b26dab..c1750b5dc03c 100644
--- a/drivers/net/wireless/ath/ath12k/hal.h
+++ b/drivers/net/wireless/ath/ath12k/hal.h
@@ -585,7 +585,8 @@ enum hal_reo_cmd_type {
* or cache was blocked
* @HAL_REO_CMD_FAILED: Command execution failed, could be due to
* invalid queue desc
- * @HAL_REO_CMD_RESOURCE_BLOCKED:
+ * @HAL_REO_CMD_RESOURCE_BLOCKED: Command could not be executed because
+ * one or more descriptors were blocked
* @HAL_REO_CMD_DRAIN:
*/
enum hal_reo_cmd_status {
---
base-commit: c3910de7bab78afbc106206aed5ec8e79458fbee
change-id: 20250604-hal_reo_cmd_status-kdoc-c3f3a25237c5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: Fix hal_reo_cmd_status kernel-doc
2025-06-05 17:27 [PATCH ath-next] wifi: ath12k: Fix hal_reo_cmd_status kernel-doc Jeff Johnson
@ 2025-06-07 14:44 ` Jeff Johnson
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Johnson @ 2025-06-07 14:44 UTC (permalink / raw)
To: Jeff Johnson, Jeff Johnson; +Cc: linux-wireless, ath12k, linux-kernel
On Thu, 05 Jun 2025 10:27:22 -0700, Jeff Johnson wrote:
> Currently a warning is reported when running:
>
> % scripts/kernel-doc -Wall -Werror -none drivers/net/wireless/ath/ath12k/hal.h
> Warning: drivers/net/wireless/ath/ath12k/hal.h:596 Enum value 'HAL_REO_CMD_RESOURCE_BLOCKED' not described in enum 'hal_reo_cmd_status'
>
> Add the missing description of HAL_REO_CMD_RESOURCE_BLOCKED.
>
> [...]
Applied, thanks!
[1/1] wifi: ath12k: Fix hal_reo_cmd_status kernel-doc
commit: b6bca6d7149e0bc1a56e831af0296d45688945ec
Best regards,
--
Jeff Johnson <jeff.johnson@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-07 14:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-05 17:27 [PATCH ath-next] wifi: ath12k: Fix hal_reo_cmd_status kernel-doc Jeff Johnson
2025-06-07 14:44 ` Jeff Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).