From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AA891AC44D; Thu, 5 Jun 2025 15:13:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749136383; cv=none; b=NRCO6QN0F+G8TdPq1Dyw/uegvrX8q/zjBiaf2XpRpcZw6F5qxVQHRDOIgj2b78fgN0KcQE9MCu2aybvzMvMOE7jyRr4w3Ih/aTtUZUP+b3WQ3y/sIlOIQ1ZFxOmMnEZzmhpgSfQwDDAgR8+9uDCIuHSdjXMFaUs5BdZma8i49Ag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749136383; c=relaxed/simple; bh=JdVHcHsY08lcMK6ICKfUDHxE6j64CtG+laE7A0bEhlw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=S5Fb5GhqaowKD2y8/UDE92gexcRkbEXXYng/GzRBWf9ztcRLoszXw+R4EncHrw/7s4AEbj3eHy5FHHc0YUtNT1EzzMYmPAIVxpAy4EwYaQqICF93OpUaiDV+FINxVCJ+Dq12W+5XhdFnTnpM6l0IkyeRyS3sWxUqCAx35W45/Us= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bR70Wmli; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bR70Wmli" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FF91C4CEEB; Thu, 5 Jun 2025 15:13:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749136383; bh=JdVHcHsY08lcMK6ICKfUDHxE6j64CtG+laE7A0bEhlw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bR70Wmlia/Sth/9zcx6hEj1Y+RJ/ElDQtpRyxK6wTumhgqMGYH9YlfinW6zP7kZ+2 dC29ZVQzapJlnSQ8dm74QeL1y9efmLsaIfLq6vUt7TBykNMZp+aT5ACTKURRdIDolg TJAsQF+rXDCz4TLUMe9cdnjuRr8E8FFzRbHZotXksTNnWwXxXssf+tTcu2Ov1hlcm5 cmu0OgREhuDPQcaXN0Op+dfZ9YLTr6wFXSLsbs/Zya75H5qxYBZADE2l/o62ZhpAmp +pIHNQtzztj9tGhCaz5HHBPmTNJ/bzQWeO4m8697pcAabK2dQKTV6bk/eJ4dyECvlw z8R4iJVVsyWdg== Date: Thu, 5 Jun 2025 08:13:01 -0700 From: Jakub Kicinski To: Harshitha Ramamurthy Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, jeroendb@google.com, andrew+netdev@lunn.ch, willemb@google.com, pkaligineedi@google.com, joshwash@google.com, thostet@google.com, jfraker@google.com, awogbemila@google.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net] gve: Fix stuck TX queue for DQ queue format Message-ID: <20250605081301.2659870c@kernel.org> In-Reply-To: <20250604201938.1409219-1-hramamurthy@google.com> References: <20250604201938.1409219-1-hramamurthy@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 4 Jun 2025 20:19:38 +0000 Harshitha Ramamurthy wrote: > + netdev_info(dev, "Kicking queue %d", txqueue); > + napi_schedule(&block->napi); > + tx->last_kick_msec = current_time; > + goto out; > > reset: > gve_schedule_reset(priv); gotos at the base level of the function are too ugly to exit. Please refactor this first to move the logic that decides whether reset should happen to a separate helper, then you can avoid both gotos/labels. goto reset should turn into return true goto out should turn into return false -- pw-bot: cr