From: Yury Norov <yury.norov@gmail.com>
To: "Paul E. McKenney" <paulmck@kernel.org>,
Neeraj Upadhyay <neeraj.upadhyay@kernel.org>,
"Yury Norov [NVIDIA]" <yury.norov@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Thorsten Blum <thorsten.blum@linux.dev>,
Zqiang <qiang.zhang1211@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] smp: Use cpumask_any_but() in smp_call_function_many_cond()
Date: Fri, 6 Jun 2025 16:27:29 -0400 [thread overview]
Message-ID: <20250606202732.426551-3-yury.norov@gmail.com> (raw)
In-Reply-To: <20250606202732.426551-1-yury.norov@gmail.com>
From: "Yury Norov [NVIDIA]" <yury.norov@gmail.com>
smp_call_function_many_cond() opencodes cpumask_any_but(). Fix it.
Signed-off-by: Yury Norov [NVIDIA] <yury.norov@gmail.com>
---
kernel/smp.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/kernel/smp.c b/kernel/smp.c
index 7c8cfab0ce55..5871acf3cd45 100644
--- a/kernel/smp.c
+++ b/kernel/smp.c
@@ -807,13 +807,8 @@ static void smp_call_function_many_cond(const struct cpumask *mask,
run_local = true;
/* Check if we need remote execution, i.e., any CPU excluding this one. */
- cpu = cpumask_first_and(mask, cpu_online_mask);
- if (cpu == this_cpu)
- cpu = cpumask_next_and(cpu, mask, cpu_online_mask);
- if (cpu < nr_cpu_ids)
+ if (cpumask_any_and_but(mask, cpu_online_mask, this_cpu) < nr_cpu_ids) {
run_remote = true;
-
- if (run_remote) {
cfd = this_cpu_ptr(&cfd_data);
cpumask_and(cfd->cpumask, mask, cpu_online_mask);
__cpumask_clear_cpu(this_cpu, cfd->cpumask);
--
2.43.0
next prev parent reply other threads:[~2025-06-06 20:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 20:27 [PATCH 0/4] smp: Improve on cpumasks handling Yury Norov
2025-06-06 20:27 ` [PATCH 1/4] smp: Improve locality in smp_call_function_any() Yury Norov
2025-06-06 20:27 ` Yury Norov [this message]
2025-06-06 20:27 ` [PATCH 3/4] smp: Don't wait until remote work done if not needed in smp_call_function_many_cond() Yury Norov
2025-06-06 20:27 ` [PATCH 4/4] smp: Defer check for local execution " Yury Norov
2025-06-10 18:59 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250606202732.426551-3-yury.norov@gmail.com \
--to=yury.norov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=neeraj.upadhyay@kernel.org \
--cc=paulmck@kernel.org \
--cc=qiang.zhang1211@gmail.com \
--cc=tglx@linutronix.de \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).