* [PATCH] dt-bindings: phy: Convert brcm,sr-usb-combo-phy to DT schema
@ 2025-06-07 21:25 Rob Herring (Arm)
2025-06-09 17:05 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring (Arm) @ 2025-06-07 21:25 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Krzysztof Kozlowski,
Conor Dooley, Ray Jui, Scott Branden,
Broadcom internal kernel review list, Srinath Mannam
Cc: linux-phy, devicetree, linux-kernel, linux-arm-kernel
Convert the Broadcom Stingray USB PHY binding to DT schema format. It's
a straight forward conversion.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../bindings/phy/brcm,sr-usb-combo-phy.yaml | 64 +++++++++++++++++++
.../bindings/phy/brcm,stingray-usb-phy.txt | 32 ----------
2 files changed, 64 insertions(+), 32 deletions(-)
create mode 100644 Documentation/devicetree/bindings/phy/brcm,sr-usb-combo-phy.yaml
delete mode 100644 Documentation/devicetree/bindings/phy/brcm,stingray-usb-phy.txt
diff --git a/Documentation/devicetree/bindings/phy/brcm,sr-usb-combo-phy.yaml b/Documentation/devicetree/bindings/phy/brcm,sr-usb-combo-phy.yaml
new file mode 100644
index 000000000000..b9aeaab02ef3
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/brcm,sr-usb-combo-phy.yaml
@@ -0,0 +1,64 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/brcm,sr-usb-combo-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom Stingray USB PHY
+
+maintainers:
+ - Srinath Mannam <srinath.mannam@broadcom.com>
+
+properties:
+ compatible:
+ enum:
+ - brcm,sr-usb-combo-phy
+ - brcm,sr-usb-hs-phy
+
+ reg:
+ maxItems: 1
+
+ '#phy-cells':
+ description: PHY cell count indicating PHY type
+ enum: [ 0, 1 ]
+
+required:
+ - compatible
+ - reg
+ - '#phy-cells'
+
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: brcm,sr-usb-combo-phy
+ then:
+ properties:
+ '#phy-cells':
+ const: 1
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: brcm,sr-usb-hs-phy
+ then:
+ properties:
+ '#phy-cells':
+ const: 0
+
+additionalProperties: false
+
+examples:
+ - |
+ usb-phy@0 {
+ compatible = "brcm,sr-usb-combo-phy";
+ reg = <0x00000000 0x100>;
+ #phy-cells = <1>;
+ };
+ - |
+ usb-phy@20000 {
+ compatible = "brcm,sr-usb-hs-phy";
+ reg = <0x00020000 0x100>;
+ #phy-cells = <0>;
+ };
diff --git a/Documentation/devicetree/bindings/phy/brcm,stingray-usb-phy.txt b/Documentation/devicetree/bindings/phy/brcm,stingray-usb-phy.txt
deleted file mode 100644
index 4ba298966af9..000000000000
--- a/Documentation/devicetree/bindings/phy/brcm,stingray-usb-phy.txt
+++ /dev/null
@@ -1,32 +0,0 @@
-Broadcom Stingray USB PHY
-
-Required properties:
- - compatible : should be one of the listed compatibles
- - "brcm,sr-usb-combo-phy" is combo PHY has two PHYs, one SS and one HS.
- - "brcm,sr-usb-hs-phy" is a single HS PHY.
- - reg: offset and length of the PHY blocks registers
- - #phy-cells:
- - Must be 1 for brcm,sr-usb-combo-phy as it expects one argument to indicate
- the PHY number of two PHYs. 0 for HS PHY and 1 for SS PHY.
- - Must be 0 for brcm,sr-usb-hs-phy.
-
-Refer to phy/phy-bindings.txt for the generic PHY binding properties
-
-Example:
- usbphy0: usb-phy@0 {
- compatible = "brcm,sr-usb-combo-phy";
- reg = <0x00000000 0x100>;
- #phy-cells = <1>;
- };
-
- usbphy1: usb-phy@10000 {
- compatible = "brcm,sr-usb-combo-phy";
- reg = <0x00010000 0x100>,
- #phy-cells = <1>;
- };
-
- usbphy2: usb-phy@20000 {
- compatible = "brcm,sr-usb-hs-phy";
- reg = <0x00020000 0x100>,
- #phy-cells = <0>;
- };
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: phy: Convert brcm,sr-usb-combo-phy to DT schema
2025-06-07 21:25 [PATCH] dt-bindings: phy: Convert brcm,sr-usb-combo-phy to DT schema Rob Herring (Arm)
@ 2025-06-09 17:05 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2025-06-09 17:05 UTC (permalink / raw)
To: Rob Herring (Arm), Vinod Koul, Kishon Vijay Abraham I,
Krzysztof Kozlowski, Conor Dooley, Ray Jui, Scott Branden,
Broadcom internal kernel review list, Srinath Mannam
Cc: linux-phy, devicetree, linux-kernel, linux-arm-kernel
On 6/7/25 14:25, 'Rob Herring (Arm)' via BCM-KERNEL-FEEDBACK-LIST,PDL wrote:
> Convert the Broadcom Stingray USB PHY binding to DT schema format. It's
> a straight forward conversion.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../bindings/phy/brcm,sr-usb-combo-phy.yaml | 64 +++++++++++++++++++
> .../bindings/phy/brcm,stingray-usb-phy.txt | 32 ----------
> 2 files changed, 64 insertions(+), 32 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/phy/brcm,sr-usb-combo-phy.yaml
> delete mode 100644 Documentation/devicetree/bindings/phy/brcm,stingray-usb-phy.txt
>
> diff --git a/Documentation/devicetree/bindings/phy/brcm,sr-usb-combo-phy.yaml b/Documentation/devicetree/bindings/phy/brcm,sr-usb-combo-phy.yaml
> new file mode 100644
> index 000000000000..b9aeaab02ef3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/brcm,sr-usb-combo-phy.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/brcm,sr-usb-combo-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom Stingray USB PHY
> +
> +maintainers:
> + - Srinath Mannam <srinath.mannam@broadcom.com>
Would suggest putting Scott and Ray as maintainers here, Srinath's email
is bouncing.
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-09 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-07 21:25 [PATCH] dt-bindings: phy: Convert brcm,sr-usb-combo-phy to DT schema Rob Herring (Arm)
2025-06-09 17:05 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).