linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: phy: Convert ti,da830-usb-phy to DT schema
@ 2025-06-07 21:26 Rob Herring (Arm)
  2025-06-09 14:46 ` David Lechner
  0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring (Arm) @ 2025-06-07 21:26 UTC (permalink / raw)
  To: Vinod Koul, Kishon Vijay Abraham I, Krzysztof Kozlowski,
	Conor Dooley, David Lechner
  Cc: linux-phy, devicetree, linux-kernel

Convert the TI DA830 USB PHY binding to DT schema format. Add "clocks"
and "clock-names" which are already in use.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../devicetree/bindings/phy/phy-da8xx-usb.txt | 40 ---------------
 .../bindings/phy/ti,da830-usb-phy.yaml        | 49 +++++++++++++++++++
 2 files changed, 49 insertions(+), 40 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt
 create mode 100644 Documentation/devicetree/bindings/phy/ti,da830-usb-phy.yaml

diff --git a/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt b/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt
deleted file mode 100644
index c26478be391b..000000000000
--- a/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt
+++ /dev/null
@@ -1,40 +0,0 @@
-TI DA8xx/OMAP-L1xx/AM18xx USB PHY
-
-Required properties:
- - compatible: must be "ti,da830-usb-phy".
- - #phy-cells: must be 1.
-
-This device controls the PHY for both the USB 1.1 OHCI and USB 2.0 OTG
-controllers on DA8xx SoCs. Consumers of this device should use index 0 for
-the USB 2.0 phy device and index 1 for the USB 1.1 phy device.
-
-It also requires a "syscon" node with compatible = "ti,da830-cfgchip", "syscon"
-to access the CFGCHIP2 register.
-
-Example:
-
-	cfgchip: cfgchip@1417c {
-		compatible = "ti,da830-cfgchip", "syscon";
-		reg = <0x1417c 0x14>;
-	};
-
-	usb_phy: usb-phy {
-		compatible = "ti,da830-usb-phy";
-		#phy-cells = <1>;
-	};
-
-	usb20: usb@200000 {
-		compatible = "ti,da830-musb";
-		reg = <0x200000 0x1000>;
-		interrupts = <58>;
-		phys = <&usb_phy 0>;
-		phy-names = "usb-phy";
-	};
-
-	usb11: usb@225000 {
-		compatible = "ti,da830-ohci";
-		reg = <0x225000 0x1000>;
-		interrupts = <59>;
-		phys = <&usb_phy 1>;
-		phy-names = "usb-phy";
-	};
diff --git a/Documentation/devicetree/bindings/phy/ti,da830-usb-phy.yaml b/Documentation/devicetree/bindings/phy/ti,da830-usb-phy.yaml
new file mode 100644
index 000000000000..e18746f80982
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/ti,da830-usb-phy.yaml
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/ti,da830-usb-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI DA8xx/OMAP-L1xx/AM18xx USB PHY
+
+maintainers:
+  - David Lechner <david@lechnology.com>
+
+description: >
+  This device controls the PHY for both the USB 1.1 OHCI and USB 2.0 OTG
+  controllers on DA8xx SoCs. Consumers of this device should use index 0 for
+  the USB 2.0 phy device and index 1 for the USB 1.1 phy device.
+
+  It also requires a "syscon" node with compatible = "ti,da830-cfgchip", "syscon"
+  to access the CFGCHIP2 register.
+
+properties:
+  compatible:
+    items:
+      - const: ti,da830-usb-phy
+
+  '#phy-cells':
+    const: 1
+
+  clocks:
+    maxItems: 2
+
+  clock-names:
+    items:
+      - const: usb0_clk48
+      - const: usb1_clk48
+
+required:
+  - compatible
+  - '#phy-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    usb-phy {
+        compatible = "ti,da830-usb-phy";
+        #phy-cells = <1>;
+        clocks = <&usb_phy_clk 0>, <&usb_phy_clk 1>;
+        clock-names = "usb0_clk48", "usb1_clk48";
+    };
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: phy: Convert ti,da830-usb-phy to DT schema
  2025-06-07 21:26 [PATCH] dt-bindings: phy: Convert ti,da830-usb-phy to DT schema Rob Herring (Arm)
@ 2025-06-09 14:46 ` David Lechner
  0 siblings, 0 replies; 2+ messages in thread
From: David Lechner @ 2025-06-09 14:46 UTC (permalink / raw)
  To: Rob Herring (Arm), Vinod Koul, Kishon Vijay Abraham I,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-phy, devicetree, linux-kernel

On 6/7/25 4:26 PM, Rob Herring (Arm) wrote:
> Convert the TI DA830 USB PHY binding to DT schema format. Add "clocks"
> and "clock-names" which are already in use.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---

...

> diff --git a/Documentation/devicetree/bindings/phy/ti,da830-usb-phy.yaml b/Documentation/devicetree/bindings/phy/ti,da830-usb-phy.yaml
> new file mode 100644
> index 000000000000..e18746f80982
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/ti,da830-usb-phy.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/ti,da830-usb-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI DA8xx/OMAP-L1xx/AM18xx USB PHY
> +
> +maintainers:
> +  - David Lechner <david@lechnology.com>
> +
> +description: >
> +  This device controls the PHY for both the USB 1.1 OHCI and USB 2.0 OTG
> +  controllers on DA8xx SoCs. Consumers of this device should use index 0 for
> +  the USB 2.0 phy device and index 1 for the USB 1.1 phy device.

Probably doesn't matter much, but we could move the description
of the #phy-cells to that property.

> +
> +  It also requires a "syscon" node with compatible = "ti,da830-cfgchip", "syscon"
> +  to access the CFGCHIP2 register.
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: ti,da830-usb-phy
> +
> +  '#phy-cells':
> +    const: 1
> +
> +  clocks:
> +    maxItems: 2
> +
> +  clock-names:
> +    items:
> +      - const: usb0_clk48
> +      - const: usb1_clk48
> +
> +required:
> +  - compatible
> +  - '#phy-cells'

Probably should make clocks and clock-names required.

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    usb-phy {
> +        compatible = "ti,da830-usb-phy";
> +        #phy-cells = <1>;
> +        clocks = <&usb_phy_clk 0>, <&usb_phy_clk 1>;
> +        clock-names = "usb0_clk48", "usb1_clk48";
> +    };


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-06-09 15:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-07 21:26 [PATCH] dt-bindings: phy: Convert ti,da830-usb-phy to DT schema Rob Herring (Arm)
2025-06-09 14:46 ` David Lechner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).