linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: loongson: Fix build warnings about export.h
@ 2025-06-08 14:27 Huacai Chen
  2025-06-09  0:38 ` Masahiro Yamada
  2025-06-09 13:40 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Huacai Chen @ 2025-06-08 14:27 UTC (permalink / raw)
  To: Masahiro Yamada, linux-kbuild, Takashi Iwai, Mark Brown,
	Liam Girdwood, Huacai Chen
  Cc: linux-sound, linux-kernel, Xuerui Wang, Jiaxun Yang, Huacai Chen

After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include
<linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check:
check unnecessary #include <linux/export.h> when W=1"), we get some build
warnings with W=1:

sound/soc/loongson/loongson_i2s.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing

So fix these build warnings for ASoC/Loongson.

Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
---
 sound/soc/loongson/loongson_i2s.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/loongson/loongson_i2s.c b/sound/soc/loongson/loongson_i2s.c
index e8852a30f213..e336656e13eb 100644
--- a/sound/soc/loongson/loongson_i2s.c
+++ b/sound/soc/loongson/loongson_i2s.c
@@ -9,6 +9,7 @@
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/delay.h>
+#include <linux/export.h>
 #include <linux/pm_runtime.h>
 #include <linux/dma-mapping.h>
 #include <sound/soc.h>
-- 
2.47.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: loongson: Fix build warnings about export.h
  2025-06-08 14:27 [PATCH] ASoC: loongson: Fix build warnings about export.h Huacai Chen
@ 2025-06-09  0:38 ` Masahiro Yamada
  2025-06-09 13:40 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2025-06-09  0:38 UTC (permalink / raw)
  To: Huacai Chen
  Cc: linux-kbuild, Takashi Iwai, Mark Brown, Liam Girdwood,
	Huacai Chen, linux-sound, linux-kernel, Xuerui Wang, Jiaxun Yang

On Sun, Jun 8, 2025 at 11:27 PM Huacai Chen <chenhuacai@loongson.cn> wrote:
>
> After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include
> <linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check:
> check unnecessary #include <linux/export.h> when W=1"), we get some build
> warnings with W=1:
>
> sound/soc/loongson/loongson_i2s.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
>
> So fix these build warnings for ASoC/Loongson.
>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---


Thank you for your contribution.

Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>

-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: loongson: Fix build warnings about export.h
  2025-06-08 14:27 [PATCH] ASoC: loongson: Fix build warnings about export.h Huacai Chen
  2025-06-09  0:38 ` Masahiro Yamada
@ 2025-06-09 13:40 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2025-06-09 13:40 UTC (permalink / raw)
  To: Masahiro Yamada, linux-kbuild, Takashi Iwai, Liam Girdwood,
	Huacai Chen, Huacai Chen
  Cc: linux-sound, linux-kernel, Xuerui Wang, Jiaxun Yang

On Sun, 08 Jun 2025 22:27:37 +0800, Huacai Chen wrote:
> After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include
> <linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check:
> check unnecessary #include <linux/export.h> when W=1"), we get some build
> warnings with W=1:
> 
> sound/soc/loongson/loongson_i2s.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: loongson: Fix build warnings about export.h
      commit: a4e469c1e2e0ec7f08fff9ed29f5500f187ba9f2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-06-09 13:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-08 14:27 [PATCH] ASoC: loongson: Fix build warnings about export.h Huacai Chen
2025-06-09  0:38 ` Masahiro Yamada
2025-06-09 13:40 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).