From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74F6321ABB2 for ; Wed, 11 Jun 2025 20:18:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749673129; cv=none; b=UDL8Hv6bbb+VvazSmIkubp7GnV0juphZmD+5wYZ3tDuoxPo/gWFcWBAz5Asj/fso3f5lIordLl0ZhwoEK+1J86rfN31ZslNG3AvFgw9gxZ7imkZrFQaHsdRo9Y5EH5U1GTTEG4SZpAq8QaFrXamkT0wGgyX9oTcgRzYsLD1B5Js= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749673129; c=relaxed/simple; bh=SFpLyUrSkeov8lTDekLTl8UML1Z5oaveGJ3pRpViCz0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qip9nflVSowIm+RW7wlxHFVBLf8rQL/Hbpkdcfw2uuaKiKQVBp5RRJeM0iWH+qhR8v9Jm/QAbFCTHQeJZqSfljqy9sIYK4lVMx8DRX1eD5USYU/RD8FiQG1vnlfGRH71afF2Jk1Wu84k70WKT10UOaEk9w1frOjUyAsmi1b6/hw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=oFwMEtql; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="oFwMEtql" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-4067ac8f6cdso161478b6e.2 for ; Wed, 11 Jun 2025 13:18:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1749673125; x=1750277925; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dI+YClki4Q+OM8j5JXLpkAENpDyF7Cb60VCru1h+I9Y=; b=oFwMEtqlRpNqTTZ5sjbllSJABMS1/oibEGQnhutCATmy/qbRK59YDixZykQ6qvdWjH IXBF7ChHnfx7G/lIB7F0aD2jpPglQjywhLz11rkX9ndcoN+ErZhhJLOLtVm7obpEpftd 9I3Ud3l7gCqq39LL9kNbpSMfcRU+bXE2FyOn7uz0d75SRbp7yXtAGKrHsODqojlTF9Ib 0OEiim4MPGZIaMmV2CGdOCWfH7O45W/S/DCoCHjXLR0Xr+c/YaVG/vUati3omiVjOkSZ 0oPesABgRQlS5PTO9d9alpA8DSZTTz7pAafNUSXjT9DneDgcmiqh+4wFrW61gUM8ZLHj 2yiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749673125; x=1750277925; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dI+YClki4Q+OM8j5JXLpkAENpDyF7Cb60VCru1h+I9Y=; b=G1G6WY7Fzmd8Y/PECSlsddOjHLIQ94+3EQ/57Y3eB1sEvfBrTI5uEQdr1nfLhuf1hb Fh0Kh2OIhbE2uCFT9gF2ajnj8jyzse1EIaIZ9nKUfzgP3QhHoytejg7bm0cnbhCc6pCR R0Xdgv6WC8mXb181b/LNCE71ylE5SgxkOcpi0pgCSo9AqCtvs62OiTRTcMNd5TOTwZvf uqaMTmEERy7GSKJwb13yK2XcfZq5YMWlD79WtcGBi/wc/QyA4OoxK8ikb54gutHsobBV kyJRbUXlfro31ZAh2J74zpdlaWVKIJR/A+f2gMErBhp8ty0/LL03mKVC1RAs6483948o cPhg== X-Forwarded-Encrypted: i=1; AJvYcCUEYd6j4/GMaqc4Eud6l3468zBtUJ8X6suNmjE68ZSKzX43x+nuOE++kMIER7QFdQ8uF4d43B4Ni5sKjLM=@vger.kernel.org X-Gm-Message-State: AOJu0YywIRyuuR+jskaZc9boX2TJzqKMMnx/llcrSRaVe0iZGTaM72FV t5dYraOi4eLaJV+33YPNsujIfUguE2AFaALjA+o8p82UDPK2d5BNd3p6McDJVwgPFjo= X-Gm-Gg: ASbGnct6r3aAT5ewpPLEn7KHpgXevU8kP7acMq88iGOC20ROkv+LJVXOMnIj9vktDWK 7KXOYGhFs0jqk7MViHPZIWtAqIvmT4AxZEVc3DoTY+OxSW4T+Fcf2Y+PmbaIKS3nkWSXY6eqI5c EKthDqvqgKvUGqeRB4eQrNFNeipgAduI9/IyY1SCi+nnXOPc2NoctUJ+xGqYq//DlsDNO14oq/k JbGL8LDykgXiKAv/QhsYCjSefVcYmTsRNFvoTZqomm71B0MGMfCDEdN58YM8l910vfHzZeGvidl 63apKb32AezaFWi4wY4DPmhlmwLcpY+ogk+aXzqDmjEABYBySBVopKRAc9JrUUXHxPfa X-Google-Smtp-Source: AGHT+IG+yB4PjXqGam/mFmbhtOtlvWHnGRv/5k7WflE47rsgegPrEoGN/DZYNDmhGQv2uSn8xCKNlA== X-Received: by 2002:a05:6808:2021:b0:403:2a0d:428b with SMTP id 5614622812f47-40a66af403emr374548b6e.39.1749673125624; Wed, 11 Jun 2025 13:18:45 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:4753:719f:673f:547c]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40a5d80d967sm467732b6e.4.2025.06.11.13.18.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 13:18:44 -0700 (PDT) From: David Lechner Date: Wed, 11 Jun 2025 15:18:09 -0500 Subject: [PATCH v4 1/3] bus: ts-nbus: validate ts,data-gpios array size Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250611-gpio-set-array-helper-v4-1-fb86a9b499ab@baylibre.com> References: <20250611-gpio-set-array-helper-v4-0-fb86a9b499ab@baylibre.com> In-Reply-To: <20250611-gpio-set-array-helper-v4-0-fb86a9b499ab@baylibre.com> To: Sebastien Bourdelin , Arnd Bergmann , linux-arm-kernel@lists.infradead.org Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1149; i=dlechner@baylibre.com; h=from:subject:message-id; bh=SFpLyUrSkeov8lTDekLTl8UML1Z5oaveGJ3pRpViCz0=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoSeSLaTcGiZbGvyVCGhUPWDMAFdGGlhKp9QYAq w/8u/EwnpqJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaEnkiwAKCRDCzCAB/wGP wFJ8CACa6UjbtPBARyaIgkjAgp72QK4ZU1HZKfzr8KtlLr5R/CB6QnsNyw4TZMvcAWz1R8miGwK rnOoKrQzw+aGBFMT3k/vjRj/Ehsvsfu4W7bFWztvUhRK/1qwRLzvCYaCuNLRC5RYiyIC6MJzcM5 1GKb1EeWt2KZ3wrqA+7OC6UAhPVG7td3ZBG9Md3rkDtHX/buSAFTEANFbH6uZ9+x3Q/6aiS1Wh+ IVJDljCJ+oaaoVCOqFqVCre6Zn23FWfV5glFDG1hsak0No0f8a5Boidw1BqPCpQnkk/vGRFklwS Gr37dNhGA4ZAKQJhX5AnkMka5GObju10gyRpBCOMz+gcGOl/ X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Add validation of ts,data-gpios array size during probe. The driver later hard-codes 8 as the size of the array when using it, so we should be validating that the array is actually that big to prevent possible out of bounds accesses. Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index 2328c48b9b1260e805c631f2aa7379d620084537..d3ee102a13893c83c50e41f7298821f4d7ae3487 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -48,6 +48,10 @@ static int ts_nbus_init_pdata(struct platform_device *pdev, return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->data), "failed to retrieve ts,data-gpio from dts\n"); + if (ts_nbus->data->ndescs != 8) + return dev_err_probe(&pdev->dev, -EINVAL, + "invalid number of ts,data-gpios\n"); + ts_nbus->csn = devm_gpiod_get(&pdev->dev, "ts,csn", GPIOD_OUT_HIGH); if (IS_ERR(ts_nbus->csn)) return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->csn), -- 2.43.0