From: David Lechner <dlechner@baylibre.com>
To: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 5/5] iio: amplifiers: ada4250: use dev_err_probe()
Date: Wed, 11 Jun 2025 16:33:05 -0500 [thread overview]
Message-ID: <20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-5-bf85ddea79f2@baylibre.com> (raw)
In-Reply-To: <20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-0-bf85ddea79f2@baylibre.com>
Use dev_err_probe() when returning an error in the probe function.
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
drivers/iio/amplifiers/ada4250.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/amplifiers/ada4250.c b/drivers/iio/amplifiers/ada4250.c
index d20ca410c506226fce7f172632d46b2ebb140a12..40f396ea906950ab79bf72cdb162794e95f76094 100644
--- a/drivers/iio/amplifiers/ada4250.c
+++ b/drivers/iio/amplifiers/ada4250.c
@@ -351,10 +351,8 @@ static int ada4250_probe(struct spi_device *spi)
mutex_init(&st->lock);
ret = ada4250_init(st);
- if (ret) {
- dev_err(&spi->dev, "ADA4250 init failed\n");
- return ret;
- }
+ if (ret)
+ return dev_err_probe(&spi->dev, ret, "ADA4250 init failed\n");
return devm_iio_device_register(&spi->dev, indio_dev);
}
--
2.43.0
next prev parent reply other threads:[~2025-06-11 21:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 21:33 [PATCH v3 0/5] iio: amplifiers: ada4250: various cleanups David Lechner
2025-06-11 21:33 ` [PATCH v3 1/5] iio: amplifiers: ada4250: used dev local variable David Lechner
2025-06-11 21:33 ` [PATCH v3 2/5] iio: amplifiers: ada4250: don't fail on bad chip ID David Lechner
2025-06-11 21:33 ` [PATCH v3 3/5] iio: amplifiers: ada4250: use devm_regulator_get_enable_read_voltage() David Lechner
2025-06-12 13:03 ` Andy Shevchenko
2025-06-12 15:31 ` David Lechner
2025-06-11 21:33 ` [PATCH v3 4/5] iio: amplifiers: ada4250: move offset_uv in struct David Lechner
2025-06-12 13:04 ` Andy Shevchenko
2025-06-12 15:31 ` David Lechner
2025-06-12 18:34 ` Andy Shevchenko
2025-06-12 18:45 ` David Lechner
2025-06-12 18:58 ` Andy Shevchenko
2025-06-11 21:33 ` David Lechner [this message]
2025-06-12 13:05 ` [PATCH v3 5/5] iio: amplifiers: ada4250: use dev_err_probe() Andy Shevchenko
2025-06-12 15:33 ` David Lechner
2025-06-12 13:07 ` [PATCH v3 0/5] iio: amplifiers: ada4250: various cleanups Andy Shevchenko
2025-06-14 12:07 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-5-bf85ddea79f2@baylibre.com \
--to=dlechner@baylibre.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).