Re: [PATCH 2/8] dma: mmp_pdma: Add optional clock support

Guodong Xu
2025-06-19T02:29:27Z

On Tue, Jun 17, 2025 at 2:00 PM Vinod Koul <vkoul@kernel.org> wrote:
>
> On 11-06-25, 20:57, Guodong Xu wrote:
> > Add support for retrieving and enabling an optional clock using
> > devm_clk_get_optional_enabled() during mmp_pdma_probe().
>
> Its dmaengine, please tag them as such

Got it. I will do.

Thank you, Vinod.

>
> >
> > Signed-off-by: Guodong Xu <guodong@riscstar.com>
> > ---
> > drivers/dma/mmp_pdma.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c
> > index a95d31103d30..4a6dbf558237 100644
> > --- a/drivers/dma/mmp_pdma.c
> > +++ b/drivers/dma/mmp_pdma.c
> > @@ -15,6 +15,7 @@
> > #include <linux/device.h>
> > #include <linux/platform_data/mmp_dma.h>
> > #include <linux/dmapool.h>
> > +#include <linux/clk.h>
> > #include <linux/of_dma.h>
> > #include <linux/of.h>
> >
> > @@ -1019,6 +1020,7 @@ static int mmp_pdma_probe(struct platform_device *op)
> > {
> > struct mmp_pdma_device *pdev;
> > struct mmp_dma_platdata *pdata = dev_get_platdata(&op->dev);
> > + struct clk *clk;
> > int i, ret, irq = 0;
> > int dma_channels = 0, irq_num = 0;
> > const enum dma_slave_buswidth widths =
> > @@ -1037,6 +1039,10 @@ static int mmp_pdma_probe(struct platform_device *op)
> > if (IS_ERR(pdev->base))
> > return PTR_ERR(pdev->base);
> >
> > + clk = devm_clk_get_optional_enabled(pdev->dev, NULL);
> > + if (IS_ERR(clk))
> > + return PTR_ERR(clk);
> > +
> > if (pdev->dev->of_node) {
> > /* Parse new and deprecated dma-channels properties */
> > if (of_property_read_u32(pdev->dev->of_node, "dma-channels",
> > --
> > 2.43.0
>
> --
> ~Vinod