[PATCH RESEND] net: mdio: mux-gpio: use gpiod_multi_set_value_cansleep

[PATCH RESEND] net: mdio: mux-gpio: use gpiod_multi_set_value_cansleep

[David Lechner]

Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of
gpiod_set_array_value_cansleep().

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
This is a resend of a patch from the series "[PATCH v3 00/15] gpiolib:
add gpiod_multi_set_value_cansleep" [1].

This patch never got acked so didn't go picked up with the rest of that
series. The dependency has been in mainline since v6.15-rc1 so this
patch can now be applied independently.

[1]: https://lore.kernel.org/all/20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com/
---
 drivers/net/mdio/mdio-mux-gpio.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/mdio/mdio-mux-gpio.c b/drivers/net/mdio/mdio-mux-gpio.c
index ef77bd1abae984e5b1e51315de39cae33e0d063d..fefa40ea5227c5a35d89ec2c6f95c6668a2470f6 100644
--- a/drivers/net/mdio/mdio-mux-gpio.c
+++ b/drivers/net/mdio/mdio-mux-gpio.c
@@ -30,8 +30,7 @@ static int mdio_mux_gpio_switch_fn(int current_child, int desired_child,
 
 	values[0] = desired_child;
 
-	gpiod_set_array_value_cansleep(s->gpios->ndescs, s->gpios->desc,
-				       s->gpios->info, values);
+	gpiod_multi_set_value_cansleep(s->gpios, values);
 
 	return 0;
 }

---
base-commit: 19a60293b9925080d97f22f122aca3fc46dadaf9
change-id: 20250611-net-mdio-mux-gpio-use-gpiod_multi_set_value_cansleep-e0954589da78

Best regards,
-- 
David Lechner <dlechner@baylibre.com>

Re: [PATCH RESEND] net: mdio: mux-gpio: use gpiod_multi_set_value_cansleep

[Andrew Lunn]

On Wed, Jun 11, 2025 at 01:11:36PM -0500, David Lechner wrote:
> Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of
> gpiod_set_array_value_cansleep().
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> This is a resend of a patch from the series "[PATCH v3 00/15] gpiolib:
> add gpiod_multi_set_value_cansleep" [1].
> 
> This patch never got acked so didn't go picked up with the rest of that
> series. The dependency has been in mainline since v6.15-rc1 so this
> patch can now be applied independently.

It is not surprising it did not get picked up when it is mixed in with
a lot of other subsystems. Please always post a patchset per
subsystem.

This also appears to be version 4.

Since you did not annotate the Subject: line with the tree this is
for, i'm not sure the CI system will accept it an run the tests.

https://patchwork.kernel.org/project/netdevbpf/patch/20250611-net-mdio-mux-gpio-use-gpiod_multi_set_value_cansleep-v1-1-6eb5281f1b41@baylibre.com/

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

	Andrew

Re: [PATCH RESEND] net: mdio: mux-gpio: use gpiod_multi_set_value_cansleep

[David Lechner]

On 6/11/25 1:25 PM, Andrew Lunn wrote:
> On Wed, Jun 11, 2025 at 01:11:36PM -0500, David Lechner wrote:
>> Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of
>> gpiod_set_array_value_cansleep().
>>
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>> Signed-off-by: David Lechner <dlechner@baylibre.com>
>> ---
>> This is a resend of a patch from the series "[PATCH v3 00/15] gpiolib:
>> add gpiod_multi_set_value_cansleep" [1].
>>
>> This patch never got acked so didn't go picked up with the rest of that
>> series. The dependency has been in mainline since v6.15-rc1 so this
>> patch can now be applied independently.
> 
> It is not surprising it did not get picked up when it is mixed in with
> a lot of other subsystems. Please always post a patchset per
> subsystem.
> 
> This also appears to be version 4.
> 
> Since you did not annotate the Subject: line with the tree this is
> for, i'm not sure the CI system will accept it an run the tests.
> 
> https://patchwork.kernel.org/project/netdevbpf/patch/20250611-net-mdio-mux-gpio-use-gpiod_multi_set_value_cansleep-v1-1-6eb5281f1b41@baylibre.com/
> 
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
> 
> 	Andrew

OK, I will try again tomorrow with [PATCH net-next v5].

Re: [PATCH RESEND] net: mdio: mux-gpio: use gpiod_multi_set_value_cansleep

[Jakub Kicinski]

On Wed, 11 Jun 2025 13:40:25 -0500 David Lechner wrote:
> > It is not surprising it did not get picked up when it is mixed in with
> > a lot of other subsystems. Please always post a patchset per
> > subsystem.
> > 
> > This also appears to be version 4.
> > 
> > Since you did not annotate the Subject: line with the tree this is
> > for, i'm not sure the CI system will accept it an run the tests.
> > 
> > https://patchwork.kernel.org/project/netdevbpf/patch/20250611-net-mdio-mux-gpio-use-gpiod_multi_set_value_cansleep-v1-1-6eb5281f1b41@baylibre.com/
> > 
> > https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
>
> OK, I will try again tomorrow with [PATCH net-next v5].

No need, just keep it in mind for the future (CI managed to guess
correctly).

Re: [PATCH RESEND] net: mdio: mux-gpio: use gpiod_multi_set_value_cansleep

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 11 Jun 2025 13:11:36 -0500 you wrote:
> Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of
> gpiod_set_array_value_cansleep().
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> This is a resend of a patch from the series "[PATCH v3 00/15] gpiolib:
> add gpiod_multi_set_value_cansleep" [1].
> 
> [...]

Here is the summary with links:
  - [RESEND] net: mdio: mux-gpio: use gpiod_multi_set_value_cansleep
    https://git.kernel.org/netdev/net-next/c/ed2cfae6b845

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html