* [PATCH net-next] rtase: Refine the flexibility of Rx queue allocation
@ 2025-06-10 9:55 Justin Lai
2025-06-11 21:25 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Justin Lai @ 2025-06-10 9:55 UTC (permalink / raw)
To: kuba
Cc: davem, edumazet, pabeni, andrew+netdev, linux-kernel, netdev,
horms, pkshih, larry.chiu, Justin Lai
Refine the flexibility of Rx queue allocation by using alloc_etherdev_mqs.
Signed-off-by: Justin Lai <justinlai0215@realtek.com>
---
drivers/net/ethernet/realtek/rtase/rtase_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c b/drivers/net/ethernet/realtek/rtase/rtase_main.c
index 4d37217e9a14..c22dd573418a 100644
--- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
+++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
@@ -2080,8 +2080,8 @@ static int rtase_init_board(struct pci_dev *pdev, struct net_device **dev_out,
int ret = -ENOMEM;
/* dev zeroed in alloc_etherdev */
- dev = alloc_etherdev_mq(sizeof(struct rtase_private),
- RTASE_FUNC_TXQ_NUM);
+ dev = alloc_etherdev_mqs(sizeof(struct rtase_private),
+ RTASE_FUNC_TXQ_NUM, RTASE_FUNC_RXQ_NUM);
if (!dev)
goto err_out;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] rtase: Refine the flexibility of Rx queue allocation
2025-06-10 9:55 [PATCH net-next] rtase: Refine the flexibility of Rx queue allocation Justin Lai
@ 2025-06-11 21:25 ` Jakub Kicinski
2025-06-12 7:42 ` Justin Lai
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2025-06-11 21:25 UTC (permalink / raw)
To: Justin Lai
Cc: davem, edumazet, pabeni, andrew+netdev, linux-kernel, netdev,
horms, pkshih, larry.chiu
On Tue, 10 Jun 2025 17:55:18 +0800 Justin Lai wrote:
> Refine the flexibility of Rx queue allocation by using alloc_etherdev_mqs.
>
> Signed-off-by: Justin Lai <justinlai0215@realtek.com>
> ---
> drivers/net/ethernet/realtek/rtase/rtase_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> index 4d37217e9a14..c22dd573418a 100644
> --- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
> +++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> @@ -2080,8 +2080,8 @@ static int rtase_init_board(struct pci_dev *pdev, struct net_device **dev_out,
> int ret = -ENOMEM;
>
> /* dev zeroed in alloc_etherdev */
> - dev = alloc_etherdev_mq(sizeof(struct rtase_private),
> - RTASE_FUNC_TXQ_NUM);
> + dev = alloc_etherdev_mqs(sizeof(struct rtase_private),
> + RTASE_FUNC_TXQ_NUM, RTASE_FUNC_RXQ_NUM);
> if (!dev)
> goto err_out;
>
$ git grep RTASE_FUNC_.XQ_NUM
drivers/net/ethernet/realtek/rtase/rtase.h:#define RTASE_FUNC_TXQ_NUM 1
drivers/net/ethernet/realtek/rtase/rtase.h:#define RTASE_FUNC_RXQ_NUM 1
This patch is a nop?
--
pw-bot: reject
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH net-next] rtase: Refine the flexibility of Rx queue allocation
2025-06-11 21:25 ` Jakub Kicinski
@ 2025-06-12 7:42 ` Justin Lai
0 siblings, 0 replies; 3+ messages in thread
From: Justin Lai @ 2025-06-12 7:42 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, horms@kernel.org, Ping-Ke Shih,
Larry Chiu
> On Tue, 10 Jun 2025 17:55:18 +0800 Justin Lai wrote:
> > Refine the flexibility of Rx queue allocation by using alloc_etherdev_mqs.
> >
> > Signed-off-by: Justin Lai <justinlai0215@realtek.com>
> > ---
> > drivers/net/ethernet/realtek/rtase/rtase_main.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c
> b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> > index 4d37217e9a14..c22dd573418a 100644
> > --- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
> > +++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> > @@ -2080,8 +2080,8 @@ static int rtase_init_board(struct pci_dev *pdev,
> struct net_device **dev_out,
> > int ret = -ENOMEM;
> >
> > /* dev zeroed in alloc_etherdev */
> > - dev = alloc_etherdev_mq(sizeof(struct rtase_private),
> > - RTASE_FUNC_TXQ_NUM);
> > + dev = alloc_etherdev_mqs(sizeof(struct rtase_private),
> > + RTASE_FUNC_TXQ_NUM,
> RTASE_FUNC_RXQ_NUM);
> > if (!dev)
> > goto err_out;
> >
>
> $ git grep RTASE_FUNC_.XQ_NUM
> drivers/net/ethernet/realtek/rtase/rtase.h:#define RTASE_FUNC_TXQ_NUM
> 1
> drivers/net/ethernet/realtek/rtase/rtase.h:#define RTASE_FUNC_RXQ_NUM
> 1
>
> This patch is a nop?
> --
> pw-bot: reject
Hi Jakub,
Sorry about this, but this patch needs to be abandoned for now. It's
currently non-functional, and we'll resubmit it in the future together
with changes that support user-configurable queue numbers.
Thanks,
Justin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-12 7:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-10 9:55 [PATCH net-next] rtase: Refine the flexibility of Rx queue allocation Justin Lai
2025-06-11 21:25 ` Jakub Kicinski
2025-06-12 7:42 ` Justin Lai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).