Re: [PATCH 01/14] xfs: tracing; Remove unused event xfs_reflink_cow_found

[Steven Rostedt <rostedt@goodmis.org>]

On Thu, 12 Jun 2025 17:24:06 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> From: Steven Rostedt <rostedt@goodmis.org>
> 
> Each trace event can take up to around 5K of text and meta data regardless
> if they are used or not. With the restructuring of the XFS COW handling,
> the tracepoint trace_xfs_reflink_cow_found() was removed but the trace
> event was still being created. Remove the creation of that trace event.
> 
> Fixes: db46e604adf8 ("xfs: merge COW handling into xfs_file_iomap_begin_delay")
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> ---
>  fs/xfs/xfs_trace.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
> index 01d284a1c759..ae0ed0dd0a01 100644
> --- a/fs/xfs/xfs_trace.h
> +++ b/fs/xfs/xfs_trace.h
> @@ -4242,7 +4242,6 @@ DEFINE_INODE_ERROR_EVENT(xfs_reflink_unshare_error);
>  
>  /* copy on write */
>  DEFINE_INODE_IREC_EVENT(xfs_reflink_trim_around_shared);
> -DEFINE_INODE_IREC_EVENT(xfs_reflink_cow_found);
>  DEFINE_INODE_IREC_EVENT(xfs_reflink_cow_enospc);
>  DEFINE_INODE_IREC_EVENT(xfs_reflink_convert_cow);
>  

Hmm, it looks like this one is still used. I'll drop this patch.

-- Steve