Re: [PATCH 2/4] spi: spi-fsl-dspi: Use non-coherent memory for DMA

Arnd Bergmann
2025-06-10T08:26:50Z

On Mon, Jun 9, 2025, at 17:32, James Clark wrote:
> Using coherent memory here isn't functionally necessary. Because the
> change to use non-coherent memory isn't overly complex and only a few
> synchronization points are required, we might as well do it while fixing
> up some other DMA issues.
>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: James Clark <james.clark@linaro.org>

This version looks good to me,

Acked-by: Arnd Bergmann <arnd@arndb.de>

I had reviewed an internal version originally and had some comment
on that, all of which are addressed now. You did not Cc me on the
other patches, so I looked them up in the archive, Patch 3 also
looks good to me and complements this one (i.e. you really want
the combination). I did not understand the logic in patch 4,
and it would be good if someone else can take a closer look
at that in order to Ack that.

Arnd