From: Khalid Ali <khaliidcaliy@gmail.com>
To: tglx@linutronix.de, peterz@infradead.org, luto@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] include/linux: Fix outdated comment on entry-common.h
Date: Sat, 14 Jun 2025 12:04:21 +0000 [thread overview]
Message-ID: <20250614120439.3336-1-khaliidcaliy@gmail.com> (raw)
In-Reply-To: <87frg2q1w7.ffs@tglx>
> That's redundant as syscall_enter_audit() checks for a valid audit
> context already. Both are valid indicators and go in lockstep. So it
> might be arguable that evaluating the work bit is cheaper than the
> context check, but I doubt it's measurable.
This will also increase readability and make things more consistent. So i think
we should use SYSCALL_WORK_SYSCALL_AUDIT bit to check if we need to do auditing,
instead of checking audit context, on both entry and exit.
So should i do with another patch, what i am verifying is if we really agree with one point.
Thanks
Khalid Ali
next prev parent reply other threads:[~2025-06-14 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 20:28 [PATCH] kernel/entry: Remove some redundancy checks on syscall works Khalid Ali
2025-06-14 6:21 ` Thomas Gleixner
2025-06-14 12:04 ` Khalid Ali [this message]
2025-06-15 8:39 ` [PATCH] kernel/entry: Remove some redundancy checks on syscall Khalid Ali
-- strict thread matches above, loose matches on Subject: below --
2025-06-13 20:58 [PATCH] include/linux: Fix outdated comment on entry-common.h Khalid Ali
2025-06-14 6:34 ` Thomas Gleixner
2025-06-14 11:42 ` Khalid Ali
2025-06-08 19:48 Khalid Ali
2025-06-13 16:28 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250614120439.3336-1-khaliidcaliy@gmail.com \
--to=khaliidcaliy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).