From: Alex Williamson <alex.williamson@redhat.com>
To: Mario Limonciello <superm1@kernel.org>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Lukas Wunner" <lukas@wunner.de>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Woodhouse" <dwmw2@infradead.org>,
"Lu Baolu" <baolu.lu@linux.intel.com>,
"Joerg Roedel" <joro@8bytes.org>, "Will Deacon" <will@kernel.org>,
"Robin Murphy" <robin.murphy@arm.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
dri-devel@lists.freedesktop.org (open list:DRM DRIVERS),
linux-kernel@vger.kernel.org (open list),
iommu@lists.linux.dev (open list:INTEL IOMMU (VT-d)),
linux-pci@vger.kernel.org (open list:PCI SUBSYSTEM),
kvm@vger.kernel.org (open list:VFIO DRIVER),
linux-sound@vger.kernel.org (open list:SOUND),
"Daniel Dadap" <ddadap@nvidia.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Bjorn Helgaas" <helgaas@kernel.org>
Subject: Re: [PATCH v2 2/6] vfio/pci: Use pci_is_display()
Date: Tue, 17 Jun 2025 12:52:35 -0600 [thread overview]
Message-ID: <20250617125235.13017540.alex.williamson@redhat.com> (raw)
In-Reply-To: <20250617175910.1640546-3-superm1@kernel.org>
On Tue, 17 Jun 2025 12:59:06 -0500
Mario Limonciello <superm1@kernel.org> wrote:
> From: Mario Limonciello <mario.limonciello@amd.com>
>
> The inline pci_is_display() helper does the same thing. Use it.
>
> Suggested-by: Bjorn Helgaas <helgaas@kernel.org>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/vfio/pci/vfio_pci_igd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/vfio/pci/vfio_pci_igd.c b/drivers/vfio/pci/vfio_pci_igd.c
> index ef490a4545f48..988b6919c2c31 100644
> --- a/drivers/vfio/pci/vfio_pci_igd.c
> +++ b/drivers/vfio/pci/vfio_pci_igd.c
> @@ -437,8 +437,7 @@ static int vfio_pci_igd_cfg_init(struct vfio_pci_core_device *vdev)
>
> bool vfio_pci_is_intel_display(struct pci_dev *pdev)
> {
> - return (pdev->vendor == PCI_VENDOR_ID_INTEL) &&
> - ((pdev->class >> 16) == PCI_BASE_CLASS_DISPLAY);
> + return (pdev->vendor == PCI_VENDOR_ID_INTEL) && pci_is_display(pdev);
> }
>
> int vfio_pci_igd_init(struct vfio_pci_core_device *vdev)
Acked-by: Alex Williamson <alex.williamson@redhat.com>
next prev parent reply other threads:[~2025-06-17 18:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 17:59 [PATCH v2 0/6] PCI/VGA: Look at all PCI display devices in VGA arbiter Mario Limonciello
2025-06-17 17:59 ` [PATCH v2 1/6] PCI: Add helper for checking if a PCI device is a display controller Mario Limonciello
2025-06-17 17:59 ` [PATCH v2 2/6] vfio/pci: Use pci_is_display() Mario Limonciello
2025-06-17 18:52 ` Alex Williamson [this message]
2025-06-17 17:59 ` [PATCH v2 3/6] vga_switcheroo: " Mario Limonciello
2025-06-17 17:59 ` [PATCH v2 4/6] iommu/vt-d: " Mario Limonciello
2025-06-17 17:59 ` [PATCH v2 5/6] ALSA: hda: " Mario Limonciello
2025-06-18 14:14 ` Simona Vetter
2025-06-17 17:59 ` [PATCH v2 6/6] vgaarb: Look at all PCI display devices in VGA arbiter Mario Limonciello
2025-06-17 19:20 ` Daniel Dadap
2025-06-17 20:15 ` Mario Limonciello
2025-06-17 20:56 ` Daniel Dadap
2025-06-17 21:49 ` Alex Williamson
2025-06-17 23:01 ` Daniel Dadap
2025-06-17 19:22 ` Alex Williamson
2025-06-17 20:22 ` Mario Limonciello
2025-06-18 9:11 ` Thomas Zimmermann
2025-06-18 14:12 ` Simona Vetter
2025-06-18 18:45 ` Mario Limonciello
2025-06-18 21:04 ` Daniel Dadap
2025-06-19 6:50 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617125235.13017540.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=ddadap@nvidia.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dwmw2@infradead.org \
--cc=helgaas@kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mario.limonciello@amd.com \
--cc=mripard@kernel.org \
--cc=perex@perex.cz \
--cc=robin.murphy@arm.com \
--cc=simona@ffwll.ch \
--cc=superm1@kernel.org \
--cc=tiwai@suse.com \
--cc=tzimmermann@suse.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).