From: Simon Horman <horms@kernel.org>
To: Himanshu Mittal <h-mittal1@ti.com>
Cc: pabeni@redhat.com, kuba@kernel.org, edumazet@google.com,
davem@davemloft.net, andrew+netdev@lunn.ch,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, srk@ti.com,
Vignesh Raghavendra <vigneshr@ti.com>,
Roger Quadros <rogerq@kernel.org>,
danishanwar@ti.com, m-malladi@ti.com, pratheesh@ti.com,
prajith@ti.com
Subject: Re: [PATCH net-next v2] net: ti: icssg-prueth: Add prp offload support to ICSSG driver
Date: Wed, 18 Jun 2025 11:29:07 +0100 [thread overview]
Message-ID: <20250618102907.GA1699@horms.kernel.org> (raw)
In-Reply-To: <20250617101837.381217-1-h-mittal1@ti.com>
On Tue, Jun 17, 2025 at 03:48:37PM +0530, Himanshu Mittal wrote:
> Add support for ICSSG PRP mode which supports offloading of:
> - Packet duplication and PRP trailer insertion
> - Packet duplicate discard and PRP trailer removal
>
> Signed-off-by: Himanshu Mittal <h-mittal1@ti.com>
> ---
> v2-v1:
> - Align with recent firmware name handling updates made in:
> https://lore.kernel.org/all/20250613064547.44394-1-danishanwar@ti.com/
>
> v1: https://lore.kernel.org/all/42ac0736-cb5a-4d99-a11c-6f861adbdb5f@ti.com/
...
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.h b/drivers/net/ethernet/ti/icssg/icssg_prueth.h
...
> @@ -349,6 +352,7 @@ struct prueth {
> struct icssg_firmwares icssg_emac_firmwares[PRUETH_NUM_MACS];
> struct icssg_firmwares icssg_switch_firmwares[PRUETH_NUM_MACS];
> struct icssg_firmwares icssg_hsr_firmwares[PRUETH_NUM_MACS];
> + struct icssg_firmwares icssg_prp_firmwares[PRUETH_NUM_MACS];
> };
Hi Himanshu,
Please also add icssg_prp_firmwares to the Kernel doc for struct preth,
which appears a little above this hunk.
Flagged by ./scripts/kernel-doc -none
Otherwise, this patch looks good to me.
--
pw-bot: changes-requested
prev parent reply other threads:[~2025-06-18 10:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 10:18 [PATCH net-next v2] net: ti: icssg-prueth: Add prp offload support to ICSSG driver Himanshu Mittal
2025-06-18 10:29 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250618102907.GA1699@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=h-mittal1@ti.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-malladi@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=prajith@ti.com \
--cc=pratheesh@ti.com \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox