[PATCH net-next] net/smc: remove unused function smc_lo_supports_v2

[PATCH net-next] net/smc: remove unused function smc_lo_supports_v2

[Wang Liang]

The smcd_ops->supports_v2 is only called in smcd_register_dev(), which
calls function smcd_supports_v2 for ism. For loopback-ism, function
smc_lo_supports_v2 is unused, remove it.

Signed-off-by: Wang Liang <wangliang74@huawei.com>
---
 net/smc/smc_loopback.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/net/smc/smc_loopback.c b/net/smc/smc_loopback.c
index 3c5f64ca4115..0eb00bbefd17 100644
--- a/net/smc/smc_loopback.c
+++ b/net/smc/smc_loopback.c
@@ -251,11 +251,6 @@ static int smc_lo_move_data(struct smcd_dev *smcd, u64 dmb_tok,
 	return 0;
 }
 
-static int smc_lo_supports_v2(void)
-{
-	return SMC_LO_V2_CAPABLE;
-}
-
 static void smc_lo_get_local_gid(struct smcd_dev *smcd,
 				 struct smcd_gid *smcd_gid)
 {
@@ -288,7 +283,6 @@ static const struct smcd_ops lo_ops = {
 	.reset_vlan_required	= NULL,
 	.signal_event		= NULL,
 	.move_data = smc_lo_move_data,
-	.supports_v2 = smc_lo_supports_v2,
 	.get_local_gid = smc_lo_get_local_gid,
 	.get_chid = smc_lo_get_chid,
 	.get_dev = smc_lo_get_dev,
-- 
2.34.1

Re: [PATCH net-next] net/smc: remove unused function smc_lo_supports_v2

[Simon Horman]

On Thu, Jun 19, 2025 at 11:08:54AM +0800, Wang Liang wrote:
> The smcd_ops->supports_v2 is only called in smcd_register_dev(), which
> calls function smcd_supports_v2 for ism. For loopback-ism, function
> smc_lo_supports_v2 is unused, remove it.
> 
> Signed-off-by: Wang Liang <wangliang74@huawei.com>

Thanks, I agree with this analysis.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next] net/smc: remove unused function smc_lo_supports_v2

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 19 Jun 2025 11:08:54 +0800 you wrote:
> The smcd_ops->supports_v2 is only called in smcd_register_dev(), which
> calls function smcd_supports_v2 for ism. For loopback-ism, function
> smc_lo_supports_v2 is unused, remove it.
> 
> Signed-off-by: Wang Liang <wangliang74@huawei.com>
> ---
>  net/smc/smc_loopback.c | 6 ------
>  1 file changed, 6 deletions(-)

Here is the summary with links:
  - [net-next] net/smc: remove unused function smc_lo_supports_v2
    https://git.kernel.org/netdev/net-next/c/091d019adce0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html