* [PATCH 0/2] arm: dts: OMAP: Clean up devicetree bindings and compatible strings
@ 2025-06-20 8:24 Kory Maincent
2025-06-20 8:24 ` [PATCH 1/2] dt-bindings: omap: Add missing AM33xx " Kory Maincent
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Kory Maincent @ 2025-06-20 8:24 UTC (permalink / raw)
To: Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Paul Barker, Marc Murphy
Cc: Thomas Petazzoni, linux-omap, devicetree, linux-kernel,
Romain Gantois, Thomas Bonnefille, Bajjuri Praneeth,
Kory Maincent, Andrew Davis
This series addresses inconsistencies in OMAP devicetree bindings and
compatible strings for AM33xx-based boards:
- Add missing compatible strings to binding documentation
- Update vendor prefix from "ti" to "beagle" for BeagleBone boards
to reflect actual hardware vendors
- Remove redundant compatible strings from device properties
Note: Originally attempted to align devicetree model descriptions but
received pushback due to Debian script dependencies (see thread at
https://lore.kernel.org/all/7e854232-f02f-4ad6-b65e-22c18d1d9fe5@jm0.eu/).
The compatible string changes may face similar concerns and would
benefit from devicetree maintainer review.
This work was split from a larger series to address feedback and allow
independent progression of each topic area. Original series:
https://lore.kernel.org/r/20250617-bbg-v4-0-827cbd606db6@bootlin.com
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Kory Maincent (2):
dt-bindings: omap: Add missing AM33xx compatible strings
arm: dts: omap: Remove incorrect compatible strings from device trees
Documentation/devicetree/bindings/arm/ti/omap.yaml | 22 +++++++++++++++++++++-
arch/arm/boot/dts/ti/omap/am335x-base0033.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-bone.dts | 2 +-
.../boot/dts/ti/omap/am335x-boneblack-wireless.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-boneblack.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-boneblue.dts | 2 +-
.../boot/dts/ti/omap/am335x-bonegreen-wireless.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts | 3 +--
arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts | 2 +-
.../arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts | 2 +-
.../ti/omap/am335x-sancloud-bbe-extended-wifi.dts | 5 +----
.../boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts | 5 +----
arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-shc.dts | 2 +-
16 files changed, 36 insertions(+), 23 deletions(-)
---
base-commit: e22b9ddaf3afd031abc350c303c7c07a51c569d8
change-id: 20250619-ti_dts_clean-d1d86c9e675f
Best regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] dt-bindings: omap: Add missing AM33xx compatible strings
2025-06-20 8:24 [PATCH 0/2] arm: dts: OMAP: Clean up devicetree bindings and compatible strings Kory Maincent
@ 2025-06-20 8:24 ` Kory Maincent
2025-06-20 14:08 ` Conor Dooley
2025-06-20 8:24 ` [PATCH 2/2] arm: dts: omap: Remove incorrect compatible strings from device trees Kory Maincent
2025-06-20 14:15 ` [PATCH 0/2] arm: dts: OMAP: Clean up devicetree bindings and compatible strings Conor Dooley
2 siblings, 1 reply; 8+ messages in thread
From: Kory Maincent @ 2025-06-20 8:24 UTC (permalink / raw)
To: Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Paul Barker, Marc Murphy
Cc: Thomas Petazzoni, linux-omap, devicetree, linux-kernel,
Romain Gantois, Thomas Bonnefille, Bajjuri Praneeth,
Kory Maincent, Andrew Davis
Add several compatible strings that were missing from the binding
documentation for AM33xx-based boards. Update vendor prefix from
"ti" to "beagle" for BeagleBone to match actual hardware vendors.
Reviewed-by: Andrew Davis <afd@ti.com>
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Documentation/devicetree/bindings/arm/ti/omap.yaml | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
index 3603edd7361d..7e0d5d376d57 100644
--- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
@@ -104,12 +104,32 @@ properties:
- description: TI AM33 based platform
items:
- enum:
+ - beagle,am335x-bone
+ - beagle,am335x-bone-black
+ - beagle,am335x-bone-black-wireless
+ - beagle,am335x-bone-blue
+ - beagle,am335x-pocketbeagle
+ - bosch,am335x-guardian
+ - bosch,am335x-shc
- compulab,cm-t335
+ - grinn,am335x-chiliboard
+ - grinn,am335x-chilisom
+ - gumstix,am335x-pepper
+ - isee,am335x-base0033
+ - moxa,uc-2101
- moxa,uc-8100-me-t
+ - myir,myc-am335x
+ - myir,myd-am335x
- novatech,am335x-lxm
- - ti,am335x-bone
+ - oct,osd3358-sm-refdesign
+ - sancloud,am335x-boneenhanced
+ - seeed,am335x-bone-green
+ - seeed,am335x-bone-green-wireless
+ - tcl,am335x-sl50
- ti,am335x-evm
+ - ti,am335x-evmsk
- ti,am3359-icev2
+ - vscom,onrisc
- const: ti,am33xx
- description: Compulab board variants based on TI AM33
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] arm: dts: omap: Remove incorrect compatible strings from device trees
2025-06-20 8:24 [PATCH 0/2] arm: dts: OMAP: Clean up devicetree bindings and compatible strings Kory Maincent
2025-06-20 8:24 ` [PATCH 1/2] dt-bindings: omap: Add missing AM33xx " Kory Maincent
@ 2025-06-20 8:24 ` Kory Maincent
2025-06-20 14:15 ` [PATCH 0/2] arm: dts: OMAP: Clean up devicetree bindings and compatible strings Conor Dooley
2 siblings, 0 replies; 8+ messages in thread
From: Kory Maincent @ 2025-06-20 8:24 UTC (permalink / raw)
To: Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Paul Barker, Marc Murphy
Cc: Thomas Petazzoni, linux-omap, devicetree, linux-kernel,
Romain Gantois, Thomas Bonnefille, Bajjuri Praneeth,
Kory Maincent
Several device trees incorrectly included extraneous compatible strings
in their compatible property lists. The policy is to only describe the
specific board name and SoC name to avoid confusion.
Remove these incorrect compatible strings to fix the inconsistency.
Also fix board vendor prefixes for BeagleBoard variants that were
incorrectly using "ti" instead of "beagle" or "seeed".
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
arch/arm/boot/dts/ti/omap/am335x-base0033.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-bone.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-boneblack-wireless.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-boneblack.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-boneblue.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts | 3 +--
arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts | 5 +----
arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts | 5 +----
arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-shc.dts | 2 +-
15 files changed, 15 insertions(+), 22 deletions(-)
diff --git a/arch/arm/boot/dts/ti/omap/am335x-base0033.dts b/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
index 46078af4b7a3..176de29de2a6 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
@@ -9,7 +9,7 @@
/ {
model = "IGEP COM AM335x on AQUILA Expansion";
- compatible = "isee,am335x-base0033", "isee,am335x-igep0033", "ti,am33xx";
+ compatible = "isee,am335x-base0033", "ti,am33xx";
hdmi {
compatible = "ti,tilcdc,slave";
diff --git a/arch/arm/boot/dts/ti/omap/am335x-bone.dts b/arch/arm/boot/dts/ti/omap/am335x-bone.dts
index b5d85ef51a02..08616d449f95 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-bone.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-bone.dts
@@ -9,7 +9,7 @@
/ {
model = "TI AM335x BeagleBone";
- compatible = "ti,am335x-bone", "ti,am33xx";
+ compatible = "beagle,am335x-bone", "ti,am33xx";
};
&ldo3_reg {
diff --git a/arch/arm/boot/dts/ti/omap/am335x-boneblack-wireless.dts b/arch/arm/boot/dts/ti/omap/am335x-boneblack-wireless.dts
index b4b4b80df08c..aa668dfa1c6a 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-boneblack-wireless.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-boneblack-wireless.dts
@@ -12,7 +12,7 @@
/ {
model = "TI AM335x BeagleBone Black Wireless";
- compatible = "ti,am335x-bone-black-wireless", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
+ compatible = "beagle,am335x-bone-black-wireless", "ti,am33xx";
wlan_en_reg: fixedregulator@2 {
compatible = "regulator-fixed";
diff --git a/arch/arm/boot/dts/ti/omap/am335x-boneblack.dts b/arch/arm/boot/dts/ti/omap/am335x-boneblack.dts
index 16b567e3cb47..476fb6677203 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-boneblack.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-boneblack.dts
@@ -11,7 +11,7 @@
/ {
model = "TI AM335x BeagleBone Black";
- compatible = "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
+ compatible = "beagle,am335x-bone-black", "ti,am33xx";
};
&cpu0_opp_table {
diff --git a/arch/arm/boot/dts/ti/omap/am335x-boneblue.dts b/arch/arm/boot/dts/ti/omap/am335x-boneblue.dts
index f579df4c2c54..56f9042a5bfb 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-boneblue.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-boneblue.dts
@@ -10,7 +10,7 @@
/ {
model = "TI AM335x BeagleBone Blue";
- compatible = "ti,am335x-bone-blue", "ti,am33xx";
+ compatible = "beagle,am335x-bone-blue", "ti,am33xx";
chosen {
stdout-path = &uart0;
diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
index a4f5b5262645..37d4d5a3edf6 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
@@ -11,7 +11,7 @@
/ {
model = "TI AM335x BeagleBone Green Wireless";
- compatible = "ti,am335x-bone-green-wireless", "ti,am335x-bone-green", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
+ compatible = "seeed,am335x-bone-green-wireless", "ti,am33xx";
wlan_en_reg: fixedregulator@2 {
compatible = "regulator-fixed";
diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts b/arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts
index 18cc0f49e999..3d6404653816 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts
@@ -10,5 +10,5 @@
/ {
model = "TI AM335x BeagleBone Green";
- compatible = "ti,am335x-bone-green", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
+ compatible = "seeed,am335x-bone-green", "ti,am33xx";
};
diff --git a/arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts b/arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts
index 648e97fe1dfd..224095304ef3 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts
@@ -8,8 +8,7 @@
/ {
model = "AM335x Chiliboard";
- compatible = "grinn,am335x-chiliboard", "grinn,am335x-chilisom",
- "ti,am33xx";
+ compatible = "grinn,am335x-chiliboard", "ti,am33xx";
chosen {
stdout-path = &uart0;
diff --git a/arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts b/arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts
index fd91a3c01a63..55a454f51148 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts
@@ -12,7 +12,7 @@
/ {
model = "MYIR MYD-AM335X";
- compatible = "myir,myd-am335x", "myir,myc-am335x", "ti,am33xx";
+ compatible = "myir,myd-am335x", "ti,am33xx";
chosen {
stdout-path = &uart0;
diff --git a/arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts b/arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts
index d28d39728847..d87ac31a16a9 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts
@@ -16,7 +16,7 @@
/ {
model = "Octavo Systems OSD3358-SM-RED";
- compatible = "oct,osd3358-sm-refdesign", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
+ compatible = "oct,osd3358-sm-refdesign", "ti,am33xx";
};
&ldo3_reg {
diff --git a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
index 78ce860e59b3..908203fd9190 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
@@ -12,7 +12,7 @@
/ {
model = "TI AM335x PocketBeagle";
- compatible = "ti,am335x-pocketbeagle", "ti,am335x-bone", "ti,am33xx";
+ compatible = "beagle,am335x-pocketbeagle", "ti,am33xx";
chosen {
stdout-path = &uart0;
diff --git a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts
index 7c9f65126c63..61210f975542 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts
@@ -13,10 +13,7 @@
/ {
model = "SanCloud BeagleBone Enhanced Extended WiFi";
- compatible = "sancloud,am335x-boneenhanced",
- "ti,am335x-bone-black",
- "ti,am335x-bone",
- "ti,am33xx";
+ compatible = "sancloud,am335x-boneenhanced", "ti,am33xx";
wlan_en_reg: fixedregulator@2 {
compatible = "regulator-fixed";
diff --git a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts
index c6c96f6182a8..10488b55689c 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts
@@ -12,10 +12,7 @@
/ {
model = "SanCloud BeagleBone Enhanced Lite";
- compatible = "sancloud,am335x-boneenhanced",
- "ti,am335x-bone-black",
- "ti,am335x-bone",
- "ti,am33xx";
+ compatible = "sancloud,am335x-boneenhanced", "ti,am33xx";
};
&am33xx_pinmux {
diff --git a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts
index 32669346cefe..f1bdbf053fb2 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts
@@ -13,7 +13,7 @@
/ {
model = "SanCloud BeagleBone Enhanced";
- compatible = "sancloud,am335x-boneenhanced", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
+ compatible = "sancloud,am335x-boneenhanced", "ti,am33xx";
};
&am33xx_pinmux {
diff --git a/arch/arm/boot/dts/ti/omap/am335x-shc.dts b/arch/arm/boot/dts/ti/omap/am335x-shc.dts
index 597482822608..47b1db476cf3 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-shc.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-shc.dts
@@ -12,7 +12,7 @@
/ {
model = "Bosch SHC";
- compatible = "ti,am335x-shc", "ti,am335x-bone", "ti,am33xx";
+ compatible = "bosch,am335x-shc", "ti,am33xx";
aliases {
mmcblk0 = &mmc1;
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: omap: Add missing AM33xx compatible strings
2025-06-20 8:24 ` [PATCH 1/2] dt-bindings: omap: Add missing AM33xx " Kory Maincent
@ 2025-06-20 14:08 ` Conor Dooley
2025-06-20 14:09 ` Conor Dooley
0 siblings, 1 reply; 8+ messages in thread
From: Conor Dooley @ 2025-06-20 14:08 UTC (permalink / raw)
To: Kory Maincent
Cc: Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Paul Barker, Marc Murphy, Thomas Petazzoni, linux-omap,
devicetree, linux-kernel, Romain Gantois, Thomas Bonnefille,
Bajjuri Praneeth, Andrew Davis
[-- Attachment #1: Type: text/plain, Size: 2312 bytes --]
On Fri, Jun 20, 2025 at 10:24:08AM +0200, Kory Maincent wrote:
> Add several compatible strings that were missing from the binding
> documentation for AM33xx-based boards. Update vendor prefix from
> "ti" to "beagle" for BeagleBone to match actual hardware vendors.
>
> Reviewed-by: Andrew Davis <afd@ti.com>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
This is a v1 apparently, what is the relationship between this patch and
https://lore.kernel.org/all/20250617-bbg-v4-1-827cbd606db6@bootlin.com/
?
> ---
> Documentation/devicetree/bindings/arm/ti/omap.yaml | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> index 3603edd7361d..7e0d5d376d57 100644
> --- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> @@ -104,12 +104,32 @@ properties:
> - description: TI AM33 based platform
> items:
> - enum:
> + - beagle,am335x-bone
> + - beagle,am335x-bone-black
> + - beagle,am335x-bone-black-wireless
> + - beagle,am335x-bone-blue
> + - beagle,am335x-pocketbeagle
> + - bosch,am335x-guardian
> + - bosch,am335x-shc
> - compulab,cm-t335
> + - grinn,am335x-chiliboard
> + - grinn,am335x-chilisom
> + - gumstix,am335x-pepper
> + - isee,am335x-base0033
> + - moxa,uc-2101
> - moxa,uc-8100-me-t
> + - myir,myc-am335x
> + - myir,myd-am335x
> - novatech,am335x-lxm
> - - ti,am335x-bone
> + - oct,osd3358-sm-refdesign
> + - sancloud,am335x-boneenhanced
> + - seeed,am335x-bone-green
> + - seeed,am335x-bone-green-wireless
> + - tcl,am335x-sl50
> - ti,am335x-evm
> + - ti,am335x-evmsk
> - ti,am3359-icev2
> + - vscom,onrisc
> - const: ti,am33xx
>
> - description: Compulab board variants based on TI AM33
>
> --
> 2.43.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: omap: Add missing AM33xx compatible strings
2025-06-20 14:08 ` Conor Dooley
@ 2025-06-20 14:09 ` Conor Dooley
2025-06-20 14:26 ` Kory Maincent
0 siblings, 1 reply; 8+ messages in thread
From: Conor Dooley @ 2025-06-20 14:09 UTC (permalink / raw)
To: Kory Maincent
Cc: Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Paul Barker, Marc Murphy, Thomas Petazzoni, linux-omap,
devicetree, linux-kernel, Romain Gantois, Thomas Bonnefille,
Bajjuri Praneeth, Andrew Davis
[-- Attachment #1: Type: text/plain, Size: 2636 bytes --]
On Fri, Jun 20, 2025 at 03:08:24PM +0100, Conor Dooley wrote:
> On Fri, Jun 20, 2025 at 10:24:08AM +0200, Kory Maincent wrote:
> > Add several compatible strings that were missing from the binding
> > documentation for AM33xx-based boards. Update vendor prefix from
> > "ti" to "beagle" for BeagleBone to match actual hardware vendors.
> >
> > Reviewed-by: Andrew Davis <afd@ti.com>
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
>
> This is a v1 apparently, what is the relationship between this patch and
> https://lore.kernel.org/all/20250617-bbg-v4-1-827cbd606db6@bootlin.com/
> ?
(I ask because at a scan I didn't see differences and I had acked the
last one, which doesn't show here even though Andrew's r-b does)
>
> > ---
> > Documentation/devicetree/bindings/arm/ti/omap.yaml | 22 +++++++++++++++++++++-
> > 1 file changed, 21 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > index 3603edd7361d..7e0d5d376d57 100644
> > --- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > +++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > @@ -104,12 +104,32 @@ properties:
> > - description: TI AM33 based platform
> > items:
> > - enum:
> > + - beagle,am335x-bone
> > + - beagle,am335x-bone-black
> > + - beagle,am335x-bone-black-wireless
> > + - beagle,am335x-bone-blue
> > + - beagle,am335x-pocketbeagle
> > + - bosch,am335x-guardian
> > + - bosch,am335x-shc
> > - compulab,cm-t335
> > + - grinn,am335x-chiliboard
> > + - grinn,am335x-chilisom
> > + - gumstix,am335x-pepper
> > + - isee,am335x-base0033
> > + - moxa,uc-2101
> > - moxa,uc-8100-me-t
> > + - myir,myc-am335x
> > + - myir,myd-am335x
> > - novatech,am335x-lxm
> > - - ti,am335x-bone
> > + - oct,osd3358-sm-refdesign
> > + - sancloud,am335x-boneenhanced
> > + - seeed,am335x-bone-green
> > + - seeed,am335x-bone-green-wireless
> > + - tcl,am335x-sl50
> > - ti,am335x-evm
> > + - ti,am335x-evmsk
> > - ti,am3359-icev2
> > + - vscom,onrisc
> > - const: ti,am33xx
> >
> > - description: Compulab board variants based on TI AM33
> >
> > --
> > 2.43.0
> >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] arm: dts: OMAP: Clean up devicetree bindings and compatible strings
2025-06-20 8:24 [PATCH 0/2] arm: dts: OMAP: Clean up devicetree bindings and compatible strings Kory Maincent
2025-06-20 8:24 ` [PATCH 1/2] dt-bindings: omap: Add missing AM33xx " Kory Maincent
2025-06-20 8:24 ` [PATCH 2/2] arm: dts: omap: Remove incorrect compatible strings from device trees Kory Maincent
@ 2025-06-20 14:15 ` Conor Dooley
2 siblings, 0 replies; 8+ messages in thread
From: Conor Dooley @ 2025-06-20 14:15 UTC (permalink / raw)
To: Kory Maincent
Cc: Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Paul Barker, Marc Murphy, Thomas Petazzoni, linux-omap,
devicetree, linux-kernel, Romain Gantois, Thomas Bonnefille,
Bajjuri Praneeth, Andrew Davis
[-- Attachment #1: Type: text/plain, Size: 2939 bytes --]
On Fri, Jun 20, 2025 at 10:24:07AM +0200, Kory Maincent wrote:
> This series addresses inconsistencies in OMAP devicetree bindings and
> compatible strings for AM33xx-based boards:
>
> - Add missing compatible strings to binding documentation
> - Update vendor prefix from "ti" to "beagle" for BeagleBone boards
> to reflect actual hardware vendors
> - Remove redundant compatible strings from device properties
>
> Note: Originally attempted to align devicetree model descriptions but
> received pushback due to Debian script dependencies (see thread at
> https://lore.kernel.org/all/7e854232-f02f-4ad6-b65e-22c18d1d9fe5@jm0.eu/).
> The compatible string changes may face similar concerns and would
> benefit from devicetree maintainer review.
I think relying on the "model" field is really silly, but there's also
probably very little harm in keeping the old names. I'd be much more
understanding if the complaint was about the compatible strings
changing! Keeping old ?image packing tools? working with new devicetrees
is a platform maintainer thing really, what we care much more about is
old devicetrees with new software.
>
> This work was split from a larger series to address feedback and allow
> independent progression of each topic area. Original series:
> https://lore.kernel.org/r/20250617-bbg-v4-0-827cbd606db6@bootlin.com
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> Kory Maincent (2):
> dt-bindings: omap: Add missing AM33xx compatible strings
> arm: dts: omap: Remove incorrect compatible strings from device trees
>
> Documentation/devicetree/bindings/arm/ti/omap.yaml | 22 +++++++++++++++++++++-
> arch/arm/boot/dts/ti/omap/am335x-base0033.dts | 2 +-
> arch/arm/boot/dts/ti/omap/am335x-bone.dts | 2 +-
> .../boot/dts/ti/omap/am335x-boneblack-wireless.dts | 2 +-
> arch/arm/boot/dts/ti/omap/am335x-boneblack.dts | 2 +-
> arch/arm/boot/dts/ti/omap/am335x-boneblue.dts | 2 +-
> .../boot/dts/ti/omap/am335x-bonegreen-wireless.dts | 2 +-
> arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts | 2 +-
> arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts | 3 +--
> arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts | 2 +-
> .../arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts | 2 +-
> arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts | 2 +-
> .../ti/omap/am335x-sancloud-bbe-extended-wifi.dts | 5 +----
> .../boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts | 5 +----
> arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts | 2 +-
> arch/arm/boot/dts/ti/omap/am335x-shc.dts | 2 +-
> 16 files changed, 36 insertions(+), 23 deletions(-)
> ---
> base-commit: e22b9ddaf3afd031abc350c303c7c07a51c569d8
> change-id: 20250619-ti_dts_clean-d1d86c9e675f
>
> Best regards,
> --
> Köry Maincent, Bootlin
> Embedded Linux and kernel engineering
> https://bootlin.com
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: omap: Add missing AM33xx compatible strings
2025-06-20 14:09 ` Conor Dooley
@ 2025-06-20 14:26 ` Kory Maincent
2025-06-23 14:36 ` Conor Dooley
0 siblings, 1 reply; 8+ messages in thread
From: Kory Maincent @ 2025-06-20 14:26 UTC (permalink / raw)
To: Conor Dooley
Cc: Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Paul Barker, Marc Murphy, Thomas Petazzoni, linux-omap,
devicetree, linux-kernel, Romain Gantois, Thomas Bonnefille,
Bajjuri Praneeth, Andrew Davis
Le Fri, 20 Jun 2025 15:09:41 +0100,
Conor Dooley <conor@kernel.org> a écrit :
> On Fri, Jun 20, 2025 at 03:08:24PM +0100, Conor Dooley wrote:
> > On Fri, Jun 20, 2025 at 10:24:08AM +0200, Kory Maincent wrote:
> > > Add several compatible strings that were missing from the binding
> > > documentation for AM33xx-based boards. Update vendor prefix from
> > > "ti" to "beagle" for BeagleBone to match actual hardware vendors.
> > >
> > > Reviewed-by: Andrew Davis <afd@ti.com>
> > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> >
> > This is a v1 apparently, what is the relationship between this patch and
> > https://lore.kernel.org/all/20250617-bbg-v4-1-827cbd606db6@bootlin.com/
> > ?
>
> (I ask because at a scan I didn't see differences and I had acked the
> last one, which doesn't show here even though Andrew's r-b does)
Oh, you acked-by was lost in the void during the patch series split sorry for
that.
Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: omap: Add missing AM33xx compatible strings
2025-06-20 14:26 ` Kory Maincent
@ 2025-06-23 14:36 ` Conor Dooley
0 siblings, 0 replies; 8+ messages in thread
From: Conor Dooley @ 2025-06-23 14:36 UTC (permalink / raw)
To: Kory Maincent
Cc: Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Paul Barker, Marc Murphy, Thomas Petazzoni, linux-omap,
devicetree, linux-kernel, Romain Gantois, Thomas Bonnefille,
Bajjuri Praneeth, Andrew Davis
[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]
On Fri, Jun 20, 2025 at 04:26:17PM +0200, Kory Maincent wrote:
> Le Fri, 20 Jun 2025 15:09:41 +0100,
> Conor Dooley <conor@kernel.org> a écrit :
>
> > On Fri, Jun 20, 2025 at 03:08:24PM +0100, Conor Dooley wrote:
> > > On Fri, Jun 20, 2025 at 10:24:08AM +0200, Kory Maincent wrote:
> > > > Add several compatible strings that were missing from the binding
> > > > documentation for AM33xx-based boards. Update vendor prefix from
> > > > "ti" to "beagle" for BeagleBone to match actual hardware vendors.
> > > >
> > > > Reviewed-by: Andrew Davis <afd@ti.com>
> > > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > >
> > > This is a v1 apparently, what is the relationship between this patch and
> > > https://lore.kernel.org/all/20250617-bbg-v4-1-827cbd606db6@bootlin.com/
> > > ?
> >
> > (I ask because at a scan I didn't see differences and I had acked the
> > last one, which doesn't show here even though Andrew's r-b does)
>
> Oh, you acked-by was lost in the void during the patch series split sorry for
> that.
In that case,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-06-23 14:36 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-20 8:24 [PATCH 0/2] arm: dts: OMAP: Clean up devicetree bindings and compatible strings Kory Maincent
2025-06-20 8:24 ` [PATCH 1/2] dt-bindings: omap: Add missing AM33xx " Kory Maincent
2025-06-20 14:08 ` Conor Dooley
2025-06-20 14:09 ` Conor Dooley
2025-06-20 14:26 ` Kory Maincent
2025-06-23 14:36 ` Conor Dooley
2025-06-20 8:24 ` [PATCH 2/2] arm: dts: omap: Remove incorrect compatible strings from device trees Kory Maincent
2025-06-20 14:15 ` [PATCH 0/2] arm: dts: OMAP: Clean up devicetree bindings and compatible strings Conor Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).