linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Richard Cochran <richardcochran@gmail.com>, netdev@vger.kernel.org
Subject: [patch 10/13] ptp: Split out PTP_MASK_CLEAR_ALL ioctl code
Date: Fri, 20 Jun 2025 15:24:44 +0200 (CEST)	[thread overview]
Message-ID: <20250620131944.344887489@linutronix.de> (raw)
In-Reply-To: 20250620130144.351492917@linutronix.de

Continue the ptp_ioctl() cleanup by splitting out the PTP_MASK_CLEAR_ALL ioctl
code into a helper function.

No functional change intended.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/ptp/ptp_chardev.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

--- a/drivers/ptp/ptp_chardev.c
+++ b/drivers/ptp/ptp_chardev.c
@@ -442,6 +442,12 @@ static long ptp_pin_setfunc(struct ptp_c
 		return ptp_set_pinfunc(ptp, pin_index, pd.func, pd.chan);
 }
 
+static long ptp_mask_clear_all(struct timestamp_event_queue *tsevq)
+{
+	bitmap_clear(tsevq->mask, 0, PTP_MAX_CHANNELS);
+	return 0;
+}
+
 long ptp_ioctl(struct posix_clock_context *pccontext, unsigned int cmd,
 	       unsigned long arg)
 {
@@ -504,8 +510,7 @@ long ptp_ioctl(struct posix_clock_contex
 		return ptp_pin_setfunc(ptp, cmd, argptr);
 
 	case PTP_MASK_CLEAR_ALL:
-		bitmap_clear(tsevq->mask, 0, PTP_MAX_CHANNELS);
-		break;
+		return ptp_mask_clear_all(pccontext->private_clkdata);
 
 	case PTP_MASK_EN_SINGLE:
 		if (copy_from_user(&i, (void __user *)arg, sizeof(i))) {


  parent reply	other threads:[~2025-06-20 13:24 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-20 13:24 [patch 00/13] ptp: Belated spring cleaning of the chardev driver Thomas Gleixner
2025-06-20 13:24 ` [patch 01/13] ptp: Split out PTP_CLOCK_GETCAPS ioctl code Thomas Gleixner
2025-06-21 20:22   ` Vadim Fedorenko
2025-06-20 13:24 ` [patch 02/13] ptp: Split out PTP_EXTTS_REQUEST " Thomas Gleixner
2025-06-21 20:24   ` Vadim Fedorenko
2025-06-20 13:24 ` [patch 03/13] ptp: Split out PTP_PEROUT_REQUEST " Thomas Gleixner
2025-06-21 20:24   ` Vadim Fedorenko
2025-06-20 13:24 ` [patch 04/13] ptp: Split out PTP_ENABLE_PPS " Thomas Gleixner
2025-06-21 20:25   ` Vadim Fedorenko
2025-06-20 13:24 ` [patch 05/13] ptp: Split out PTP_SYS_OFFSET_PRECISE " Thomas Gleixner
2025-06-21 20:27   ` Vadim Fedorenko
2025-06-20 13:24 ` [patch 06/13] ptp: Split out PTP_SYS_OFFSET_EXTENDED " Thomas Gleixner
2025-06-21 20:29   ` Vadim Fedorenko
2025-06-20 13:24 ` [patch 07/13] ptp: Split out PTP_SYS_OFFSET " Thomas Gleixner
2025-06-21 20:14   ` Vadim Fedorenko
2025-06-21 20:42     ` Thomas Gleixner
2025-06-21 20:58       ` Vadim Fedorenko
2025-06-20 13:24 ` [patch 08/13] ptp: Split out PTP_PIN_GETFUNC " Thomas Gleixner
2025-06-21 20:29   ` Vadim Fedorenko
2025-06-24  9:22   ` Paolo Abeni
2025-06-24 13:39     ` Thomas Gleixner
2025-06-25  8:19       ` Thomas Gleixner
2025-06-20 13:24 ` [patch 09/13] ptp: Split out PTP_PIN_SETFUNC " Thomas Gleixner
2025-06-21 20:30   ` Vadim Fedorenko
2025-06-20 13:24 ` Thomas Gleixner [this message]
2025-06-21 20:36   ` [patch 10/13] ptp: Split out PTP_MASK_CLEAR_ALL " Vadim Fedorenko
2025-06-21 20:44     ` Thomas Gleixner
2025-06-21 20:59       ` Vadim Fedorenko
2025-06-20 13:24 ` [patch 11/13] ptp: Split out PTP_MASK_EN_SINGLE " Thomas Gleixner
2025-06-21 20:32   ` Vadim Fedorenko
2025-06-20 13:24 ` [patch 12/13] ptp: Convert chardev code to lock guards Thomas Gleixner
2025-06-20 13:24 ` [patch 13/13] ptp: Convert ptp_open/read() to __free() Thomas Gleixner
2025-06-24  9:48   ` Paolo Abeni
2025-06-24 13:38     ` Thomas Gleixner
2025-06-24 16:36   ` Jakub Kicinski
2025-06-25 10:33     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250620131944.344887489@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).