From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <horms@kernel.org>
Cc: Kory Maincent <kory.maincent@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>,
thomas.petazzoni@bootlin.com,
Oleksij Rempel <o.rempel@pengutronix.de>,
Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next] ethtool: pse-pd: Add missing linux/export.h include
Date: Sat, 21 Jun 2025 07:00:43 -0700 [thread overview]
Message-ID: <20250621070043.21e1c852@kernel.org> (raw)
In-Reply-To: <20250620101452.GE194429@horms.kernel.org>
On Fri, 20 Jun 2025 11:14:52 +0100 Simon Horman wrote:
> On Thu, Jun 19, 2025 at 06:25:47PM +0200, Kory Maincent wrote:
> > Fix missing linux/export.h header include in net/ethtool/pse-pd.c to resolve
> > build warning reported by the kernel test robot.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202506200024.T3O0FWeR-lkp@intel.com/
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
>
> The change that introduced this warning introduced a log of such warnings.
> Including a lot in the Networking subsystem. (I did not count them.)
>
> So I agree with the point from Sean Christopherson [*] is that if the patch
> that introduced the warnings isn't reverted
It was reverted, thankfully. So I assume we treat this patch as
a normal "include what you need" case and therefore apply.. ?
> then a more comprehensive approach is needed to address these warnings.
>
> [*] Re: [PATCH 3/6] KVM: x86: hyper-v: Fix warnings for missing export.h header inclusion
> https://lore.kernel.org/netdev/aEl9kO81-kp0hhw0@google.com/
next prev parent reply other threads:[~2025-06-21 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 16:25 [PATCH net-next] ethtool: pse-pd: Add missing linux/export.h include Kory Maincent
2025-06-20 10:14 ` Simon Horman
2025-06-20 12:17 ` Kory Maincent
2025-06-21 14:00 ` Jakub Kicinski [this message]
2025-06-23 20:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250621070043.21e1c852@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).