From: Jakub Kicinski <kuba@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <horms@kernel.org>,
<shenjian15@huawei.com>, <wangpeiyang1@huawei.com>,
<liuyonglong@huawei.com>, <chenhao418@huawei.com>,
<jonathan.cameron@huawei.com>,
<shameerali.kolothum.thodi@huawei.com>, <salil.mehta@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 3/3] net: hibmcge: configure FIFO thresholds according to the MAC controller documentation
Date: Sat, 21 Jun 2025 08:35:43 -0700 [thread overview]
Message-ID: <20250621083543.67459b3b@kernel.org> (raw)
In-Reply-To: <20250619144423.2661528-4-shaojijie@huawei.com>
On Thu, 19 Jun 2025 22:44:23 +0800 Jijie Shao wrote:
> + value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_TX_FULL_M, full);
> + value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_TX_EMPTY_M , empty);
> + }
> +
> + if (dir & HBG_DIR_RX) {
> + value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_RX_FULL_M, full);
> + value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_RX_EMPTY_M , empty);
nit checkpatch says:
WARNING: line length of 81 exceeds 80 columns
#62: FILE: drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c:306:
+ value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_TX_EMPTY_M , empty);
ERROR: space prohibited before that ',' (ctx:WxW)
#62: FILE: drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c:306:
+ value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_TX_EMPTY_M , empty);
^
WARNING: line length of 81 exceeds 80 columns
#67: FILE: drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c:311:
+ value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_RX_EMPTY_M , empty);
ERROR: space prohibited before that ',' (ctx:WxW)
#67: FILE: drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c:311:
+ value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_RX_EMPTY_M , empty);
^
total: 2 errors, 2 warnings, 0 checks, 79 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
--
pw-bot: cr
next prev parent reply other threads:[~2025-06-21 15:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 14:44 [PATCH net-next 0/3] Support some features for the HIBMCGE driver Jijie Shao
2025-06-19 14:44 ` [PATCH net-next 1/3] net: hibmcge: support scenario without PHY Jijie Shao
2025-06-19 14:44 ` [PATCH net-next 2/3] net: hibmcge: adjust the burst len configuration of the MAC controller to improve TX performance Jijie Shao
2025-06-19 14:44 ` [PATCH net-next 3/3] net: hibmcge: configure FIFO thresholds according to the MAC controller documentation Jijie Shao
2025-06-21 15:35 ` Jakub Kicinski [this message]
2025-06-23 1:43 ` Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250621083543.67459b3b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangpeiyang1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).