From: Heiko Carstens <hca@linux.ibm.com>
To: Petr Pavlu <petr.pavlu@suse.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/boot: Use -D__DISABLE_EXPORTS
Date: Mon, 23 Jun 2025 11:25:10 +0200 [thread overview]
Message-ID: <20250623092510.11264A74-hca@linux.ibm.com> (raw)
In-Reply-To: <20250620154649.116068-1-petr.pavlu@suse.com>
On Fri, Jun 20, 2025 at 05:45:49PM +0200, Petr Pavlu wrote:
> Files in the arch/s390/boot directory reuse logic from the rest of the
> kernel by including certain C and assembly files from the kernel and lib
> directories. Some of these included files contain EXPORT_SYMBOL directives.
> For instance, arch/s390/boot/cmdline.c includes lib/cmdline.c, which
> exports the get_option() function.
>
> This inclusion triggers genksyms processing for the files in
> arch/s390/boot, which is unnecessary and slows down the build.
> Additionally, when KBUILD_SYMTYPES=1 is set, the generated symtypes data
> contain exported symbols that are duplicated with the main kernel. This
> duplication can confuse external kABI tools that process the symtypes data.
>
> Address this issue by compiling the files in arch/s390/boot with
> -D__DISABLE_EXPORTS.
>
> Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
> ---
> arch/s390/boot/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
next prev parent reply other threads:[~2025-06-23 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 15:45 [PATCH] s390/boot: Use -D__DISABLE_EXPORTS Petr Pavlu
2025-06-23 9:25 ` Heiko Carstens [this message]
2025-06-23 15:39 ` Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250623092510.11264A74-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=petr.pavlu@suse.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).