From: Jakub Kicinski <kuba@kernel.org>
To: Thomas Fourier <fourier.thomas@gmail.com>
Cc: Chas Williams <3chas3@gmail.com>,
linux-atm-general@lists.sourceforge.net (moderated list:ATM),
netdev@vger.kernel.org (open list:ATM),
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] atm: idt77252: Add missing `dma_map_error()`
Date: Mon, 23 Jun 2025 16:40:41 -0700 [thread overview]
Message-ID: <20250623164041.66ef9cb3@kernel.org> (raw)
In-Reply-To: <20250619105707.320393-2-fourier.thomas@gmail.com>
On Thu, 19 Jun 2025 12:57:06 +0200 Thomas Fourier wrote:
> @@ -1857,6 +1859,8 @@ add_rx_skb(struct idt77252_dev *card, int queue,
> paddr = dma_map_single(&card->pcidev->dev, skb->data,
> skb_end_pointer(skb) - skb->data,
> DMA_FROM_DEVICE);
> + if (dma_mapping_error(&card->pcidev->dev, paddr))
> + goto outfree;
> IDT77252_PRV_PADDR(skb) = paddr;
>
> if (push_rx_skb(card, skb, queue)) {
Hm, you're missing undoing sb_pool_add()
Like in another patch from you -- either jump to a new label in between
the existing two which does the necessary unwind, or move the mapping
earlier, before we start adding the skb into the SW queue.
--
pw-bot: cr
prev parent reply other threads:[~2025-06-23 23:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 10:57 [PATCH] atm: idt77252: Add missing `dma_map_error()` Thomas Fourier
2025-06-23 23:40 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250623164041.66ef9cb3@kernel.org \
--to=kuba@kernel.org \
--cc=3chas3@gmail.com \
--cc=fourier.thomas@gmail.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).