linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Khalid Ali <khaliidcaliy@gmail.com>
To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, hpa@zytor.com, corbet@lwn.net
Cc: luto@kernel.org, peterz@infradead.org, ardb@kernel.org,
	jan.kiszka@siemens.com, kbingham@kernel.org,
	kirill.shutemov@linux.intel.com, michael.roth@amd.com,
	rick.p.edgecombe@intel.com, brijesh.singh@amd.com,
	sandipan.das@amd.com, jgross@suse.com, thomas.lendacky@amd.com,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-efi@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCHv2 0/3] x86: Make 5-level paging support unconditional for x86-64
Date: Tue, 24 Jun 2025 08:23:03 +0000	[thread overview]
Message-ID: <20250624082305.2351-1-khaliidcaliy@gmail.com> (raw)
In-Reply-To: <20250516123306.3812286-1-kirill.shutemov@linux.intel.com>

>Both Intel and AMD CPUs support 5-level paging, which is expected to
>become more widely adopted in the future.
>
>Remove CONFIG_X86_5LEVEL.
>
>In preparation to that remove CONFIG_DYNAMIC_MEMORY_LAYOUT and make
>SPARSEMEM_VMEMMAP the only memory model.
>
>v3:
> - Drop few "#if CONFIG_PGTABLE_LEVELS >= 5";
> - Make PARAVIRT_XXL 64-bit explicitly and drop ifdefs
>   to support PGTABLE_LEVELS < 5;
> - Add Reviewed-by tags from Ard;
>v2:
> - Fix 32-bit build by wrapping p4d_set_huge() and p4d_clear_huge() in
>   #if CONFIG_PGTABLE_LEVELS > 4;
> - Rebased onto current tip/master;
>
>Kirill A. Shutemov (4):
>  x86/64/mm: Always use dynamic memory layout
>  x86/64/mm: Make SPARSEMEM_VMEMMAP the only memory model
>  x86/64/mm: Make 5-level paging support unconditional
>  x86/paravirt: Restrict PARAVIRT_XXL to 64-bit only
>
> Documentation/arch/x86/cpuinfo.rst            |  8 ++---
> .../arch/x86/x86_64/5level-paging.rst         |  9 -----
> arch/x86/Kconfig                              | 33 ++-----------------
> arch/x86/Kconfig.cpufeatures                  |  4 ---
> arch/x86/boot/compressed/pgtable_64.c         | 11 ++-----
> arch/x86/boot/header.S                        |  4 ---
> arch/x86/boot/startup/map_kernel.c            |  5 +--
> arch/x86/entry/vsyscall/vsyscall_64.c         |  2 --
> arch/x86/include/asm/page_64.h                |  2 --
> arch/x86/include/asm/page_64_types.h          | 11 -------
> arch/x86/include/asm/paravirt.h               |  4 ---
> arch/x86/include/asm/paravirt_types.h         |  2 --
> arch/x86/include/asm/pgtable_64.h             |  2 --
> arch/x86/include/asm/pgtable_64_types.h       | 24 --------------
> arch/x86/kernel/alternative.c                 |  2 +-
> arch/x86/kernel/head64.c                      |  4 ---
> arch/x86/kernel/head_64.S                     |  2 --
> arch/x86/kernel/paravirt.c                    |  2 --
> arch/x86/mm/init.c                            |  4 ---
> arch/x86/mm/init_64.c                         |  9 +----
> arch/x86/mm/pgtable.c                         |  2 +-
> arch/x86/xen/mmu_pv.c                         |  4 ---
> drivers/firmware/efi/libstub/x86-5lvl.c       |  2 +-
> scripts/gdb/linux/pgtable.py                  |  4 +--
> 24 files changed, 14 insertions(+), 142 deletions(-)

I think i am too late, however this is completely wrong. There are still processors that doesn't support
5-level paging which is mordern. We may call those processors old, however they are still common and used.

So this patch seem too early for that. Some intel core-i5 and core-i7 doesn't support 5-level paging at all.

This will break x86_64 cpus that doesn't support 5-level paging.

  parent reply	other threads:[~2025-06-24  8:23 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-16 12:33 [PATCHv3 0/4] x86: Make 5-level paging support unconditional for x86-64 Kirill A. Shutemov
2025-05-16 12:33 ` [PATCHv3 1/4] x86/64/mm: Always use dynamic memory layout Kirill A. Shutemov
2025-05-16 13:44   ` [tip: x86/core] x86/mm/64: " tip-bot2 for Kirill A. Shutemov
2025-05-17 13:00   ` [tip: x86/merge] " tip-bot2 for Kirill A. Shutemov
2025-05-16 12:33 ` [PATCHv3 2/4] x86/64/mm: Make SPARSEMEM_VMEMMAP the only memory model Kirill A. Shutemov
2025-05-16 13:42   ` Dave Hansen
2025-05-16 13:45     ` Ingo Molnar
2025-05-16 14:59       ` Dave Hansen
2025-05-16 15:08         ` Dave Hansen
2025-05-16 14:01     ` Kirill A. Shutemov
2025-05-16 14:08       ` Ingo Molnar
2025-05-16 15:03         ` Dave Hansen
2025-05-16 15:35           ` Ingo Molnar
2025-05-16 15:46             ` Dave Hansen
2025-05-16 18:28               ` H. Peter Anvin
2025-05-16 15:01       ` Dave Hansen
2025-05-16 13:44   ` [tip: x86/core] x86/mm/64: " tip-bot2 for Kirill A. Shutemov
2025-05-17 13:00   ` [tip: x86/merge] " tip-bot2 for Kirill A. Shutemov
2025-05-16 12:33 ` [PATCHv3 3/4] x86/64/mm: Make 5-level paging support unconditional Kirill A. Shutemov
2025-05-17 13:00   ` [tip: x86/merge] x86/mm/64: " tip-bot2 for Kirill A. Shutemov
2025-05-16 12:33 ` [PATCHv3 4/4] x86/paravirt: Restrict PARAVIRT_XXL to 64-bit only Kirill A. Shutemov
2025-05-16 12:43   ` Jürgen Groß
2025-05-17 13:00   ` [tip: x86/merge] " tip-bot2 for Kirill A. Shutemov
2025-05-16 13:11 ` [PATCHv3 0/4] x86: Make 5-level paging support unconditional for x86-64 Ingo Molnar
2025-05-16 13:17   ` Kirill A. Shutemov
2025-05-17  9:59 ` Borislav Petkov
2025-06-24  8:23 ` Khalid Ali [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-05-16  9:15 [PATCHv2 0/3] " Kirill A. Shutemov
2025-06-24  8:11 ` Khalid Ali
2025-06-24  8:22   ` H. Peter Anvin
2025-06-24  8:49   ` Kirill A. Shutemov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250624082305.2351-1-khaliidcaliy@gmail.com \
    --to=khaliidcaliy@gmail.com \
    --cc=ardb@kernel.org \
    --cc=bp@alien8.de \
    --cc=brijesh.singh@amd.com \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jgross@suse.com \
    --cc=kbingham@kernel.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@kernel.org \
    --cc=michael.roth@amd.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rick.p.edgecombe@intel.com \
    --cc=sandipan.das@amd.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).