* [PATCH] soundwire: Correct some property names
@ 2025-06-24 12:55 Charles Keepax
2025-06-26 20:57 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Charles Keepax @ 2025-06-24 12:55 UTC (permalink / raw)
To: vkoul
Cc: yung-chuan.liao, pierre-louis.bossart, peter.ujfalusi, patches,
linux-sound, linux-kernel
The DisCo properties should be mipi-sdw-paging-supported and
mipi-sdw-bank-delay-supported, with an 'ed' on the end. Correct the
property names used in sdw_slave_read_prop().
The internal flag bank_delay_support is currently unimplemented, so that
being read wrong does not currently affect anything. The two existing
users for this helper and the paging_support flag rt1320-sdw.c and
rt721-sdca-sdw.c both manually set the flag in their slave properties,
thus are not affected by this bug either.
Fixes: 56d4fe31af77 ("soundwire: Add MIPI DisCo property helpers")
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
drivers/soundwire/mipi_disco.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/mipi_disco.c b/drivers/soundwire/mipi_disco.c
index 65afb28ef8fab..c69b78cd0b620 100644
--- a/drivers/soundwire/mipi_disco.c
+++ b/drivers/soundwire/mipi_disco.c
@@ -451,10 +451,10 @@ int sdw_slave_read_prop(struct sdw_slave *slave)
"mipi-sdw-highPHY-capable");
prop->paging_support = mipi_device_property_read_bool(dev,
- "mipi-sdw-paging-support");
+ "mipi-sdw-paging-supported");
prop->bank_delay_support = mipi_device_property_read_bool(dev,
- "mipi-sdw-bank-delay-support");
+ "mipi-sdw-bank-delay-supported");
device_property_read_u32(dev,
"mipi-sdw-port15-read-behavior", &prop->p15_behave);
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] soundwire: Correct some property names
2025-06-24 12:55 [PATCH] soundwire: Correct some property names Charles Keepax
@ 2025-06-26 20:57 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2025-06-26 20:57 UTC (permalink / raw)
To: Charles Keepax
Cc: yung-chuan.liao, pierre-louis.bossart, peter.ujfalusi, patches,
linux-sound, linux-kernel
On Tue, 24 Jun 2025 13:55:07 +0100, Charles Keepax wrote:
> The DisCo properties should be mipi-sdw-paging-supported and
> mipi-sdw-bank-delay-supported, with an 'ed' on the end. Correct the
> property names used in sdw_slave_read_prop().
>
> The internal flag bank_delay_support is currently unimplemented, so that
> being read wrong does not currently affect anything. The two existing
> users for this helper and the paging_support flag rt1320-sdw.c and
> rt721-sdca-sdw.c both manually set the flag in their slave properties,
> thus are not affected by this bug either.
>
> [...]
Applied, thanks!
[1/1] soundwire: Correct some property names
commit: ae6a0f5b8a5b0ca2e4bf1c0380267ad83aca8401
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-26 20:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-24 12:55 [PATCH] soundwire: Correct some property names Charles Keepax
2025-06-26 20:57 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).