From: Alexey Romanov <romanov.alexey2000@gmail.com>
To: neil.armstrong@linaro.org, clabbe@baylibre.com,
herbert@gondor.apana.org.au, davem@davemloft.net,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com
Cc: linux-crypto@vger.kernel.org, linux-amlogic@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Alexey Romanov <romanov.alexey2000@gmail.com>
Subject: [PATCH v12 16/22] dt-bindings: crypto: amlogic,gxl-crypto: correct clk and interrupt lines
Date: Tue, 24 Jun 2025 16:52:08 +0300 [thread overview]
Message-ID: <20250624135214.1355051-17-romanov.alexey2000@gmail.com> (raw)
In-Reply-To: <20250624135214.1355051-1-romanov.alexey2000@gmail.com>
GXL and newer SoC's uses the DMA engine (not blkmv) for crypto HW.
Crypto HW doesn't actually use the blkmv clk. At RTL level, crypto
engine is hard-wired to a clk81 (CLKID_CLK81). Drop clock-names
field from schema: name "blkmv" is invalid and "clk81" is confusing
and sounds like something global.
Also, GXL crypto IP isn't connected to the second interrupt line.
This binding is useless, there are no users of this line.
We must remove it from dt-bindings.
Fixes: 7f7d115dfb51 ("dt-bindings: crypto: Add DT bindings documentation for amlogic-crypto")
Signed-off-by: Alexey Romanov <romanov.alexey2000@gmail.com>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
---
.../devicetree/bindings/crypto/amlogic,gxl-crypto.yaml | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml
index 948e11ebe4ee..fdc39797a2a9 100644
--- a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml
+++ b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml
@@ -20,20 +20,15 @@ properties:
interrupts:
items:
- description: Interrupt for flow 0
- - description: Interrupt for flow 1
clocks:
maxItems: 1
- clock-names:
- const: blkmv
-
required:
- compatible
- reg
- interrupts
- clocks
- - clock-names
additionalProperties: false
@@ -46,7 +41,6 @@ examples:
crypto: crypto-engine@c883e000 {
compatible = "amlogic,gxl-crypto";
reg = <0xc883e000 0x36>;
- interrupts = <GIC_SPI 188 IRQ_TYPE_EDGE_RISING>, <GIC_SPI 189 IRQ_TYPE_EDGE_RISING>;
- clocks = <&clkc CLKID_BLKMV>;
- clock-names = "blkmv";
+ interrupts = <GIC_SPI 188 IRQ_TYPE_EDGE_RISING>;
+ clocks = <&clkc CLKID_CLK81>;
};
--
2.34.1
next prev parent reply other threads:[~2025-06-24 13:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 13:51 [PATCH v12 00/22] Support more Amlogic SoC families in crypto driver Alexey Romanov
2025-06-24 13:51 ` [PATCH v12 01/22] crypto: amlogic - Don't hardcode IRQ count Alexey Romanov
2025-06-24 13:51 ` [PATCH v12 02/22] crypto: amlogic - Add platform data Alexey Romanov
2025-06-24 13:51 ` [PATCH v12 03/22] crypto: amlogic - Remove clock input Alexey Romanov
2025-06-24 13:51 ` [PATCH v12 04/22] crypto: amlogic - Add MMIO helpers Alexey Romanov
2025-06-24 13:51 ` [PATCH v12 05/22] crypto: amlogic - Move get_engine_number() Alexey Romanov
2025-06-24 13:51 ` [PATCH v12 06/22] crypto: amlogic - Drop status field from meson_flow Alexey Romanov
2025-06-24 13:51 ` [PATCH v12 07/22] crypto: amlogic - Move algs definition and cipher API to cipher.c Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 08/22] crypto: amlogic - Cleanup defines Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 09/22] crypto: amlogic - Process more than MAXDESCS descriptors Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 10/22] crypto: amlogic - Avoid kzalloc in engine thread Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 11/22] crypto: amlogic - Introduce hasher Alexey Romanov
2025-07-10 8:08 ` Herbert Xu
2025-06-24 13:52 ` [PATCH v12 12/22] crypto: amlogic - Use fallback for 192-bit keys Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 13/22] crypto: amlogic - Add support for G12-series Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 14/22] crypto: amlogic - Add support for AXG-series Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 15/22] crypto: amlogic - Add support for A1-series Alexey Romanov
2025-06-24 13:52 ` Alexey Romanov [this message]
2025-06-24 13:52 ` [PATCH v12 17/22] dt-bindings: crypto: amlogic,gxl-crypto: support new SoC's Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 18/22] arm64: dts: amlogic: gxl: correct crypto node definition Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 19/22] arm64: dts: amlogic: a1: add crypto node Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 20/22] arm64: dts: amlogic: s4: " Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 21/22] arm64: dts: amlogic: g12: " Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 22/22] arm64: dts: amlogic: axg: " Alexey Romanov
2025-07-03 5:47 ` [PATCH v12 00/22] Support more Amlogic SoC families in crypto driver Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250624135214.1355051-17-romanov.alexey2000@gmail.com \
--to=romanov.alexey2000@gmail.com \
--cc=clabbe@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).