From: Onur <work@onurozkan.dev>
To: "Benno Lossin" <lossin@kernel.org>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
<linux-kernel@vger.kernel.org>, <rust-for-linux@vger.kernel.org>,
<ojeda@kernel.org>, <alex.gaynor@gmail.com>, <gary@garyguo.net>,
<a.hindborg@kernel.org>, <aliceryhl@google.com>,
<tmgross@umich.edu>, <dakr@kernel.org>, <peterz@infradead.org>,
<mingo@redhat.com>, <will@kernel.org>, <longman@redhat.com>,
<felipe_life@live.com>, <daniel@sedlak.dev>,
<bjorn3_gh@protonmail.com>, <simona@ffwll.ch>,
<airlied@gmail.com>, <dri-devel@lists.freedesktop.org>,
<lyude@redhat.com>
Subject: Re: [PATCH v5 2/3] implement ww_mutex abstraction for the Rust tree
Date: Tue, 24 Jun 2025 15:31:02 +0300 [thread overview]
Message-ID: <20250624153102.3961f377@nimda.home> (raw)
In-Reply-To: <DAUM8B2ZUMFQ.25R95W7IDAEHM@kernel.org>
On Tue, 24 Jun 2025 10:20:48 +0200
"Benno Lossin" <lossin@kernel.org> wrote:
> On Tue Jun 24, 2025 at 7:34 AM CEST, Onur wrote:
> > Should we handle this in the initial implementation or leave it for
> > follow-up patches after the core abstraction of ww_mutex has landed?
>
> Since you're writing these abstractions specifically for usage in
> drm, I think we should look at the intended use-cases there and then
> decide on an API.
>
> So maybe Lyude or Dave can chime in :)
>
> If you (or someone else) have another user for this API that needs it
> ASAP, then we can think about merging this and improve it later. But
> if we don't have a user, then we shouldn't merge it anyways.
I don't think this is urgent, but it might be better to land the basic
structure first and improve it gradually I think? I would be happy to
continue working for the improvements as I don't plan to leave it as
just the initial version.
I worked on the v5 review notes, but if we are going to consider
designing a different API, then it doesn't make much sense to send a v6
patch before finishing the design, which requires additional people in
the topic. That would also mean some of the ongoing review discussion
would be wasted.
---
Regards,
Onur
next prev parent reply other threads:[~2025-06-24 12:39 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-21 18:44 [PATCH v5 0/3] rust: add `ww_mutex` support Onur Özkan
2025-06-21 18:44 ` [PATCH v5 1/3] rust: add C wrappers for `ww_mutex` inline functions Onur Özkan
2025-06-21 18:44 ` [PATCH v5 2/3] implement ww_mutex abstraction for the Rust tree Onur Özkan
2025-06-22 9:18 ` Benno Lossin
2025-06-23 13:04 ` Boqun Feng
2025-06-23 13:44 ` Benno Lossin
2025-06-23 14:47 ` Boqun Feng
2025-06-23 15:14 ` Benno Lossin
2025-06-23 17:11 ` Boqun Feng
2025-06-23 23:22 ` Benno Lossin
2025-06-24 5:34 ` Onur
2025-06-24 8:20 ` Benno Lossin
2025-06-24 12:31 ` Onur [this message]
2025-06-24 12:48 ` Benno Lossin
2025-07-07 13:39 ` Onur
2025-07-07 15:31 ` Benno Lossin
2025-07-07 18:06 ` Onur
2025-07-07 19:48 ` Benno Lossin
2025-07-08 14:21 ` Onur
2025-08-01 21:22 ` Daniel Almeida
2025-08-02 10:42 ` Benno Lossin
2025-08-02 13:41 ` Miguel Ojeda
2025-08-02 14:15 ` Daniel Almeida
2025-08-02 20:58 ` Benno Lossin
2025-08-05 15:18 ` Daniel Almeida
2025-08-05 9:08 ` Onur Özkan
2025-08-05 12:41 ` Daniel Almeida
2025-08-05 13:50 ` Onur Özkan
2025-06-23 11:51 ` Alice Ryhl
2025-06-23 13:26 ` Boqun Feng
2025-06-23 18:17 ` Onur
2025-06-23 21:54 ` Boqun Feng
2025-06-21 18:44 ` [PATCH v5 3/3] add KUnit coverage on Rust `ww_mutex` implementation Onur Özkan
2025-06-22 9:16 ` [PATCH v5 0/3] rust: add `ww_mutex` support Benno Lossin
2025-07-24 13:53 ` Onur Özkan
2025-07-29 17:15 ` Benno Lossin
2025-07-30 10:24 ` Onur Özkan
2025-07-30 10:55 ` Benno Lossin
2025-08-05 16:22 ` Lyude Paul
2025-08-05 17:56 ` Daniel Almeida
2025-08-06 5:57 ` Onur Özkan
2025-08-06 17:37 ` Lyude Paul
2025-08-06 19:30 ` Benno Lossin
2025-08-14 11:13 ` Onur Özkan
2025-08-14 12:38 ` Daniel Almeida
2025-08-14 15:56 ` Onur
2025-08-14 18:22 ` Daniel Almeida
2025-08-18 12:56 ` Onur Özkan
2025-09-01 10:05 ` Onur Özkan
2025-09-01 12:28 ` Daniel Almeida
2025-09-02 16:53 ` Onur
2025-09-03 6:24 ` Onur
2025-09-03 13:04 ` Daniel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250624153102.3961f377@nimda.home \
--to=work@onurozkan.dev \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel@sedlak.dev \
--cc=dri-devel@lists.freedesktop.org \
--cc=felipe_life@live.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=mingo@redhat.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).