From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
bpf@vger.kernel.org, x86@kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrii Nakryiko <andrii@kernel.org>,
Indu Bhagat <indu.bhagat@oracle.com>,
"Jose E. Marchesi" <jemarch@gnu.org>,
Beau Belgrave <beaub@linux.microsoft.com>,
Jens Remus <jremus@linux.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>
Subject: [PATCH v11 03/11] perf: Use current->flags & PF_KTHREAD instead of current->mm == NULL
Date: Wed, 25 Jun 2025 19:15:44 -0400 [thread overview]
Message-ID: <20250625231622.172100822@goodmis.org> (raw)
In-Reply-To: 20250625231541.584226205@goodmis.org
From: Steven Rostedt <rostedt@goodmis.org>
To determine if a task is a kernel thread or not, it is more reliable to
use (current->flags & PF_KTHREAD) than to rely on current->mm being NULL.
That is because some kernel tasks (io_uring helpers) may have a mm field.
Link: https://lore.kernel.org/linux-trace-kernel/20250424163607.GE18306@noisy.programming.kicks-ass.net/
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
kernel/events/callchain.c | 6 +++---
kernel/events/core.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/events/callchain.c b/kernel/events/callchain.c
index cd0e3fc7ed05..42d21761cb4d 100644
--- a/kernel/events/callchain.c
+++ b/kernel/events/callchain.c
@@ -246,10 +246,10 @@ get_perf_callchain(struct pt_regs *regs, bool kernel, bool user,
if (user && !crosstask) {
if (!user_mode(regs)) {
- if (current->mm)
- regs = task_pt_regs(current);
- else
+ if (current->flags & PF_KTHREAD)
regs = NULL;
+ else
+ regs = task_pt_regs(current);
}
if (regs) {
diff --git a/kernel/events/core.c b/kernel/events/core.c
index ca7e9e7d19bf..ae371007a2a6 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -8054,7 +8054,7 @@ static u64 perf_virt_to_phys(u64 virt)
* Try IRQ-safe get_user_page_fast_only first.
* If failed, leave phys_addr as 0.
*/
- if (current->mm != NULL) {
+ if (!(current->flags & PF_KTHREAD)) {
struct page *p;
pagefault_disable();
--
2.47.2
next prev parent reply other threads:[~2025-06-25 23:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 23:15 [PATCH v11 00/11] perf: Support the deferred unwinding infrastructure Steven Rostedt
2025-06-25 23:15 ` [PATCH v11 01/11] perf: Remove get_perf_callchain() init_nr argument Steven Rostedt
2025-06-25 23:15 ` [PATCH v11 02/11] perf: Have get_perf_callchain() return NULL if crosstask and user are set Steven Rostedt
2025-06-25 23:15 ` Steven Rostedt [this message]
2025-06-26 13:48 ` [PATCH v11 03/11] perf: Use current->flags & PF_KTHREAD instead of current->mm == NULL Jens Axboe
2025-06-26 14:11 ` Steven Rostedt
2025-06-25 23:15 ` [PATCH v11 04/11] perf: Simplify get_perf_callchain() user logic Steven Rostedt
2025-06-25 23:15 ` [PATCH v11 05/11] perf: Skip user unwind if the task is a kernel thread Steven Rostedt
2025-06-25 23:15 ` [PATCH v11 06/11] perf: Support deferred user callchains Steven Rostedt
2025-06-25 23:15 ` [PATCH v11 07/11] perf: Support deferred user callchains for per CPU events Steven Rostedt
2025-06-25 23:15 ` [PATCH v11 08/11] perf tools: Minimal CALLCHAIN_DEFERRED support Steven Rostedt
2025-06-25 23:15 ` [PATCH v11 09/11] perf record: Enable defer_callchain for user callchains Steven Rostedt
2025-06-25 23:15 ` [PATCH v11 10/11] perf script: Display PERF_RECORD_CALLCHAIN_DEFERRED Steven Rostedt
2025-06-25 23:15 ` [PATCH v11 11/11] perf tools: Merge deferred user callchains Steven Rostedt
2025-06-26 14:49 ` [PATCH v11 00/11] perf: Support the deferred unwinding infrastructure Steven Rostedt
2025-06-26 14:50 ` [PATCH v11 10/11] perf script: Display PERF_RECORD_CALLCHAIN_DEFERRED Steven Rostedt
2025-06-26 14:51 ` [PATCH v11 11/11] perf tools: Merge deferred user callchains Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250625231622.172100822@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=axboe@kernel.dk \
--cc=beaub@linux.microsoft.com \
--cc=bpf@vger.kernel.org \
--cc=indu.bhagat@oracle.com \
--cc=jemarch@gnu.org \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=jremus@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).