linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/1] x86/defconfigs: Explicitly unset CONFIG_64BIT in i386_defconfig
@ 2025-06-26 15:00 Andy Shevchenko
  2025-07-10 17:11 ` Andy Shevchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2025-06-26 15:00 UTC (permalink / raw)
  To: Ingo Molnar, linux-kernel
  Cc: Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen, x86,
	H. Peter Anvin, Andy Shevchenko

A recent refresh of the defconfigs got rid of the following
(unset) configuration option:

  # CONFIG_64BIT is not set

Innocuous as it seems, when the configuration file is saved again
the behavior is changed so that CONFIG_64BIT=y.

Currently,

  $ make i386_defconfig
  $ grep CONFIG_64BIT .config
  CONFIG_64BIT=y

whereas previously (and with this patch):

  $ make i386_defconfig
  $ grep CONFIG_64BIT .config
  # CONFIG_64BIT is not set

This was found by cross-compilation of the 32-bit kernel on 64-bit machine
with the result of non-bootable kernel on Intel Galileo Gen 2 board.

Restore the missing explicitly unset CONFIG_64BIT in 32-bit defconfig.

Fixes: 0e11f689ec03 ("x86/kconfig/32: Refresh defconfig")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

v2: fixed the authorship and amended the commit message (Boris)

 arch/x86/configs/i386_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/configs/i386_defconfig b/arch/x86/configs/i386_defconfig
index bd182325ebb4..9fc5c2eb58af 100644
--- a/arch/x86/configs/i386_defconfig
+++ b/arch/x86/configs/i386_defconfig
@@ -28,6 +28,7 @@ CONFIG_BLK_DEV_INITRD=y
 CONFIG_KALLSYMS_ALL=y
 CONFIG_PROFILING=y
 CONFIG_KEXEC=y
+# CONFIG_64BIT is not set
 CONFIG_SMP=y
 CONFIG_HYPERVISOR_GUEST=y
 CONFIG_PARAVIRT=y
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/1] x86/defconfigs: Explicitly unset CONFIG_64BIT in i386_defconfig
  2025-06-26 15:00 [PATCH v2 1/1] x86/defconfigs: Explicitly unset CONFIG_64BIT in i386_defconfig Andy Shevchenko
@ 2025-07-10 17:11 ` Andy Shevchenko
  2025-07-14 14:29   ` Borislav Petkov
  0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2025-07-10 17:11 UTC (permalink / raw)
  To: Ingo Molnar, linux-kernel
  Cc: Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen, x86,
	H. Peter Anvin

On Thu, Jun 26, 2025 at 06:00:34PM +0300, Andy Shevchenko wrote:
> A recent refresh of the defconfigs got rid of the following
> (unset) configuration option:
> 
>   # CONFIG_64BIT is not set
> 
> Innocuous as it seems, when the configuration file is saved again
> the behavior is changed so that CONFIG_64BIT=y.
> 
> Currently,
> 
>   $ make i386_defconfig
>   $ grep CONFIG_64BIT .config
>   CONFIG_64BIT=y
> 
> whereas previously (and with this patch):
> 
>   $ make i386_defconfig
>   $ grep CONFIG_64BIT .config
>   # CONFIG_64BIT is not set
> 
> This was found by cross-compilation of the 32-bit kernel on 64-bit machine
> with the result of non-bootable kernel on Intel Galileo Gen 2 board.
> 
> Restore the missing explicitly unset CONFIG_64BIT in 32-bit defconfig.

Can it be applied now?

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/1] x86/defconfigs: Explicitly unset CONFIG_64BIT in i386_defconfig
  2025-07-10 17:11 ` Andy Shevchenko
@ 2025-07-14 14:29   ` Borislav Petkov
  2025-07-14 15:31     ` Andy Shevchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Borislav Petkov @ 2025-07-14 14:29 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Ingo Molnar, linux-kernel, Thomas Gleixner, Ingo Molnar,
	Dave Hansen, x86, H. Peter Anvin

On Thu, Jul 10, 2025 at 08:11:07PM +0300, Andy Shevchenko wrote:
> Can it be applied now?

I've merged it into the commit in Fixes:

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/kconfig&id=6453e7cc32d1fd69344311224dbd00692eadc592

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/1] x86/defconfigs: Explicitly unset CONFIG_64BIT in i386_defconfig
  2025-07-14 14:29   ` Borislav Petkov
@ 2025-07-14 15:31     ` Andy Shevchenko
  0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2025-07-14 15:31 UTC (permalink / raw)
  To: Borislav Petkov
  Cc: Ingo Molnar, linux-kernel, Thomas Gleixner, Ingo Molnar,
	Dave Hansen, x86, H. Peter Anvin

On Mon, Jul 14, 2025 at 04:29:57PM +0200, Borislav Petkov wrote:
> On Thu, Jul 10, 2025 at 08:11:07PM +0300, Andy Shevchenko wrote:
> > Can it be applied now?
> 
> I've merged it into the commit in Fixes:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/kconfig&id=6453e7cc32d1fd69344311224dbd00692eadc592

Thank you!

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-07-14 15:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-26 15:00 [PATCH v2 1/1] x86/defconfigs: Explicitly unset CONFIG_64BIT in i386_defconfig Andy Shevchenko
2025-07-10 17:11 ` Andy Shevchenko
2025-07-14 14:29   ` Borislav Petkov
2025-07-14 15:31     ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).