From: Dylan Yudaken <dyudaken@gmail.com>
To: mathieu.desnoyers@efficios.com, paulmck@kernel.org
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, shuah@kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Dylan Yudaken <dyudaken@gmail.com>
Subject: [PATCH 1/2] membarrier: allow cpu_id to be set on more commands
Date: Thu, 26 Jun 2025 16:52:56 +0100 [thread overview]
Message-ID: <20250626155257.81256-2-dyudaken@gmail.com> (raw)
In-Reply-To: <20250626155257.81256-1-dyudaken@gmail.com>
No reason to not allow MEMBARRIER_CMD_FLAG_CPU on
MEMBARRIER_CMD_PRIVATE_EXPEDITED or
MEMBARRIER_CMD_PRIVATE_EXPEDITED_SYNC_CORE.
If it is known specifically what cpu you want to interrupt then there
is a decent efficiency saving in not interrupting all the other ones.
Also - the code already works as is for them.
Signed-off-by: Dylan Yudaken <dyudaken@gmail.com>
---
kernel/sched/membarrier.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/membarrier.c b/kernel/sched/membarrier.c
index 809194cd779f..def6d4094ad6 100644
--- a/kernel/sched/membarrier.c
+++ b/kernel/sched/membarrier.c
@@ -595,7 +595,9 @@ static int membarrier_get_registrations(void)
* contains the CPU on which to interrupt (= restart)
* the RSEQ critical section.
* @cpu_id: if @flags == MEMBARRIER_CMD_FLAG_CPU, indicates the cpu on which
- * RSEQ CS should be interrupted (@cmd must be
+ * RSEQ CS should be interrupted (@cmd must be one of
+ * MEMBARRIER_CMD_PRIVATE_EXPEDITED,
+ * MEMBARRIER_CMD_PRIVATE_EXPEDITED_SYNC_CORE,
* MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ).
*
* If this system call is not implemented, -ENOSYS is returned. If the
@@ -625,6 +627,8 @@ static int membarrier_get_registrations(void)
SYSCALL_DEFINE3(membarrier, int, cmd, unsigned int, flags, int, cpu_id)
{
switch (cmd) {
+ case MEMBARRIER_CMD_PRIVATE_EXPEDITED:
+ case MEMBARRIER_CMD_PRIVATE_EXPEDITED_SYNC_CORE:
case MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ:
if (unlikely(flags && flags != MEMBARRIER_CMD_FLAG_CPU))
return -EINVAL;
--
2.49.0
next prev parent reply other threads:[~2025-06-26 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 15:52 [PATCH 0/2] membarrier: allow cpu_id to be set on more commands Dylan Yudaken
2025-06-26 15:52 ` Dylan Yudaken [this message]
2025-06-26 16:07 ` [PATCH 1/2] " Mathieu Desnoyers
2025-06-26 18:30 ` Dylan
2025-06-26 15:52 ` [PATCH 2/2] membarrier: self test for cpu specific calls Dylan Yudaken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250626155257.81256-2-dyudaken@gmail.com \
--to=dyudaken@gmail.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).