* [PATCH v1 1/1] mfd: wm8350-core: Don't use "proxy" headers
@ 2025-06-26 15:59 Andy Shevchenko
2025-06-27 15:42 ` Charles Keepax
2025-07-02 15:27 ` (subset) " Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2025-06-26 15:59 UTC (permalink / raw)
To: Andy Shevchenko, patches, linux-kernel; +Cc: Lee Jones
Update header inclusions to follow IWYU (Include What You Use)
principle.
Note that kernel.h is discouraged to be included as it's written
at the top of that file.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/mfd/wm8350/core.h | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/include/linux/mfd/wm8350/core.h b/include/linux/mfd/wm8350/core.h
index a3241e4d7548..5f70d3b5d1b1 100644
--- a/include/linux/mfd/wm8350/core.h
+++ b/include/linux/mfd/wm8350/core.h
@@ -8,11 +8,12 @@
#ifndef __LINUX_MFD_WM8350_CORE_H_
#define __LINUX_MFD_WM8350_CORE_H_
-#include <linux/kernel.h>
-#include <linux/mutex.h>
-#include <linux/interrupt.h>
#include <linux/completion.h>
+#include <linux/errno.h>
+#include <linux/interrupt.h>
+#include <linux/mutex.h>
#include <linux/regmap.h>
+#include <linux/types.h>
#include <linux/mfd/wm8350/audio.h>
#include <linux/mfd/wm8350/gpio.h>
@@ -21,6 +22,9 @@
#include <linux/mfd/wm8350/supply.h>
#include <linux/mfd/wm8350/wdt.h>
+struct device;
+struct platform_device;
+
/*
* Register values.
*/
--
2.47.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] mfd: wm8350-core: Don't use "proxy" headers
2025-06-26 15:59 [PATCH v1 1/1] mfd: wm8350-core: Don't use "proxy" headers Andy Shevchenko
@ 2025-06-27 15:42 ` Charles Keepax
2025-07-02 15:27 ` (subset) " Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Charles Keepax @ 2025-06-27 15:42 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: patches, linux-kernel, Lee Jones
On Thu, Jun 26, 2025 at 06:59:51PM +0300, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Note that kernel.h is discouraged to be included as it's written
> at the top of that file.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: (subset) [PATCH v1 1/1] mfd: wm8350-core: Don't use "proxy" headers
2025-06-26 15:59 [PATCH v1 1/1] mfd: wm8350-core: Don't use "proxy" headers Andy Shevchenko
2025-06-27 15:42 ` Charles Keepax
@ 2025-07-02 15:27 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2025-07-02 15:27 UTC (permalink / raw)
To: patches, linux-kernel, Andy Shevchenko; +Cc: Lee Jones
On Thu, 26 Jun 2025 18:59:51 +0300, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Note that kernel.h is discouraged to be included as it's written
> at the top of that file.
>
>
> [...]
Applied, thanks!
[1/1] mfd: wm8350-core: Don't use "proxy" headers
commit: 4fe2e96c88afde2f06485f90b7b01e2a45eb99e4
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-02 15:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-26 15:59 [PATCH v1 1/1] mfd: wm8350-core: Don't use "proxy" headers Andy Shevchenko
2025-06-27 15:42 ` Charles Keepax
2025-07-02 15:27 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).