* [PATCH v2 1/1] mfd: syscon: atmel-smc: Don't use "proxy" headers
@ 2025-06-27 16:43 Andy Shevchenko
2025-07-02 15:35 ` (subset) " Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2025-06-27 16:43 UTC (permalink / raw)
To: Andy Shevchenko, linux-arm-kernel, linux-kernel
Cc: Lee Jones, Nicolas Ferre, Alexandre Belloni, Claudiu Beznea
Update header inclusions to follow IWYU (Include What You Use)
principle.
Note that kernel.h is discouraged to be included as it's written
at the top of that file.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: fixed multiple compilation errors (LKP)
drivers/mfd/atmel-smc.c | 9 ++++++++-
include/linux/mfd/syscon/atmel-smc.h | 8 +++++---
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/mfd/atmel-smc.c b/drivers/mfd/atmel-smc.c
index 4628ca14e766..0a5b42c83f17 100644
--- a/drivers/mfd/atmel-smc.c
+++ b/drivers/mfd/atmel-smc.c
@@ -8,9 +8,16 @@
* Author: Boris Brezillon <boris.brezillon@free-electrons.com>
*/
-#include <linux/mfd/syscon/atmel-smc.h>
+#include <linux/bits.h>
+#include <linux/err.h>
+#include <linux/export.h>
+#include <linux/mod_devicetable.h>
+#include <linux/of.h>
+#include <linux/regmap.h>
#include <linux/string.h>
+#include <linux/mfd/syscon/atmel-smc.h>
+
/**
* atmel_smc_cs_conf_init - initialize a SMC CS conf
* @conf: the SMC CS conf to initialize
diff --git a/include/linux/mfd/syscon/atmel-smc.h b/include/linux/mfd/syscon/atmel-smc.h
index e9e24f4c4578..9b9119c742a2 100644
--- a/include/linux/mfd/syscon/atmel-smc.h
+++ b/include/linux/mfd/syscon/atmel-smc.h
@@ -11,9 +11,11 @@
#ifndef _LINUX_MFD_SYSCON_ATMEL_SMC_H_
#define _LINUX_MFD_SYSCON_ATMEL_SMC_H_
-#include <linux/kernel.h>
-#include <linux/of.h>
-#include <linux/regmap.h>
+#include <linux/bits.h>
+#include <linux/types.h>
+
+struct device_node;
+struct regmap;
#define ATMEL_SMC_SETUP(cs) (((cs) * 0x10))
#define ATMEL_HSMC_SETUP(layout, cs) \
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: (subset) [PATCH v2 1/1] mfd: syscon: atmel-smc: Don't use "proxy" headers
2025-06-27 16:43 [PATCH v2 1/1] mfd: syscon: atmel-smc: Don't use "proxy" headers Andy Shevchenko
@ 2025-07-02 15:35 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2025-07-02 15:35 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, Andy Shevchenko
Cc: Lee Jones, Nicolas Ferre, Alexandre Belloni, Claudiu Beznea
On Fri, 27 Jun 2025 19:43:58 +0300, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Note that kernel.h is discouraged to be included as it's written
> at the top of that file.
>
>
> [...]
Applied, thanks!
[1/1] mfd: syscon: atmel-smc: Don't use "proxy" headers
commit: e1411d38da67e53a25aee615c3e5320d373ef741
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-02 15:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-27 16:43 [PATCH v2 1/1] mfd: syscon: atmel-smc: Don't use "proxy" headers Andy Shevchenko
2025-07-02 15:35 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).