Re: [PATCH v6 9/9] PCI: Add a new 'boot_display' attribute

[kernel test robot <lkp@intel.com>]

Hi Mario,

kernel test robot noticed the following build errors:

[auto build test ERROR on pci/next]
[also build test ERROR on pci/for-linus tiwai-sound/for-next tiwai-sound/for-linus tip/x86/core linus/master v6.16-rc3 next-20250627]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/PCI-Add-helper-for-checking-if-a-PCI-device-is-a-display-controller/20250627-123349
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20250627043108.3141206-10-superm1%40kernel.org
patch subject: [PATCH v6 9/9] PCI: Add a new 'boot_display' attribute
config: arc-randconfig-001-20250628 (https://download.01.org/0day-ci/archive/20250628/202506281332.JQb144bv-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250628/202506281332.JQb144bv-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506281332.JQb144bv-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/pci/pci-sysfs.c: In function 'pci_create_sysfs_dev_files':
>> drivers/pci/pci-sysfs.c:1701:11: error: implicit declaration of function 'pci_create_boot_display_file'; did you mean 'pci_create_sysfs_dev_files'? [-Werror=implicit-function-declaration]
     retval = pci_create_boot_display_file(pdev);
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
              pci_create_sysfs_dev_files
   drivers/pci/pci-sysfs.c: In function 'pci_remove_sysfs_dev_files':
>> drivers/pci/pci-sysfs.c:1719:2: error: implicit declaration of function 'pci_remove_boot_display_file'; did you mean 'pci_remove_sysfs_dev_files'? [-Werror=implicit-function-declaration]
     pci_remove_boot_display_file(pdev);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
     pci_remove_sysfs_dev_files
   In file included from include/linux/pci.h:37,
                    from drivers/pci/pci-sysfs.c:19:
   At top level:
>> include/linux/device.h:199:26: warning: 'dev_attr_boot_display' defined but not used [-Wunused-variable]
     struct device_attribute dev_attr_##_name = __ATTR_RO(_name)
                             ^~~~~~~~~
   drivers/pci/pci-sysfs.c:688:8: note: in expansion of macro 'DEVICE_ATTR_RO'
    static DEVICE_ATTR_RO(boot_display);
           ^~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +1701 drivers/pci/pci-sysfs.c

  1693	
  1694	int __must_check pci_create_sysfs_dev_files(struct pci_dev *pdev)
  1695	{
  1696		int retval;
  1697	
  1698		if (!sysfs_initialized)
  1699			return -EACCES;
  1700	
> 1701		retval = pci_create_boot_display_file(pdev);
  1702		if (retval)
  1703			return retval;
  1704	
  1705		return pci_create_resource_files(pdev);
  1706	}
  1707	
  1708	/**
  1709	 * pci_remove_sysfs_dev_files - cleanup PCI specific sysfs files
  1710	 * @pdev: device whose entries we should free
  1711	 *
  1712	 * Cleanup when @pdev is removed from sysfs.
  1713	 */
  1714	void pci_remove_sysfs_dev_files(struct pci_dev *pdev)
  1715	{
  1716		if (!sysfs_initialized)
  1717			return;
  1718	
> 1719		pci_remove_boot_display_file(pdev);
  1720		pci_remove_resource_files(pdev);
  1721	}
  1722	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki