* [PATCH] net: stmmac: add support for dwmac 5.20
@ 2025-06-29 9:44 Jisheng Zhang
2025-06-29 18:26 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Jisheng Zhang @ 2025-06-29 9:44 UTC (permalink / raw)
To: Andrew Lunn, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Maxime Coquelin, Alexandre Torgue
Cc: netdev, linux-arm-kernel, linux-kernel
The dwmac 5.20 IP can be found on some synaptics SoCs. Add a
compatibility flag, and extend coverage of the dwmac-generic driver
for the 5.20 IP.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
index b9218c07eb6b..cecce6ed9aa6 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
@@ -59,6 +59,7 @@ static const struct of_device_id dwmac_generic_match[] = {
{ .compatible = "snps,dwmac-3.72a"},
{ .compatible = "snps,dwmac-4.00"},
{ .compatible = "snps,dwmac-4.10a"},
+ { .compatible = "snps,dwmac-5.20"},
{ .compatible = "snps,dwmac"},
{ .compatible = "snps,dwxgmac-2.10"},
{ .compatible = "snps,dwxgmac"},
--
2.49.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: stmmac: add support for dwmac 5.20
2025-06-29 9:44 [PATCH] net: stmmac: add support for dwmac 5.20 Jisheng Zhang
@ 2025-06-29 18:26 ` Andrew Lunn
2025-06-30 2:16 ` Yanteng Si
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2025-06-29 18:26 UTC (permalink / raw)
To: Jisheng Zhang
Cc: Andrew Lunn, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Maxime Coquelin, Alexandre Torgue, netdev,
linux-arm-kernel, linux-kernel
On Sun, Jun 29, 2025 at 05:44:25PM +0800, Jisheng Zhang wrote:
> The dwmac 5.20 IP can be found on some synaptics SoCs. Add a
> compatibility flag, and extend coverage of the dwmac-generic driver
> for the 5.20 IP.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
> index b9218c07eb6b..cecce6ed9aa6 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
> @@ -59,6 +59,7 @@ static const struct of_device_id dwmac_generic_match[] = {
> { .compatible = "snps,dwmac-3.72a"},
> { .compatible = "snps,dwmac-4.00"},
> { .compatible = "snps,dwmac-4.10a"},
> + { .compatible = "snps,dwmac-5.20"},
> { .compatible = "snps,dwmac"},
> { .compatible = "snps,dwxgmac-2.10"},
> { .compatible = "snps,dwxgmac"},
I can see a compatible flag being added. But what about the extending
the coverage of the dwmac-generic driver part?
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: stmmac: add support for dwmac 5.20
2025-06-29 18:26 ` Andrew Lunn
@ 2025-06-30 2:16 ` Yanteng Si
0 siblings, 0 replies; 3+ messages in thread
From: Yanteng Si @ 2025-06-30 2:16 UTC (permalink / raw)
To: Andrew Lunn, Jisheng Zhang
Cc: Andrew Lunn, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Maxime Coquelin, Alexandre Torgue, netdev,
linux-arm-kernel, linux-kernel
在 6/30/25 2:26 AM, Andrew Lunn 写道:
> On Sun, Jun 29, 2025 at 05:44:25PM +0800, Jisheng Zhang wrote:
>> The dwmac 5.20 IP can be found on some synaptics SoCs. Add a
>> compatibility flag, and extend coverage of the dwmac-generic driver
>> for the 5.20 IP.
>>
>> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
>> ---
>> drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
>> index b9218c07eb6b..cecce6ed9aa6 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
>> @@ -59,6 +59,7 @@ static const struct of_device_id dwmac_generic_match[] = {
>> { .compatible = "snps,dwmac-3.72a"},
>> { .compatible = "snps,dwmac-4.00"},
>> { .compatible = "snps,dwmac-4.10a"},
>> + { .compatible = "snps,dwmac-5.20"},
>> { .compatible = "snps,dwmac"},
>> { .compatible = "snps,dwxgmac-2.10"},
>> { .compatible = "snps,dwxgmac"},
>
> I can see a compatible flag being added. But what about the extending
> the coverage of the dwmac-generic driver part?
I don't think the timing is ripe yet (including the patch itself).
Maybe it would be better to do this when a hardware driver is to
be introduced into the kernel.
Thanks,
Yanteng
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-30 2:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-29 9:44 [PATCH] net: stmmac: add support for dwmac 5.20 Jisheng Zhang
2025-06-29 18:26 ` Andrew Lunn
2025-06-30 2:16 ` Yanteng Si
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).