From: Simon Horman <horms@kernel.org>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: sgoutham@marvell.com, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: thunderx: avoid direct MTU assignment after WRITE_ONCE()
Date: Mon, 30 Jun 2025 12:18:36 +0100 [thread overview]
Message-ID: <20250630111836.GE41770@horms.kernel.org> (raw)
In-Reply-To: <20250629051540.518216-1-alok.a.tiwari@oracle.com>
On Sat, Jun 28, 2025 at 10:15:37PM -0700, Alok Tiwari wrote:
...
> @@ -1589,16 +1588,18 @@ static int nicvf_change_mtu(struct net_device *netdev, int new_mtu)
> return -EINVAL;
> }
>
> - WRITE_ONCE(netdev->mtu, new_mtu);
>
> - if (!netif_running(netdev))
> + if (!netif_running(netdev)) {
> + WRITE_ONCE(netdev->mtu, new_mtu);
> return 0;
> + }
>
> if (nicvf_update_hw_max_frs(nic, new_mtu)) {
> - netdev->mtu = orig_mtu;
> return -EINVAL;
> }
nit: curly brackets should be removed here, but see further comment below.
>
> + WRITE_ONCE(netdev->mtu, new_mtu);
> +
> return 0;
> }
Could this be more succinctly expressed as follows?
(Completely untested!)
if (netif_running(netdev) && nicvf_update_hw_max_frs(nic, new_mtu))
return -ENIVAL;
WRITE_ONCE(netdev->mtu, new_mtu);
return 0;
prev parent reply other threads:[~2025-06-30 11:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-29 5:15 [PATCH net v2] net: thunderx: avoid direct MTU assignment after WRITE_ONCE() Alok Tiwari
2025-06-30 11:18 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250630111836.GE41770@horms.kernel.org \
--to=horms@kernel.org \
--cc=alok.a.tiwari@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox