Re: [PATCH v5 01/14] sched/debug: Fix updating of ppos on server write ops

Tejun Heo
2025-06-23T20:14:41Z

On Fri, Jun 20, 2025 at 04:32:16PM -0400, Joel Fernandes wrote:
> Updating "ppos" on error conditions does not make much sense. The pattern
> is to return the error code directly without modifying the position, or
> modify the position on success and return the number of bytes written.
>
> Since on success, the return value of apply is 0, there is no point in
> modifying ppos either. Fix it by removing all this and just returning
> error code or number of bytes written on success.
>
> Reviewed-by: Andrea Righi <arighi@nvidia.com>
> Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

--
tejun