Re: [PATCH v5 09/14] sched/debug: Add support to change sched_ext server params

Joel Fernandes
2025-06-30T15:26:20Z

Hi Tejun,

On Mon, Jun 23, 2025 at 12:12:32 -1000, Tejun Heo wrote:
> On Fri, Jun 20, 2025 at 04:32:24PM -0400, Joel Fernandes wrote:
> ...
> > - if (!runtime)
> > - printk_deferred("Fair server disabled in CPU %d, system may crash due to starvation.\n",
> > - cpu_of(rq));
> > + if (!runtime) {
> > + if (server == &rq->fair_server)
> > + printk_deferred("Fair server disabled on CPU %d, system may crash due to starvation.\n",
> > + cpu_of(rq));
> > + else
> > + printk_deferred("Ext server disabled on CPU %d, system may crash due to starvation.\n",
> > + cpu_of(rq));
>
> It's minor but the above is a bit ugly. Maybe pass in the name as an arg or
> put it in dl_se?

Thanks, I changed it to the following for the next revision, which is
indeed cleaner:

printk_deferred("%s server disabled on CPU %d, system may crash due to starvation.\n",
server == &rq->fair_server ? "Fair" : "Ext", cpu_of(rq));

thanks,

- Joel