From: Joel Fernandes <joelagnelf@nvidia.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
David Vernet <void@manifault.com>,
Andrea Righi <arighi@nvidia.com>,
Changwoo Min <changwoo@igalia.com>
Subject: Re: [PATCH v5 05/14] sched/deadline: Return EBUSY if dl_bw_cpus is zero
Date: Mon, 30 Jun 2025 10:50:22 -0400 [thread overview]
Message-ID: <20250630145022.GA2440438@joelnvbox> (raw)
In-Reply-To: <aFm28aLvL0Lu7LuH@slm.duckdns.org>
On Mon, Jun 23, 2025 at 10:20:01AM -1000, Tejun Heo wrote:
> On Fri, Jun 20, 2025 at 04:32:20PM -0400, Joel Fernandes wrote:
> > - if (__dl_overflow(dl_b, cap, old_bw, new_bw))
> > + // Hotplugged CPUs coming online do an enqueue but are not a part of any
> > + // root domain containing cpu_active() CPUs. So in this case, don't mess
> > + // with accounting and we can retry later.
> > + if (!cpus || __dl_overflow(dl_b, cap, old_bw, new_bw))
> > return -EBUSY;
>
> Maybe match the comment style in the file?
>
> Thanks.
>
> --
> tejun
Agreed, will fix. Thanks!
- Joel
next prev parent reply other threads:[~2025-06-30 14:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 20:32 [PATCH v5 00/14] Add a deadline server for sched_ext tasks Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 01/14] sched/debug: Fix updating of ppos on server write ops Joel Fernandes
2025-06-23 20:14 ` Tejun Heo
2025-06-20 20:32 ` [PATCH v5 02/14] sched/debug: Stop and start server based on if it was active Joel Fernandes
2025-06-23 20:16 ` Tejun Heo
2025-06-30 14:11 ` Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 03/14] sched/deadline: Clear the defer params Joel Fernandes
2025-06-23 20:17 ` Tejun Heo
2025-06-30 14:30 ` Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 04/14] sched/deadline: Prevent setting server as started if params couldn't be applied Joel Fernandes
2025-06-25 12:56 ` Juri Lelli
2025-06-30 14:45 ` Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 05/14] sched/deadline: Return EBUSY if dl_bw_cpus is zero Joel Fernandes
2025-06-23 20:20 ` Tejun Heo
2025-06-30 14:50 ` Joel Fernandes [this message]
2025-06-20 20:32 ` [PATCH v5 06/14] sched: Add support to pick functions to take rf Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 07/14] sched: Add a server arg to dl_server_update_idle_time() Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 08/14] sched/ext: Add a DL server for sched_ext tasks Joel Fernandes
2025-06-23 22:11 ` Tejun Heo
2025-06-30 15:12 ` Joel Fernandes
2025-06-30 15:38 ` Tejun Heo
2025-07-01 13:23 ` Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 09/14] sched/debug: Add support to change sched_ext server params Joel Fernandes
2025-06-23 22:12 ` Tejun Heo
2025-06-30 15:26 ` Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 10/14] sched/deadline: Add support to remove DLserver's bandwidth contribution Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 11/14] sched/ext: Relinquish DL server reservations when not needed Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 12/14] selftests/sched_ext: Add test for sched_ext dl_server Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 13/14] sched/deadline: Fix DL server crash in inactive_timer callback Joel Fernandes
2025-06-20 20:32 ` [PATCH v5 14/14] selftests/sched_ext: Add test for DL server total_bw consistency Joel Fernandes
2025-06-20 20:44 ` [PATCH v5 00/14] Add a deadline server for sched_ext tasks Joel Fernandes
2025-06-23 22:15 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250630145022.GA2440438@joelnvbox \
--to=joelagnelf@nvidia.com \
--cc=arighi@nvidia.com \
--cc=bsegall@google.com \
--cc=changwoo@igalia.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=void@manifault.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).