From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC25628CF40; Mon, 30 Jun 2025 16:06:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751299602; cv=none; b=JZk7Y4Rml8X/NqwDQlkO5IIJ76IMl7TXQCmxKjyVzsd+ZjvSVCOhr0H7jVyrgi6j/Z6HILP4Y3iFstzpesyUCWeCubiZ/gR4VHjGez0uX5/cxxOuJOKc0W3tIR9ekkHEXMOxcPOAIuUsup8y1NLnHUyUhHXzTh6TCgUAyILfq1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751299602; c=relaxed/simple; bh=K04c3OVn55WWIJlwhBX8hHaUfgghWX+cT61EBJ8XJqE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=e30IC65mHwrqhVUOGlAIDoSk9W7elKFDSymsr9LKsRbz6fjjULaGFgim21Z1AM/37RdZ+yK/cy0bsDXzFbwcgC+AddyNAoVtsAakClUKqDx7vY7g5nRPIvJHrUXVHf6V91i8MEESeRPmfHSyzeA/jLOtLBNIRnI0AFACtYL0mLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=bwOAFjzz; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="bwOAFjzz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1751299596; bh=K04c3OVn55WWIJlwhBX8hHaUfgghWX+cT61EBJ8XJqE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bwOAFjzzr2QVs2HFWx9HxAfk2c9HX14sFJU3T8ka5rk4z1+4SpnJzM7VtHPpkD5Wn jRWeMVD078cSgP2z1A8zZaIjyKdQdi8zrR0HVvBXdTqL8R3Dbfj8KP8pzDC0j5bPPb Bzf83c4xnJ35dBanw1DOCdYX94Zie4Pjj5R4qPM04+zmo9wZd/KtaLcbcL3f/3YY5C 5CccLKCUQ7ibuLD1zv0QDrcWvnQJ0VlCc0k1/QhAsuO4BJEosr/mUB42xsDnSc5e9W ZvQqQJ7sQuW/T4eyAXG0KcLlF1Thy6kbovogGTkaxIrepvuA4NFd4fAaUA3wiQbRBB cBfAnxD7dpmTg== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:16f1:973:959b:9b0c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id C052017E09C6; Mon, 30 Jun 2025 18:06:35 +0200 (CEST) Date: Mon, 30 Jun 2025 18:06:31 +0200 From: Boris Brezillon To: Danilo Krummrich Cc: Daniel Almeida , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?B?QmrDtnJu?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Daniel Stone , Rob Herring , Alice Ryhl , Beata Michalska , Carsten Haitzler , Ashley Smith , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH] Introduce Tyr Message-ID: <20250630180631.5e8066cd@fedora> In-Reply-To: References: <20250627-tyr-v1-1-cb5f4c6ced46@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 28 Jun 2025 01:12:34 +0200 Danilo Krummrich wrote: > > + pub(crate) fn log(&self, pdev: &platform::Device) { > > + let major = (self.gpu_id >> 16) & 0xff; > > + let minor = (self.gpu_id >> 8) & 0xff; > > + let status = self.gpu_id & 0xff; > > + > > + let model_name = if let Some(model) = GPU_MODELS > > + .iter() > > + .find(|&f| f.major == major && f.minor == minor) > > + { > > + model.name > > + } else { > > + "unknown" > > + }; > > + > > + dev_info!( > > + pdev.as_ref(), > > + "mali-{} id 0x{:x} major 0x{:x} minor 0x{:x} status 0x{:x}", > > + model_name, > > + self.gpu_id >> 16, > > + major, > > + minor, > > + status > > + ); > > + > > + dev_info!( > > + pdev.as_ref(), > > + "Features: L2:{:#x} Tiler:{:#x} Mem:{:#x} MMU:{:#x} AS:{:#x}", > > + self.l2_features, > > + self.tiler_features, > > + self.mem_features, > > + self.mmu_features, > > + self.as_present > > + ); > > + > > + dev_info!( > > + pdev.as_ref(), > > + "shader_present=0x{:016x} l2_present=0x{:016x} tiler_present=0x{:016x}", > > + self.shader_present, > > + self.l2_present, > > + self.tiler_present > > + ); > > + > > + dev_info!( > > + pdev.as_ref(), > > + "PA bits: {}, VA bits: {}", > > + self.pa_bits(), > > + self.va_bits() > > + ); > > + } > > This is called from probe() and seems way too verbose for dev_info!(), please > use dev_dbg!() instead. We do have the same level of verbosity in Panthor, and it's proven useful when people are filling bug reports. Asking them to reload the module with debug prints enabled is kinda annoying, and I don't think I've heard anyone complaining that this was too verbose or slowing down the boot, so I'd be tempted to keep it like that, and least for the information printed in this function.