From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxl: Include range.h in cxl.h
Date: Tue, 1 Jul 2025 16:03:39 +0100 [thread overview]
Message-ID: <20250701160339.000042f5@huawei.com> (raw)
In-Reply-To: <20250701-cxl-fix-struct-range-error-v1-1-1f199bddc7c9@kernel.org>
On Tue, 01 Jul 2025 07:33:31 -0700
Nathan Chancellor <nathan@kernel.org> wrote:
> After commit aefeb286b960 ("libnvdimm: Don't use "proxy" headers"),
> range.h may not be implicitly included, resulting in a build error:
>
> In file included from drivers/cxl/core/features.c:8:
> drivers/cxl/cxl.h:365:22: error: field 'hpa_range' has incomplete type
> 365 | struct range hpa_range;
> | ^~~~~~~~~
> drivers/cxl/cxl.h:562:22: error: field 'hpa_range' has incomplete type
> 562 | struct range hpa_range;
> | ^~~~~~~~~
> drivers/cxl/cxl.h:570:22: error: field 'hpa_range' has incomplete type
> 570 | struct range hpa_range;
> | ^~~~~~~~~
> drivers/cxl/cxl.h:803:22: error: array type has incomplete element type 'struct range'
> 803 | struct range dvsec_range[2];
> | ^~~~~~~~~~~
>
> Include range.h in cxl.h explicitly to clear up the errors.
>
> Fixes: aefeb286b960 ("libnvdimm: Don't use "proxy" headers")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
next prev parent reply other threads:[~2025-07-01 15:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 14:33 [PATCH] cxl: Include range.h in cxl.h Nathan Chancellor
2025-07-01 15:03 ` Jonathan Cameron [this message]
2025-07-01 15:10 ` Dave Jiang
2025-07-01 15:20 ` Ira Weiny
2025-07-01 15:38 ` Nathan Chancellor
2025-07-01 16:14 ` Ira Weiny
2025-07-01 19:14 ` Andy Shevchenko
2025-07-01 16:21 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250701160339.000042f5@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox