From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43FCA125D6 for ; Tue, 1 Jul 2025 17:06:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751389614; cv=none; b=E+C1SeWF4a71WeDeCb/MfZETtsem0kR/6VSe33p446I3iUR8HDo+V5nBLDnDU+dd+WC3Un7GyH5g2+s6T8KLk6rB/xTN8OGS2Lf+6zWkkQ7lY52VN2XOFy8TzeZOr4tvW+XIOOwuQfOu6qQTy209zRe2ZEdKtX8JUDQKaN1AK3w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751389614; c=relaxed/simple; bh=WpjLH/E4cjfGcA5aVL0NX4+IgiTYP+bFhGzng+IGIMc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YpUj33nnRimD/bxTpzAEOZkvDn8xE6qL5PV7a6fP0RdWdl/Y1jNKzfQxfw04w+Jbkckf9kmTft+2HKcf5/Ya6eWNEkGXyT7+k7NzFFhh2qDxb1xRMKnSMiZFBtlycxEpxUZIgnXW5ZAR6Blhy4kia9xG0KtAjsit1Gg+T0ek6sg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=QlzYJrh+; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QlzYJrh+" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-237f270513bso198365ad.1 for ; Tue, 01 Jul 2025 10:06:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1751389613; x=1751994413; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RuV+zYZlBXFCb4jtObBSN/YWaKNaSZemTX8LVanYMvQ=; b=QlzYJrh+fZUfghsUEeLpz/OaWHx8XzqL6Uzlv4+voMGqBx6tst4zId8luAvNhP/XVO RIf/2an7ZxyqFyCIwpArc/BzS/6m6wm6+BKO7kv/vID3OXcIJGAG1q7I3KLtTvfLrsXA +YKH+a1IrqdHHzPbfNwYBKJ9DgMeis+o+3621tQi+fjl/b26iAQVvlpYg5DVsBXOtLqL rkezz0drkUKU4Yd/pyp5T0b35TU4qS/BSdWdHFOknb5YdwyVddvb0Ffl82i5QULqXbE5 HWn1TM4i77zZiQnCDOecj/z+yM7BuPoWxefI5++3Zn3ZCejWCtU1fAMp7LM8l5teAoJv 7YfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751389613; x=1751994413; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RuV+zYZlBXFCb4jtObBSN/YWaKNaSZemTX8LVanYMvQ=; b=GH+KgQN1q/tA7HWRg7zxSw2NS73l9hOj5ghWWFGmZr6UhKeW5TzWwyJtnlmBmYxsMB P8WKpjZD6haCP4cm2P8KiicGKJaa9UD4qRY95z3Z7pad+top48NP3/kZ3kU2ZJFf+gJt qb0417pydmAfa4c4LwZwsSbMCf608uQYdlXzwvH26BuGhB05bUpvFW5Qd5uaJUYUmCgq yyogtXdtPsR4aF+TaE4wxDuQBgiQxAvPg+vovj+7uyOfhM2ZR3B37Pm9L7joDSJ9QdNV P7jx2rUzqrYOFQcqMxjDTkDgJzQzCf4f+PP1XHUKiY/WjeYwyFFyhcMqRKFW9hTcADi/ WvhA== X-Forwarded-Encrypted: i=1; AJvYcCWpXEdG2Tw4QaCX8oQm7biQq6Nwi702yARteWGMrt6BnzeokIGXHUZr4ZzWR9vsfhPjBFPt0nalshk2Gig=@vger.kernel.org X-Gm-Message-State: AOJu0YxEJdn6eUK19uLj3ABl0FoaB+FtbN6z4czxKOb7yW5uEpAQZz9G o9ENR8be36mVvmgi30VFxuSpvyD1QzZx4e5J6Wst8VOak/fZhg/hO0804ZF1+9zp0Q== X-Gm-Gg: ASbGncviJk8I2hKHfHwIMM+cIJtIGMfhMisw2DFONRRfdqqvCqlEJmSnOuBH2xRh9im Budul92c9MQ9ynteDKdw1wC7mRYK8yIqHW8YreGVO0bKNHetXEsPm9rXnQzCPNroZ2Bux92BnE9 mPK25FLUW5WdggdknGmHQvScWQLDI4aQRKd2SdtNrt/4VUflnXHKeYkgAH13X7CHia4fBhmNFp0 7vXMIcZZBBKWlOh8lv8edOCTClgdz0jSoPpJh08JoYkDw8LC14U4UIHQeUysh75Qec1fZ1yEuS5 3UMTsD1gqw+5HzI2g0jexn18tLcE3rmPIrxsKphjRTvU6LX4wdriNmlpMrnvKVW3dFS3avxpMBb VH/C0IQkljpR6J+t/lOXQObxuQFqGCg== X-Google-Smtp-Source: AGHT+IH3gvTNWjgUOSwEDk0Lnl1+DmC8Fu1pmwaP64IY32Oe1R+ZFxuAFpTFlieVchNMl10+qUaQLA== X-Received: by 2002:a17:902:c407:b0:215:42a3:e844 with SMTP id d9443c01a7336-23c5ffbdd35mr3174365ad.17.1751389612305; Tue, 01 Jul 2025 10:06:52 -0700 (PDT) Received: from google.com (106.81.125.34.bc.googleusercontent.com. [34.125.81.106]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23acb2e2423sm109764245ad.37.2025.07.01.10.06.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jul 2025 10:06:51 -0700 (PDT) Date: Tue, 1 Jul 2025 17:06:47 +0000 From: Sami Tolvanen To: Giuliano Procida Cc: Masahiro Yamada , Greg Kroah-Hartman , linux-modules@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] gendwarfksyms: use preferred form of sizeof for allocation Message-ID: <20250701170647.GA2234472@google.com> References: <20250701152000.2477659-1-gprocida@google.com> <20250701152000.2477659-2-gprocida@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250701152000.2477659-2-gprocida@google.com> On Tue, Jul 01, 2025 at 04:19:10PM +0100, Giuliano Procida wrote: > The preferred form is to use the variable being allocated to, rather > than explicitly supplying a type name which might become stale. > > Also do this for memset. > > Suggested-by: Masahiro Yamada > Signed-off-by: Giuliano Procida Reviewed-by: Sami Tolvanen Sami