From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D73CB676 for ; Thu, 3 Jul 2025 11:24:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751541898; cv=none; b=dbkwIFKK0df2JB5LQzSp/rzsZpRr34pj1qVbw6pe59FGHxTtvjmMD5PDpihPf6eWMj4DtORDTISIJHAbE6xn01muDzs14zPUgZ63XDzhEvSTSjd8iFzPyKLMj3wOWn3AkrviT6oENo0ZbXAgc822kVYJ0uCnF7Gt9v5QHXgJc9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751541898; c=relaxed/simple; bh=BsV0eSUAnrB3wda6T9wzig3D/sNdr+8qBzppAP467XI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XuxWBd9Dzciou6qbGOsOHuj+wP2nCHiYRbEkVrl1fsX+OnpFhQa9dzkWSY4y4arMLcfXhhUqJjrJSVJTVVnaDUE2CgFTFqazDJrndRuQi1gAIsnM9tAmFHOSE38Wp4KO3A1EkZwooa9fhZEn+kSkc4GMlmW9gL7mxDDc59LLx2g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UKWn5ARH; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UKWn5ARH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751541895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W9Ys+B0kKW0I1OmxDH3RChxDm9/AfOdFHpxEknTEX7s=; b=UKWn5ARHmQ9AO9G3hZRhtpm5gPe4z0r9vdj/UXxBusXHHd1vvjMrSlYhG+rO50pEzXhxPY drD2zf5lOcjmtwtzDvYPOOH05UODaKQs6XWf+rOauqNVcMxWbs/CvhZL17jCXHg3EooMPF f3B/QAye2EvYzPwFVVhqppGxYUHD/Q8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-LQqq5v6tMEuRVVqcDADkbA-1; Thu, 03 Jul 2025 07:24:54 -0400 X-MC-Unique: LQqq5v6tMEuRVVqcDADkbA-1 X-Mimecast-MFC-AGG-ID: LQqq5v6tMEuRVVqcDADkbA_1751541893 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-453a5d50b81so27878515e9.1 for ; Thu, 03 Jul 2025 04:24:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751541893; x=1752146693; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=W9Ys+B0kKW0I1OmxDH3RChxDm9/AfOdFHpxEknTEX7s=; b=RFXOB6xq/Sdtb+OL74rjjLpcoERMr70q9YPQzig5zz1sHKj4EkGctGL1X+qsSOFk/a ixJ8Sx69dmZxRIinbjLJSZg824dWKkNa07IHJoEvCUz+8PAIAVYnl+OVzIdobPmydP0d M/zn28Nyecd+O2BMNj1KTqGHvvoDnU7Rnftdy7v8c3UlfNVIg3EhkXpbliWUIJdT6VO2 xXmnC5Xl8yq0XtOm1hPjVHNWvLtJCF6cndRGAZGeKyZWeZV168PypS88WVgrncu/ePwb 63VfClOewQaOgfjjwObYCLjv02wfp5/mJ8HQcRYVHSXBcFW4l1/Xai7ovQ4+z2/sJJXp GTew== X-Forwarded-Encrypted: i=1; AJvYcCUAGJnCZ7KlOZTHVd7NTkgMJkHzi7j0t2pGRJClm7JLdx2m+sRFttCXVQj2+hekA9fjPPiHi+7ahTmiAwg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4F3sGdfSWDf/xTJtjLnxR17sVwqVGvoaIy/jvtEg3m2Ko2Imi cqQdv+nrwuQ+yxqob/lTBz98cyekHQa+C6zxsiVUL60CaRWzZi75dbmqBPUNQPv7XNcZxnvqpIY tO5Yu/7FLeX1T7f/iyB8J++mYLT/YLfVz758Wlj7cr3pdhQCBFCs9wwm2XP+05ZyGSkB8uAlfew == X-Gm-Gg: ASbGncvm08NLIMGJfofhl+95muvyCDLMFGJObkrHfGm07PffXsmRf1kboNxoT+uRYON UkFyBA2ZLYbWa2IS9FAR8iN3FksEfBeYuvv9SJ5uj6i3rIjXcKFzsaNI7KgKyRB/1bU/eji2C5m JOH10aslEo5C00Z+S6tyTzuwj9ELKXKatAnb9uZdVhlYTy6OijQLhTG92XpS3Nel0AOXUjTdk/N btMUWhyqJaiPY+7InIU4BxQzXs/xt7K5JEcMYmcE+04Kv5uvfvUaT+5ah7k8QAQGu7qjcUxqkG7 nUMxZPT30e7S8s+Z X-Received: by 2002:a05:600c:3b9f:b0:453:6b3a:6c06 with SMTP id 5b1f17b1804b1-454a4311ca9mr61059035e9.29.1751541892604; Thu, 03 Jul 2025 04:24:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQ4owisLty2PWAU9CFlsOOvJcG4PRg4iHjZY5ASRNKjngFo9l8E2RNGlgQIxnBwYpnCVU+kw== X-Received: by 2002:a05:600c:3b9f:b0:453:6b3a:6c06 with SMTP id 5b1f17b1804b1-454a4311ca9mr61058815e9.29.1751541892171; Thu, 03 Jul 2025 04:24:52 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:152e:1400:856d:9957:3ec3:1ddc]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454a9978c83sm24183675e9.13.2025.07.03.04.24.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 04:24:51 -0700 (PDT) Date: Thu, 3 Jul 2025 07:24:49 -0400 From: "Michael S. Tsirkin" To: Stefano Garzarella Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bobby Eshleman , Jakub Kicinski , Simon Horman , Paolo Abeni , virtualization@lists.linux.dev, bpf@vger.kernel.org, "David S. Miller" , Eric Dumazet Subject: Re: [PATCH net] vsock: fix `vsock_proto` declaration Message-ID: <20250703072443-mutt-send-email-mst@kernel.org> References: <20250703112329.28365-1-sgarzare@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250703112329.28365-1-sgarzare@redhat.com> On Thu, Jul 03, 2025 at 01:23:29PM +0200, Stefano Garzarella wrote: > From: Stefano Garzarella > > >From commit 634f1a7110b4 ("vsock: support sockmap"), `struct proto > vsock_proto`, defined in af_vsock.c, is not static anymore, since it's > used by vsock_bpf.c. > > If CONFIG_BPF_SYSCALL is not defined, `make C=2` will print a warning: > $ make O=build C=2 W=1 net/vmw_vsock/ > ... > CC [M] net/vmw_vsock/af_vsock.o > CHECK ../net/vmw_vsock/af_vsock.c > ../net/vmw_vsock/af_vsock.c:123:14: warning: symbol 'vsock_proto' was not declared. Should it be static? > > Declare `vsock_proto` regardless of CONFIG_BPF_SYSCALL, since it's defined > in af_vsock.c, which is built regardless of CONFIG_BPF_SYSCALL. > > Fixes: 634f1a7110b4 ("vsock: support sockmap") > Signed-off-by: Stefano Garzarella Acked-by: Michael S. Tsirkin > --- > include/net/af_vsock.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h > index d56e6e135158..d40e978126e3 100644 > --- a/include/net/af_vsock.h > +++ b/include/net/af_vsock.h > @@ -243,8 +243,8 @@ int __vsock_dgram_recvmsg(struct socket *sock, struct msghdr *msg, > int vsock_dgram_recvmsg(struct socket *sock, struct msghdr *msg, > size_t len, int flags); > > -#ifdef CONFIG_BPF_SYSCALL > extern struct proto vsock_proto; > +#ifdef CONFIG_BPF_SYSCALL > int vsock_bpf_update_proto(struct sock *sk, struct sk_psock *psock, bool restore); > void __init vsock_bpf_build_proto(void); > #else > -- > 2.50.0