From: Steven Rostedt <rostedt@goodmis.org>
To: Alexandre Ghiti <alex@ghiti.fr>
Cc: ChenMiao <chenmiao.ku@gmail.com>,
Linux RISCV <linux-riscv@vger.kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection
Date: Thu, 3 Jul 2025 11:40:18 -0400 [thread overview]
Message-ID: <20250703114018.6fab0b8a@batman.local.home> (raw)
In-Reply-To: <f7e12c6d-892e-4ca3-9ef0-fbb524d04a48@ghiti.fr>
On Thu, 3 Jul 2025 15:00:02 +0200
Alexandre Ghiti <alex@ghiti.fr> wrote:
>
> We could support static ftrace, but I don't think we should, so I agree
> with this patch. In fact I had just prepared a patch for this here
> https://github.com/linux-riscv/linux/pull/556/commits/0481092a5bec3818658981c11f629e06e66382b3
> which is a bit more complete since I have removed some dead code.
>
> Let's see what other people think about supporting static ftrace, I have
> added Steven in cc if he has an opinion.
Yes, please only support the dynamic ftrace. The static is there only
to help archs to get ftrace up and running. Once dynamic is supported,
static should not be used.
Hmm, maybe I should just remove the prompt for DYNAMIC_FTRACE.
That is, once it is supported by an architecture, it should be the only
thing used.
-- Steve
next prev parent reply other threads:[~2025-07-03 15:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 8:45 [PATCH] riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection ChenMiao
2025-07-03 13:00 ` Alexandre Ghiti
2025-07-03 15:40 ` Steven Rostedt [this message]
2025-07-03 16:06 ` Alexandre Ghiti
[not found] ` <CAKxVwgeDcqo83ZV+xBcHwNuMk6yeU+yp7RYo22OARAVOBgrsJQ@mail.gmail.com>
2025-07-04 12:28 ` Alexandre Ghiti
2025-07-04 12:41 ` Steven Rostedt
2025-07-04 15:42 ` Miao Chen
-- strict thread matches above, loose matches on Subject: below --
2025-07-03 8:48 ChenMiao
2025-07-04 2:22 ` kernel test robot
2025-07-06 2:12 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250703114018.6fab0b8a@batman.local.home \
--to=rostedt@goodmis.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=chenmiao.ku@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-riscv@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox